[GitHub] [hive] yongzhi commented on a change in pull request #1721: HIVE-24456: Added HiveConf to check if FIPS mode is enabled, if so co…

[GitBox <gi...@apache.org>]

yongzhi commented on a change in pull request #1721:
URL: https://github.com/apache/hive/pull/1721#discussion_r563878086



##########
File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
##########
@@ -4075,6 +4075,9 @@ private static void populateLlapDaemonVarsSet(Set<String> llapDaemonVarsSetLocal
         "If hive (in tez mode only) cannot find a usable hive jar in \"hive.jar.directory\", \n" +
         "it will upload the hive jar to \"hive.user.install.directory/user.name\"\n" +
         "and use it to run queries."),
+    HIVE_MASKING_ALGO("hive.masking.algo","sha256", "This property is used to indicate whether " +

Review comment:
       Why do we need a new property, could we just change the algorithm to sha512?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org