You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/04/12 00:20:24 UTC

[GitHub] [spark] WeichenXu123 commented on issue #24354: [SPARK-25348][SQL][ML] Data source for binary files

WeichenXu123 commented on issue #24354: [SPARK-25348][SQL][ML] Data source for binary files
URL: https://github.com/apache/spark/pull/24354#issuecomment-482387357
 
 
   @mengxr 
   
   Discussion:
   
   * Change option name `pathFilterRegex` ? The hadoop glob do not support full regex syntax.
   * Figure out a proper way to implement option `maxBytesPerPartition` ? Current datasource will automatically determine the partition number but do not providing related interface to control it.
   * The option `pathFilterRegex` do we need to specify the full path filter ? Because in the `spark.read.format(...).load(path)` we has already specify the directory path, so the `pathFilterRegex` we could only specify the last part of the full path.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org