You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "lucasssvaz (via GitHub)" <gi...@apache.org> on 2023/03/07 22:20:06 UTC
[GitHub] [nuttx] lucasssvaz opened a new pull request, #8760: boards: Add CoreMark config to ESP boards
lucasssvaz opened a new pull request, #8760:
URL: https://github.com/apache/nuttx/pull/8760
## Summary
Add defconfigs to run CoreMark on ESP boards.
As the NSH degrades the score by about 29%, the application is run directly as the entry point.
## Impact
Accurate CoreMark benchmarks on ESP boards using NuttX.
## Testing
Tested using the provided configs with the corresponding devkit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] lucasssvaz commented on a diff in pull request #8760: boards: Add CoreMark config to ESP boards
Posted by "lucasssvaz (via GitHub)" <gi...@apache.org>.
lucasssvaz commented on code in PR #8760:
URL: https://github.com/apache/nuttx/pull/8760#discussion_r1128812616
##########
boards/xtensa/esp32/esp32-devkitc/configs/coremark/defconfig:
##########
@@ -21,39 +20,22 @@ CONFIG_ARCH_STACKDUMP=y
CONFIG_ARCH_XTENSA=y
CONFIG_BENCHMARK_COREMARK=y
CONFIG_BOARD_LOOPSPERMSEC=16717
-CONFIG_BUILTIN=y
-CONFIG_DEBUG_FULLOPT=y
-CONFIG_DEBUG_SYMBOLS=y
+CONFIG_DEBUG_CUSTOMOPT=y
+CONFIG_DEBUG_OPTLEVEL="-O3"
CONFIG_ESP32_UART0=y
-CONFIG_EXAMPLES_HELLO=y
CONFIG_FS_PROCFS=y
-CONFIG_HAVE_CXX=y
-CONFIG_HAVE_CXXINITIALIZE=y
CONFIG_IDLETHREAD_STACKSIZE=3072
-CONFIG_INIT_ENTRYPOINT="nsh_main"
+CONFIG_INIT_ENTRYPOINT="coremark_main"
CONFIG_INIT_STACKSIZE=3072
CONFIG_INTELHEX_BINARY=y
-CONFIG_MM_REGIONS=4
Review Comment:
My bad, I forgot to change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] gustavonihei commented on a diff in pull request #8760: boards: Add CoreMark config to ESP boards
Posted by "gustavonihei (via GitHub)" <gi...@apache.org>.
gustavonihei commented on code in PR #8760:
URL: https://github.com/apache/nuttx/pull/8760#discussion_r1128768686
##########
boards/xtensa/esp32/esp32-devkitc/configs/coremark/defconfig:
##########
@@ -21,39 +20,22 @@ CONFIG_ARCH_STACKDUMP=y
CONFIG_ARCH_XTENSA=y
CONFIG_BENCHMARK_COREMARK=y
CONFIG_BOARD_LOOPSPERMSEC=16717
-CONFIG_BUILTIN=y
-CONFIG_DEBUG_FULLOPT=y
-CONFIG_DEBUG_SYMBOLS=y
+CONFIG_DEBUG_CUSTOMOPT=y
+CONFIG_DEBUG_OPTLEVEL="-O3"
CONFIG_ESP32_UART0=y
-CONFIG_EXAMPLES_HELLO=y
CONFIG_FS_PROCFS=y
-CONFIG_HAVE_CXX=y
-CONFIG_HAVE_CXXINITIALIZE=y
CONFIG_IDLETHREAD_STACKSIZE=3072
-CONFIG_INIT_ENTRYPOINT="nsh_main"
+CONFIG_INIT_ENTRYPOINT="coremark_main"
CONFIG_INIT_STACKSIZE=3072
CONFIG_INTELHEX_BINARY=y
-CONFIG_MM_REGIONS=4
Review Comment:
`MM_REGIONS` should be set to 3 on ESP32 in order to fully utilize the Internal RAM as heap.
##########
boards/xtensa/esp32/esp32-devkitc/configs/coremark/defconfig:
##########
@@ -21,39 +20,22 @@ CONFIG_ARCH_STACKDUMP=y
CONFIG_ARCH_XTENSA=y
CONFIG_BENCHMARK_COREMARK=y
CONFIG_BOARD_LOOPSPERMSEC=16717
-CONFIG_BUILTIN=y
-CONFIG_DEBUG_FULLOPT=y
-CONFIG_DEBUG_SYMBOLS=y
+CONFIG_DEBUG_CUSTOMOPT=y
+CONFIG_DEBUG_OPTLEVEL="-O3"
CONFIG_ESP32_UART0=y
-CONFIG_EXAMPLES_HELLO=y
CONFIG_FS_PROCFS=y
-CONFIG_HAVE_CXX=y
-CONFIG_HAVE_CXXINITIALIZE=y
CONFIG_IDLETHREAD_STACKSIZE=3072
-CONFIG_INIT_ENTRYPOINT="nsh_main"
+CONFIG_INIT_ENTRYPOINT="coremark_main"
CONFIG_INIT_STACKSIZE=3072
CONFIG_INTELHEX_BINARY=y
-CONFIG_MM_REGIONS=4
Review Comment:
`MM_REGIONS` should be set to **3** on ESP32 in order to fully utilize the Internal RAM as heap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8760: boards: Add CoreMark config to ESP boards
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #8760:
URL: https://github.com/apache/nuttx/pull/8760
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org