[GitHub] [ozone] ashishkumar50 commented on pull request #4934: HDDS-8590. Implement a protocol call to get the rootCA from SCM

["ashishkumar50 (via GitHub)" <gi...@apache.org>]

ashishkumar50 commented on PR #4934:
URL: https://github.com/apache/ozone/pull/4934#issuecomment-1598605292

   @fapifta, Thanks for the explanation.
   My point is even if we add synchronize in both the methods `getAllRootCaCertificates`, `addNewRootCa`. It doesn't ensure read/write are safe enough. But as you mentioned since this has very low traffic and not on critical path
   we can just add synchronize in `addNewRootCa` to ensure no issue while writing.
   For read path I think we can remove synchronize, as multiple thread can read concurrently without any issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org