You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Mike Percy <mp...@apache.org> on 2013/01/24 02:35:39 UTC
Review Request: FLUME-1800: Docs for spooling source durability changes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9077/
-----------------------------------------------------------
Review request for Flume.
Description
-------
Mostly docs. Changed a couple params that were confusing. Also exposed inputCharset which was previously implemented but not available via source config.
This addresses bug FLUME-1800.
https://issues.apache.org/jira/browse/FLUME-1800
Diffs
-----
flume-ng-core/src/main/java/org/apache/flume/client/avro/ReliableSpoolingFileEventReader.java b19d0ea
flume-ng-core/src/main/java/org/apache/flume/source/SpoolDirectorySource.java 552bd48
flume-ng-core/src/main/java/org/apache/flume/source/SpoolDirectorySourceConfigurationConstants.java afc7288
flume-ng-core/src/test/java/org/apache/flume/client/avro/TestReliableSpoolingFileEventReader.java a29606e
flume-ng-doc/sphinx/FlumeUserGuide.rst aa92974
Diff: https://reviews.apache.org/r/9077/diff/
Testing
-------
Unit tests pass.
Thanks,
Mike Percy
Re: Review Request: FLUME-1800: Docs for spooling source durability changes
Posted by Alexander Alten-Lorenz <al...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9077/#review15686
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Alten-Lorenz
On Jan. 24, 2013, 1:35 a.m., Mike Percy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9077/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2013, 1:35 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Mostly docs. Changed a couple params that were confusing. Also exposed inputCharset which was previously implemented but not available via source config.
>
>
> This addresses bug FLUME-1800.
> https://issues.apache.org/jira/browse/FLUME-1800
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/client/avro/ReliableSpoolingFileEventReader.java b19d0ea
> flume-ng-core/src/main/java/org/apache/flume/source/SpoolDirectorySource.java 552bd48
> flume-ng-core/src/main/java/org/apache/flume/source/SpoolDirectorySourceConfigurationConstants.java afc7288
> flume-ng-core/src/test/java/org/apache/flume/client/avro/TestReliableSpoolingFileEventReader.java a29606e
> flume-ng-doc/sphinx/FlumeUserGuide.rst aa92974
>
> Diff: https://reviews.apache.org/r/9077/diff/
>
>
> Testing
> -------
>
> Unit tests pass.
>
>
> Thanks,
>
> Mike Percy
>
>
Re: Review Request: FLUME-1800: Docs for spooling source durability changes
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9077/#review15705
-----------------------------------------------------------
Looks good, running tests.
- Brock Noland
On Jan. 24, 2013, 1:35 a.m., Mike Percy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9077/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2013, 1:35 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Mostly docs. Changed a couple params that were confusing. Also exposed inputCharset which was previously implemented but not available via source config.
>
>
> This addresses bug FLUME-1800.
> https://issues.apache.org/jira/browse/FLUME-1800
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/client/avro/ReliableSpoolingFileEventReader.java b19d0ea
> flume-ng-core/src/main/java/org/apache/flume/source/SpoolDirectorySource.java 552bd48
> flume-ng-core/src/main/java/org/apache/flume/source/SpoolDirectorySourceConfigurationConstants.java afc7288
> flume-ng-core/src/test/java/org/apache/flume/client/avro/TestReliableSpoolingFileEventReader.java a29606e
> flume-ng-doc/sphinx/FlumeUserGuide.rst aa92974
>
> Diff: https://reviews.apache.org/r/9077/diff/
>
>
> Testing
> -------
>
> Unit tests pass.
>
>
> Thanks,
>
> Mike Percy
>
>
Re: Review Request: FLUME-1800: Docs for spooling source durability changes
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9077/#review15706
-----------------------------------------------------------
Ship it!
Ship It!
- Brock Noland
On Jan. 24, 2013, 1:35 a.m., Mike Percy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9077/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2013, 1:35 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Mostly docs. Changed a couple params that were confusing. Also exposed inputCharset which was previously implemented but not available via source config.
>
>
> This addresses bug FLUME-1800.
> https://issues.apache.org/jira/browse/FLUME-1800
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/client/avro/ReliableSpoolingFileEventReader.java b19d0ea
> flume-ng-core/src/main/java/org/apache/flume/source/SpoolDirectorySource.java 552bd48
> flume-ng-core/src/main/java/org/apache/flume/source/SpoolDirectorySourceConfigurationConstants.java afc7288
> flume-ng-core/src/test/java/org/apache/flume/client/avro/TestReliableSpoolingFileEventReader.java a29606e
> flume-ng-doc/sphinx/FlumeUserGuide.rst aa92974
>
> Diff: https://reviews.apache.org/r/9077/diff/
>
>
> Testing
> -------
>
> Unit tests pass.
>
>
> Thanks,
>
> Mike Percy
>
>