[GitHub] [ozone] bshashikant commented on a change in pull request #1929: HDDS-4811.Use OM style config to construct RaftGroup and initialize Raft Servers

[GitBox <gi...@apache.org>]

bshashikant commented on a change in pull request #1929:
URL: https://github.com/apache/ozone/pull/1929#discussion_r577355177



##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMRatisServerImpl.java
##########
@@ -313,6 +313,13 @@ public RaftPeerId getPeerId() {
       List<RaftPeer> raftPeers = new ArrayList<>();
       // Add this Ratis server to the Ratis ring
       raftPeers.add(localRaftPeer);
+      for (SCMNodeDetails nodeDetails : details.getPeerNodeDetails()) {

Review comment:
       I think , we need to add the peers depending upon whether SCM needs to start as single node server(1st regular start) or participate in 3 node ring(subsequent restarts). Let's hold on to this change for now and i will take care of this in the bootstrap sequence.
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org