You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/08/16 22:31:41 UTC
[GitHub] [incubator-druid] clintropolis commented on issue #8328: [DISCUSS]
Code generation for commonly implemented basic methods
clintropolis commented on issue #8328: [DISCUSS] Code generation for commonly implemented basic methods
URL: https://github.com/apache/incubator-druid/issues/8328#issuecomment-522171053
This seems an interesting idea, but we have to be _very careful_ when doing and reviewing this to make sure we don't lose any purposeful omissions or customizations done for performance reasons. I'm thinking of [things like this](https://github.com/apache/incubator-druid/pull/6488/files#diff-804f39ab6702c58b3d422f90625fee48R225) where a large or expensive to work with field is left out of all of those things on purpose. It might be very hard spot all of these if they are not documented, so this is potentially risky in that regard.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org