You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by cloud-fan <gi...@git.apache.org> on 2018/05/09 04:22:36 UTC

[GitHub] spark pull request #21145: [SPARK-24073][SQL]: Rename DataReaderFactory to I...

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21145#discussion_r186927701
  
    --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/DataSourceReader.java ---
    @@ -76,5 +76,5 @@
        * If this method fails (by throwing an exception), the action would fail and no Spark job was
        * submitted.
        */
    -  List<DataReaderFactory<Row>> createDataReaderFactories();
    +  List<InputPartition<Row>> planInputPartitions();
    --- End diff --
    
    in the hadoop world there is `InputFormat.getSplits`, shall we follow and use `getInputPartitions` here?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org