You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2022/01/12 16:21:40 UTC

[GitHub] [thrift] buptubuntu edited a comment on pull request #2497: THRIFT-5495: close client when shutdown server in go lib

buptubuntu edited a comment on pull request #2497:
URL: https://github.com/apache/thrift/pull/2497#issuecomment-1011220542


   > I don't know what's the best way to fix that. Maybe add a setting to `TSimpleServer` to sleep for a period of time before trying to abruptly close all connections is a ok short term solution. for long term we might need to make some breaking changes to `TProtocol`/`TTransport` to add the graceful shutdown semantic to them.
   
   the key is to prevent the server to hang for too long or hang for ever，because that will block in some pipeline inside a process
   
   i think the former is a better choice


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org