[GitHub] [airflow] mik-laj commented on a change in pull request #14152: Helm RBAC Best Practices

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #14152:
URL: https://github.com/apache/airflow/pull/14152#discussion_r619682130



##########
File path: chart/templates/cleanup/cleanup-serviceaccount.yaml
##########
@@ -18,11 +18,11 @@
 ################################
 ## Airflow Cleanup ServiceAccount
 #################################
-{{- if and .Values.rbacEnabled .Values.cleanup.enabled }}
+{{- if and .Values.cleanup.serviceAccount.create .Values.cleanup.enabled }}
 kind: ServiceAccount
 apiVersion: v1
 metadata:
-  name: {{ .Release.Name }}-cleanup
+  name: {{ include "cleanup.serviceAccountName" . }}
   labels:

Review comment:
       We should support annotation for the service account. It is needed for Workload Identity https://cloud.google.com/kubernetes-engine/docs/how-to/workload-identity




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org