[GitHub] jerrypeng commented on a change in pull request #2593: Add support for running python functions with wheel file

[GitBox <gi...@apache.org>]

jerrypeng commented on a change in pull request #2593: Add support for running python functions with wheel file
URL: https://github.com/apache/incubator-pulsar/pull/2593#discussion_r218982622
 
 

 ##########
 File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
 ##########
 @@ -229,6 +229,11 @@ void processArguments() throws Exception {
                 description = "Path to the main Python file for the function (if the function is written in Python)",
                 listConverter = StringConverter.class)
         protected String pyFile;
+        @Parameter(
+                names = "--pywheel",
+                description = "Path to the Python wheel file for the function (if the function is submitted as Python Wheel)",
+                listConverter = StringConverter.class)
 
 Review comment:
   why do we need a listConverter?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services