You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2022/07/04 13:52:16 UTC

[GitHub] [systemds] kev-inn commented on a diff in pull request #1649: [SYSTEMDS-3018] Dynamic recompilation of functions with Federated Planner

kev-inn commented on code in PR #1649:
URL: https://github.com/apache/systemds/pull/1649#discussion_r913026862


##########
src/main/java/org/apache/sysds/hops/rewrite/RewriteAlgebraicSimplificationDynamic.java:
##########
@@ -2398,7 +2399,9 @@ else if( bop.getOp() == OpOp2.MINUS && left.getDataType()==DataType.MATRIX
 			}
 			
 			//rewire parent-child operators if rewrite applied
-			if( ternop != null ) { 
+			if( ternop != null ) {
+				if (right.getForcedExecType() == Types.ExecType.FED)
+					ternop.setForcedExecType(Types.ExecType.FED);

Review Comment:
   This is necessary, because our planner might assume the output to be federated. The fused ternary instruction is generated to execute in CP mode. We could either stop those rewrites from the beginning or be careful where we have to add the fed execution mode.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org