You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2022/09/25 13:54:05 UTC
svn commit: r1904251 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSArray.java
Author: tilman
Date: Sun Sep 25 13:54:05 2022
New Revision: 1904251
URL: http://svn.apache.org/viewvc?rev=1904251&view=rev
Log:
PDFBOX-4892: optimize, as suggested by valerybokov
Modified:
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSArray.java
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSArray.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSArray.java?rev=1904251&r1=1904250&r2=1904251&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSArray.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSArray.java Sun Sep 25 13:54:05 2022
@@ -122,8 +122,10 @@ public class COSArray extends COSBase im
*/
public void retainAll( Collection<COSBase> objectsList )
{
- objects.retainAll( objectsList );
- getUpdateState().update();
+ if (objects.retainAll(objectsList))
+ {
+ getUpdateState().update();
+ }
}
/**
@@ -133,8 +135,10 @@ public class COSArray extends COSBase im
*/
public void addAll( Collection<COSBase> objectsList )
{
- objects.addAll( objectsList );
- getUpdateState().update(objectsList);
+ if (objects.addAll(objectsList))
+ {
+ getUpdateState().update(objectsList);
+ }
}
/**
@@ -146,8 +150,10 @@ public class COSArray extends COSBase im
{
if( objectList != null )
{
- objects.addAll( objectList.objects );
- getUpdateState().update(objectList);
+ if (objects.addAll(objectList.objects))
+ {
+ getUpdateState().update(objectList);
+ }
}
}
@@ -160,8 +166,10 @@ public class COSArray extends COSBase im
*/
public void addAll( int i, Collection<COSBase> objectList )
{
- objects.addAll( i, objectList );
- getUpdateState().update(objectList);
+ if (objects.addAll(i, objectList))
+ {
+ getUpdateState().update(objectList);
+ }
}
/**