You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Chengwei Yang <ch...@gmail.com> on 2014/03/13 08:20:32 UTC
Review Request 19175: [Doc] update for deploy-scripts
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19175/
-----------------------------------------------------------
Review request for mesos.
Bugs: MESOS-1091
https://issues.apache.org/jira/browse/MESOS-1091
Repository: mesos-git
Description
-------
[Doc] update for deploy-scripts
The deploy-scripts.md is quite out of date, let's align it with the
latest code base.
Diffs
-----
docs/deploy-scripts.md 0daba1f4f878ecdca5d51525123c8aef1806d441
Diff: https://reviews.apache.org/r/19175/diff/
Testing
-------
tested with markdown
Thanks,
Chengwei Yang
Re: Review Request 19175: [Doc] update for deploy-scripts
Posted by Chengwei Yang <ch...@gmail.com>.
> On April 22, 2014, 11:50 p.m., Niklas Nielsen wrote:
> > docs/deploy-scripts.md, line 11
> > <https://reviews.apache.org/r/19175/diff/1/?file=518209#file518209line11>
> >
> > How about s/(high-availability.md) for/(high-availability.md) documentation for/?
Sure, will upload new version of patch.
- Chengwei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19175/#review41028
-----------------------------------------------------------
On April 22, 2014, 11:49 p.m., Chengwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19175/
> -----------------------------------------------------------
>
> (Updated April 22, 2014, 11:49 p.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Bugs: MESOS-1091
> https://issues.apache.org/jira/browse/MESOS-1091
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> [Doc] update for deploy-scripts
>
> The deploy-scripts.md is quite out of date, let's align it with the
> latest code base.
>
>
> Diffs
> -----
>
> docs/deploy-scripts.md 0daba1f4f878ecdca5d51525123c8aef1806d441
>
> Diff: https://reviews.apache.org/r/19175/diff/
>
>
> Testing
> -------
>
> tested with markdown
>
>
> Thanks,
>
> Chengwei Yang
>
>
Re: Review Request 19175: [Doc] update for deploy-scripts
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19175/#review41028
-----------------------------------------------------------
Ship it!
Thanks Chengwei!
docs/deploy-scripts.md
<https://reviews.apache.org/r/19175/#comment74384>
How about s/(high-availability.md) for/(high-availability.md) documentation for/?
- Niklas Nielsen
On April 22, 2014, 8:49 a.m., Chengwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19175/
> -----------------------------------------------------------
>
> (Updated April 22, 2014, 8:49 a.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Bugs: MESOS-1091
> https://issues.apache.org/jira/browse/MESOS-1091
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> [Doc] update for deploy-scripts
>
> The deploy-scripts.md is quite out of date, let's align it with the
> latest code base.
>
>
> Diffs
> -----
>
> docs/deploy-scripts.md 0daba1f4f878ecdca5d51525123c8aef1806d441
>
> Diff: https://reviews.apache.org/r/19175/diff/
>
>
> Testing
> -------
>
> tested with markdown
>
>
> Thanks,
>
> Chengwei Yang
>
>
Re: Review Request 19175: [Doc] update for deploy-scripts
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19175/#review41481
-----------------------------------------------------------
Patch looks great!
Reviews applied: [19175]
All tests passed.
- Mesos ReviewBot
On April 22, 2014, 3:49 p.m., Chengwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19175/
> -----------------------------------------------------------
>
> (Updated April 22, 2014, 3:49 p.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Bugs: MESOS-1091
> https://issues.apache.org/jira/browse/MESOS-1091
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> [Doc] update for deploy-scripts
>
> The deploy-scripts.md is quite out of date, let's align it with the
> latest code base.
>
>
> Diffs
> -----
>
> docs/deploy-scripts.md 0daba1f4f878ecdca5d51525123c8aef1806d441
>
> Diff: https://reviews.apache.org/r/19175/diff/
>
>
> Testing
> -------
>
> tested with markdown
>
>
> Thanks,
>
> Chengwei Yang
>
>
Re: Review Request 19175: [Doc] update for deploy-scripts
Posted by Chengwei Yang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19175/
-----------------------------------------------------------
(Updated April 26, 2014, 9:29 a.m.)
Review request for mesos and Niklas Nielsen.
Changes
-------
Take Niklas comment.
Bugs: MESOS-1091
https://issues.apache.org/jira/browse/MESOS-1091
Repository: mesos-git
Description (updated)
-------
[Doc] update for deploy-scripts
The deploy-scripts.md is quite out of date, let's align it with the
latest code base.
Review: https://reviews.apache.org/r/19175
Diffs (updated)
-----
docs/deploy-scripts.md 0daba1f4f878ecdca5d51525123c8aef1806d441
Diff: https://reviews.apache.org/r/19175/diff/
Testing
-------
tested with markdown
Thanks,
Chengwei Yang
Re: Review Request 19175: [Doc] update for deploy-scripts
Posted by Chengwei Yang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19175/
-----------------------------------------------------------
(Updated April 22, 2014, 8:49 a.m.)
Review request for mesos and Niklas Nielsen.
Changes
-------
Assigning myself as shepherd
-- Niklas
Bugs: MESOS-1091
https://issues.apache.org/jira/browse/MESOS-1091
Repository: mesos-git
Description
-------
[Doc] update for deploy-scripts
The deploy-scripts.md is quite out of date, let's align it with the
latest code base.
Diffs
-----
docs/deploy-scripts.md 0daba1f4f878ecdca5d51525123c8aef1806d441
Diff: https://reviews.apache.org/r/19175/diff/
Testing
-------
tested with markdown
Thanks,
Chengwei Yang