[GitHub] [netbeans-tools] jpirek commented on a change in pull request #19: Fixing order of JS libs loaded, fixing img upload

[GitBox <gi...@apache.org>]

jpirek commented on a change in pull request #19: Fixing order of JS libs loaded, fixing img upload 
URL: https://github.com/apache/netbeans-tools/pull/19#discussion_r352062745
 
 

 ##########
 File path: pp3/module/Application/src/Application/Controller/PluginController.php
 ##########
 @@ -198,6 +192,12 @@ public function confirmAction() {
                         $plugin->addCategory($cat2);
                     }
                 }
+                // save image
 
 Review comment:
   This has been only moved after entity gets persisted so $plugin->getId() return correct ID

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists