You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/09/02 06:48:37 UTC

[GitHub] [shardingsphere] strongduanmu opened a new issue #12170: Add unit test for extractAllColumns method of ColumnExtractor

strongduanmu opened a new issue #12170:
URL: https://github.com/apache/shardingsphere/issues/12170


   This issue is for adding unit tests for the `extractAllColumns` method in ColumnExtractor.
   If you are interested, please leave a message.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] yy2so commented on issue #12170: Add more unit test for ProjectionEngine

Posted by GitBox <gi...@apache.org>.
yy2so commented on issue #12170:
URL: https://github.com/apache/shardingsphere/issues/12170#issuecomment-1041053483


   Hi @schrosolver would you still like to contribute and resolve this issue?
   
   Please share a status update with the community, thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] schrosolver commented on issue #12170: Add unit test for extractAllColumns method of ColumnExtractor

Posted by GitBox <gi...@apache.org>.
schrosolver commented on issue #12170:
URL: https://github.com/apache/shardingsphere/issues/12170#issuecomment-911979172


   Hello @strongduanmu
   I would like to contribute in this issue.
   
   I don't see this method in master branch.
   Could you please let me know if I should look into some other branch? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] yy2so commented on issue #12170: Add more unit test for ProjectionEngine

Posted by GitBox <gi...@apache.org>.
yy2so commented on issue #12170:
URL: https://github.com/apache/shardingsphere/issues/12170#issuecomment-1044853053


   > Thanks for reaching out. Sorry for the delay.
   > 
   > With my current bandwidth and commitments I might not be able to work on this until sometime. Please reassign this task to someone else, if they are interested.
   
   Hi @schrosolver thanks for the update. Noted, wie'll reassign.
   
   Hope to see you back in the ShardingSphere community soon.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu commented on issue #12170: Add unit test for extractAllColumns method of ColumnExtractor

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #12170:
URL: https://github.com/apache/shardingsphere/issues/12170#issuecomment-912174813


   Hi @schrosolver, welcome to leave a comment. This issue is for PR #12177, after it is merged, you can start working.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] schrosolver edited a comment on issue #12170: Add more unit test for ProjectionEngine

Posted by GitBox <gi...@apache.org>.
schrosolver edited a comment on issue #12170:
URL: https://github.com/apache/shardingsphere/issues/12170#issuecomment-913513650


   > @schrosolver I'm very sorry, the logic has been adjusted after review, I will modify the content of this issue.
   
   Sure no problem at all, Will start working on this and create a PR. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] schrosolver edited a comment on issue #12170: Add more unit test for ProjectionEngine

Posted by GitBox <gi...@apache.org>.
schrosolver edited a comment on issue #12170:
URL: https://github.com/apache/shardingsphere/issues/12170#issuecomment-1041240867


   Thanks for reaching out. Sorry for the delay.
   With my current bandwidth and commitments I might not be able to work on this until sometime. Please reassign this task to someone else, if they are interested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] TeslaCN commented on issue #12170: Add more unit test for ProjectionEngine

Posted by GitBox <gi...@apache.org>.
TeslaCN commented on issue #12170:
URL: https://github.com/apache/shardingsphere/issues/12170#issuecomment-1081344621


   There are about 24% lines in `ProjectionEngine` are not covered by `ProjectionEngineTest.` This issue will remain open.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu commented on issue #12170: Add unit test for extractAllColumns method of ColumnExtractor

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #12170:
URL: https://github.com/apache/shardingsphere/issues/12170#issuecomment-913268861


   @schrosolver I'm very sorry, the logic has been adjusted after review, I will modify the content of this issue.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] schrosolver commented on issue #12170: Add more unit test for ProjectionEngine

Posted by GitBox <gi...@apache.org>.
schrosolver commented on issue #12170:
URL: https://github.com/apache/shardingsphere/issues/12170#issuecomment-913513650


   > @schrosolver I'm very sorry, the logic has been adjusted after review, I will modify the content of this issue.
   
   Sure no problem at all, Will start working on this and create a PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] schrosolver commented on issue #12170: Add more unit test for ProjectionEngine

Posted by GitBox <gi...@apache.org>.
schrosolver commented on issue #12170:
URL: https://github.com/apache/shardingsphere/issues/12170#issuecomment-1041240867


   Thanks for reaching out. Sorry for the delay.
   With my current bandwidth and commitments I might not be able to work on this until sometime. Please reassign this task to someone else.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org