You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/13 01:13:43 UTC
[GitHub] [incubator-superset] etr2460 opened a new pull request #10297: feat: add download as image button to explore
etr2460 opened a new pull request #10297:
URL: https://github.com/apache/incubator-superset/pull/10297
### SUMMARY
This feature was recently added to charts on dashboards, I'm adding it to explore view as well
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<img width="275" alt="Screen Shot 2020-07-12 at 6 07 08 PM" src="https://user-images.githubusercontent.com/7409244/87261387-d48fe900-c46a-11ea-8716-4cd09514125f.png">
Example screenshot:
### TEST PLAN
CI and new unit test, test downloading an image from a saved chart and an unsaved chart
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [x] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
to: @ktmud @graceguo-supercat @suddjian
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 merged pull request #10297: feat: add download as image button to explore
Posted by GitBox <gi...@apache.org>.
etr2460 merged pull request #10297:
URL: https://github.com/apache/incubator-superset/pull/10297
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on pull request #10297: feat: add download as image button to explore
Posted by GitBox <gi...@apache.org>.
etr2460 commented on pull request #10297:
URL: https://github.com/apache/incubator-superset/pull/10297#issuecomment-657894664
also cc @ChristianMurphy as the original implementer of this feature in case he has feedback
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org