You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "911432 (via GitHub)" <gi...@apache.org> on 2023/03/31 01:24:12 UTC
[GitHub] [iceberg] 911432 opened a new pull request, #7246: Delete flink-connector.md
911432 opened a new pull request, #7246:
URL: https://github.com/apache/iceberg/pull/7246
Duplicate with 'flink-getting-started.md' and 'flink-ddl.md'. It looks unnecessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on pull request #7246: Delete flink-connector.md
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #7246:
URL: https://github.com/apache/iceberg/pull/7246#issuecomment-1506002433
@911432 this PR affects `docs/flink-connector.md` and I don't see the use of a connector described in the other files you mentioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] 911432 commented on pull request #7246: Explain how to connect external tables to Flink-DDL.md
Posted by "911432 (via GitHub)" <gi...@apache.org>.
911432 commented on PR #7246:
URL: https://github.com/apache/iceberg/pull/7246#issuecomment-1512388152
@Fokko @hililiwei
I explained how to connect external tables to flink-ddl.md
Please check about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] 911432 closed pull request #7246: Explain how to connect a external table.
Posted by "911432 (via GitHub)" <gi...@apache.org>.
911432 closed pull request #7246: Explain how to connect a external table.
URL: https://github.com/apache/iceberg/pull/7246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] 911432 commented on pull request #7246: Delete flink-connector.md
Posted by "911432 (via GitHub)" <gi...@apache.org>.
911432 commented on PR #7246:
URL: https://github.com/apache/iceberg/pull/7246#issuecomment-1506233955
I'll try extra on the DDL part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] hililiwei commented on pull request #7246: Delete flink-connector.md
Posted by "hililiwei (via GitHub)" <gi...@apache.org>.
hililiwei commented on PR #7246:
URL: https://github.com/apache/iceberg/pull/7246#issuecomment-1506183829
We should not delete this doc. It describes the Connector. It has a different emphasis from DDL.md.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on pull request #7246: Delete flink-connector.md
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #7246:
URL: https://github.com/apache/iceberg/pull/7246#issuecomment-1504807381
@911432 I'm not seeing this content in the other files you mentioned. I think we should add this one to the index.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] 911432 commented on pull request #7246: Explaining the use of external tables in Flink in DDL.md
Posted by "911432 (via GitHub)" <gi...@apache.org>.
911432 commented on PR #7246:
URL: https://github.com/apache/iceberg/pull/7246#issuecomment-1506490834
@Fokko @hililiwei
I explained connect external table on flink-ddl.md
Please check about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] 911432 commented on pull request #7246: Delete flink-connector.md
Posted by "911432 (via GitHub)" <gi...@apache.org>.
911432 commented on PR #7246:
URL: https://github.com/apache/iceberg/pull/7246#issuecomment-1505995064
@Fokko
flink-ddl.md is explained creating Catalog, DATABASE, Table.
flink-getting-started.md is explaind createing Catalog, Table and inserting table.
#7099
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] 911432 commented on pull request #7246: Delete flink-connector.md
Posted by "911432 (via GitHub)" <gi...@apache.org>.
911432 commented on PR #7246:
URL: https://github.com/apache/iceberg/pull/7246#issuecomment-1506193660
@Fokko @hililiwei I understand this document as importing an already created external table.
Thanks for the explanation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] 911432 commented on pull request #7246: Delete flink-connector.md
Posted by "911432 (via GitHub)" <gi...@apache.org>.
911432 commented on PR #7246:
URL: https://github.com/apache/iceberg/pull/7246#issuecomment-1505996400
@Fokko
flink-ddl.md is explained creating Catalog, DATABASE, Table.
flink-getting-started.md is explaind createing Catalog, Table and inserting table.
#7099 #7215
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] 911432 commented on pull request #7246: Delete flink-connector.md
Posted by "911432 (via GitHub)" <gi...@apache.org>.
911432 commented on PR #7246:
URL: https://github.com/apache/iceberg/pull/7246#issuecomment-1506021669
@Fokko
A brief introduction is here.
https://github.com/apache/iceberg/blob/master/docs/flink-getting-started.md
How to connect a catalog, a database, and a table is described here.
https://github.com/apache/iceberg/blob/master/docs/flink-ddl.md#create-table-like
Insert explaned this link about it.
https://github.com/apache/iceberg/blob/master/docs/flink-queries.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] 911432 commented on pull request #7246: Explain how to connect a external table.
Posted by "911432 (via GitHub)" <gi...@apache.org>.
911432 commented on PR #7246:
URL: https://github.com/apache/iceberg/pull/7246#issuecomment-1514179460
@Fokko @hililiwei
I explained how to connect external tables.
Please check about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] 911432 commented on pull request #7246: Delete flink-connector.md
Posted by "911432 (via GitHub)" <gi...@apache.org>.
911432 commented on PR #7246:
URL: https://github.com/apache/iceberg/pull/7246#issuecomment-1506192795
@Fokko @hililiwei I understood this document as importing an already created external table.
Thanks for the explanation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] 911432 commented on pull request #7246: External table linking explained in DDL.md
Posted by "911432 (via GitHub)" <gi...@apache.org>.
911432 commented on PR #7246:
URL: https://github.com/apache/iceberg/pull/7246#issuecomment-1510515023
@Fokko @hililiwei
I explained connecting external tables on flink-ddl.md
Please check about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] 911432 commented on pull request #7246: Explain how to connect a external table.
Posted by "911432 (via GitHub)" <gi...@apache.org>.
911432 commented on PR #7246:
URL: https://github.com/apache/iceberg/pull/7246#issuecomment-1517380188
I couldn't make a manual that fits the changing iceberg.
So I'll just change the link and upload it again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org