You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Vihang Karajgaonkar via Review Board <no...@reviews.apache.org> on 2017/11/15 22:50:20 UTC
Re: Review Request 63806: HIVE-16756 : Vectorization:
LongColModuloLongColumn throws java.lang.ArithmeticException: / by zero
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63806/
-----------------------------------------------------------
(Updated Nov. 15, 2017, 10:50 p.m.)
Review request for hive, Aihua Xu and Matt McCline.
Changes
-------
the fix was needed only in case of long % long expression. Removed changes to LongColDivideLongColumn.java and removed the unnecessary file ColumnDivideLong.txt
Summary (updated)
-----------------
HIVE-16756 : Vectorization: LongColModuloLongColumn throws java.lang.ArithmeticException: / by zero
Bugs: HIVE-16756
https://issues.apache.org/jira/browse/HIVE-16756
Repository: hive-git
Description (updated)
-------
HIVE-16756 : Vectorization: LongColModuloLongColumn throws java.lang.ArithmeticException: / by zero
Diffs (updated)
-----
ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideColumn.txt 8b586b1f00ce7d6081f973a5736100d8941f79bc
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColModuloLongColumn.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMod.java 6d3e82e9b96e012d875d947fa397c6c67df6a931
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java 21f6540512ec795171014d87a6fde0d0ea5f23cf
ql/src/test/queries/clientpositive/vectorization_div0.q 025d457807dd0642965a81c6b093e421c4acd0f8
ql/src/test/results/clientpositive/spark/vectorization_div0.q.out 631b0723fb0d7ab011ad2bfd7be4b33d11d76b1c
ql/src/test/results/clientpositive/tez/vectorization_div0.q.out 6c3354cb4a8cd439d86df7e6b0cf759ea4c04cd0
ql/src/test/results/clientpositive/vectorization_div0.q.out 97f1687b85193e681f26c61107a6d9266c1d87a2
vector-code-gen/src/org/apache/hadoop/hive/tools/GenVectorCode.java e58d4e91938dc266111042fe98b05a3d9c6fc5e9
Diff: https://reviews.apache.org/r/63806/diff/2/
Changes: https://reviews.apache.org/r/63806/diff/1-2/
Testing
-------
Thanks,
Vihang Karajgaonkar
Re: Review Request 63806: HIVE-16756 : Vectorization:
LongColModuloLongColumn throws java.lang.ArithmeticException: / by zero
Posted by Vihang Karajgaonkar via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63806/
-----------------------------------------------------------
(Updated Nov. 16, 2017, 5:21 a.m.)
Review request for hive, Aihua Xu and Matt McCline.
Changes
-------
added a test case
Bugs: HIVE-16756
https://issues.apache.org/jira/browse/HIVE-16756
Repository: hive-git
Description
-------
HIVE-16756 : Vectorization: LongColModuloLongColumn throws java.lang.ArithmeticException: / by zero
Diffs (updated)
-----
ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideColumn.txt 8b586b1f00ce7d6081f973a5736100d8941f79bc
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColModuloLongColumn.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMod.java 6d3e82e9b96e012d875d947fa397c6c67df6a931
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java 21f6540512ec795171014d87a6fde0d0ea5f23cf
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorArithmeticExpressions.java ea06ea0aefcf5e36f204eaad78131860b44298ae
ql/src/test/queries/clientpositive/vectorization_div0.q 025d457807dd0642965a81c6b093e421c4acd0f8
ql/src/test/results/clientpositive/spark/vectorization_div0.q.out 631b0723fb0d7ab011ad2bfd7be4b33d11d76b1c
ql/src/test/results/clientpositive/tez/vectorization_div0.q.out 6c3354cb4a8cd439d86df7e6b0cf759ea4c04cd0
ql/src/test/results/clientpositive/vectorization_div0.q.out 97f1687b85193e681f26c61107a6d9266c1d87a2
vector-code-gen/src/org/apache/hadoop/hive/tools/GenVectorCode.java e58d4e91938dc266111042fe98b05a3d9c6fc5e9
Diff: https://reviews.apache.org/r/63806/diff/3/
Changes: https://reviews.apache.org/r/63806/diff/2-3/
Testing
-------
Thanks,
Vihang Karajgaonkar