You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/07/20 10:15:49 UTC

[GitHub] [iceberg] dengzhhu653 opened a new pull request #2844: Hive: Reconnect client if connection exception is wrapped in RuntimeE…

dengzhhu653 opened a new pull request #2844:
URL: https://github.com/apache/iceberg/pull/2844


   …xception
   https://github.com/apache/iceberg/blob/d5443e3a34a4288441a015ab616d965557d78202/hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java#L303 wraps the internal exception into a RuntimeException and throws, the Hive client may fail to reconnect if if the internal exception is an exception that should reconnect. For example, 
   ```
   java.lang.RuntimeException: org.apache.thrift.transport.TTransportException: java.net.SocketTimeoutException: Read timed out
           at org.apache.iceberg.relocated.com.google.common.base.Throwables.propagate(Throwables.java:241)
           at org.apache.iceberg.common.DynMethods$UnboundMethod.invoke(DynMethods.java:80)
   ```
   Reusing the timeout client may result to `org.apache.thrift.TApplicationException: get_table failed: out of sequence response`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] dengzhhu653 commented on pull request #2844: Hive: Reconnect client if connection exception is wrapped in RuntimeE…

Posted by GitBox <gi...@apache.org>.
dengzhhu653 commented on pull request #2844:
URL: https://github.com/apache/iceberg/pull/2844#issuecomment-948230654


   > I think this may not necessary anymore because of #3099, what do you think?
   
   yeap, it's much better to use the proxy client for retrying, thank you for the feedback and comment.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] dengzhhu653 closed pull request #2844: Hive: Reconnect client if connection exception is wrapped in RuntimeE…

Posted by GitBox <gi...@apache.org>.
dengzhhu653 closed pull request #2844:
URL: https://github.com/apache/iceberg/pull/2844


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] szehon-ho commented on pull request #2844: Hive: Reconnect client if connection exception is wrapped in RuntimeE…

Posted by GitBox <gi...@apache.org>.
szehon-ho commented on pull request #2844:
URL: https://github.com/apache/iceberg/pull/2844#issuecomment-948217194


   I think this may not necessary anymore because of #3099, what do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org