You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2017/11/28 13:06:46 UTC
Review Request 64117: PERF stack fixes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64117/
-----------------------------------------------------------
Review request for Ambari, Attila Doroszlai, Sid Wagle, and Vitalyi Brodetskyi.
Bugs: AMBARI-22529
https://issues.apache.org/jira/browse/AMBARI-22529
Repository: ambari
Description
-------
Fixes:
1\. On call to advisor NPE is raised since stack_advisor is not present and
ServiceAdvisorType is null
2\. Perf stack hooks cannot detect ambari_agent_cache_dir. Since it is
constant. We can remove all the complicated logic of calculating it via
PYTHONPATH.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java f1c63bf717
ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py 833fdbc8ac
Diff: https://reviews.apache.org/r/64117/diff/1/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 64117: PERF stack fixes
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64117/#review192024
-----------------------------------------------------------
Ship it!
Ship It!
- Dmytro Sen
On Nov. 28, 2017, 1:07 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64117/
> -----------------------------------------------------------
>
> (Updated Nov. 28, 2017, 1:07 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Sid Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-22529
> https://issues.apache.org/jira/browse/AMBARI-22529
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fixes:
> 1. On call to advisor NPE is raised since stack_advisor is not present and
> ServiceAdvisorType is null
> 2. Perf stack hooks cannot detect ambari_agent_cache_dir in case install is done locally (not via deploy-gce-cluster.py)
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java f1c63bf717
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py 833fdbc8ac
>
>
> Diff: https://reviews.apache.org/r/64117/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 64117: PERF stack fixes
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64117/
-----------------------------------------------------------
(Updated Nov. 28, 2017, 1:07 p.m.)
Review request for Ambari, Attila Doroszlai, Sid Wagle, and Vitalyi Brodetskyi.
Bugs: AMBARI-22529
https://issues.apache.org/jira/browse/AMBARI-22529
Repository: ambari
Description (updated)
-------
Fixes:
1. On call to advisor NPE is raised since stack_advisor is not present and
ServiceAdvisorType is null
2. Perf stack hooks cannot detect ambari_agent_cache_dir in case install is done locally (not via deploy-gce-cluster.py)
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java f1c63bf717
ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py 833fdbc8ac
Diff: https://reviews.apache.org/r/64117/diff/1/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk