You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Ilan Ginzburg (Jira)" <ji...@apache.org> on 2019/11/14 12:23:00 UTC

[jira] [Created] (SOLR-13932) Review directory locking for Blob interactions

Ilan Ginzburg created SOLR-13932:
------------------------------------

             Summary: Review directory locking for Blob interactions
                 Key: SOLR-13932
                 URL: https://issues.apache.org/jira/browse/SOLR-13932
             Project: Solr
          Issue Type: Sub-task
            Reporter: Ilan Ginzburg


Review resolution of local index directory content vs Blob copy.

There has been wrong understanding of following line acquiring a lock on index directory.

 {{solrCore.getDirectoryFactory().get(indexDirPath, DirectoryFactory.DirContext.DEFAULT, solrCore.getSolrConfig().indexConfig.lockType);}}

From Yonik:

_A couple things about Directory locking.... the locks were only ever to prevent more than one IndexWriter from trying to modify the same index. The IndexWriter grabs a write lock once when it is created and does not release it until it is closed._ 

_Directories are not locked on acquisition of the Directory from the DirectoryFactory. See the IndexWriter constructor, where the lock is explicitly grabbed._

Review CorePushPull#pullUpdateFromBlob, ServerSideMetadata and other classes as relevant.

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org