You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Kenneth Giusti <kg...@apache.org> on 2013/11/06 21:28:57 UTC
Re: Review Request 15043: [Messenger/Java] Port internal store from C
implementation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15043/
-----------------------------------------------------------
(Updated Nov. 6, 2013, 8:28 p.m.)
Review request for qpid and Rafael Schloming.
Changes
-------
A more direct port from the C implementation WRT tracker management.
Bugs: proton-444
https://issues.apache.org/jira/browse/proton-444
Repository: qpid
Description
-------
First cut - all the python tests pass.
Diffs (updated)
-----
/proton/trunk/proton-c/src/messenger/store.c 1535439
/proton/trunk/proton-j/proton-api/src/main/java/org/apache/qpid/proton/amqp/transaction/Coordinator.java 1535439
/proton/trunk/proton-j/proton-api/src/main/java/org/apache/qpid/proton/amqp/transport/Source.java 1535439
/proton/trunk/proton-j/proton-api/src/main/java/org/apache/qpid/proton/amqp/transport/Target.java 1535439
/proton/trunk/proton-j/proton-api/src/main/java/org/apache/qpid/proton/messenger/Status.java 1535439
/proton/trunk/proton-j/proton/src/main/java/org/apache/qpid/proton/messenger/impl/MessengerImpl.java 1535439
/proton/trunk/proton-j/proton/src/main/java/org/apache/qpid/proton/messenger/impl/Store.java PRE-CREATION
/proton/trunk/proton-j/proton/src/main/java/org/apache/qpid/proton/messenger/impl/StoreEntry.java PRE-CREATION
/proton/trunk/proton-j/proton/src/main/java/org/apache/qpid/proton/messenger/impl/TrackerImpl.java 1535439
/proton/trunk/proton-j/proton/src/main/java/org/apache/qpid/proton/messenger/impl/TrackerQueue.java 1535439
Diff: https://reviews.apache.org/r/15043/diff/
Testing
-------
existing unit tests pass.
Thanks,
Kenneth Giusti
Re: Review Request 15043: [Messenger/Java] Port internal store from C
implementation.
Posted by Rafael Schloming <rh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15043/#review28436
-----------------------------------------------------------
Ship it!
Ship It!
- Rafael Schloming
On Nov. 6, 2013, 8:28 p.m., Kenneth Giusti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15043/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2013, 8:28 p.m.)
>
>
> Review request for qpid and Rafael Schloming.
>
>
> Bugs: proton-444
> https://issues.apache.org/jira/browse/proton-444
>
>
> Repository: qpid
>
>
> Description
> -------
>
> First cut - all the python tests pass.
>
>
> Diffs
> -----
>
> /proton/trunk/proton-c/src/messenger/store.c 1535439
> /proton/trunk/proton-j/proton-api/src/main/java/org/apache/qpid/proton/amqp/transaction/Coordinator.java 1535439
> /proton/trunk/proton-j/proton-api/src/main/java/org/apache/qpid/proton/amqp/transport/Source.java 1535439
> /proton/trunk/proton-j/proton-api/src/main/java/org/apache/qpid/proton/amqp/transport/Target.java 1535439
> /proton/trunk/proton-j/proton-api/src/main/java/org/apache/qpid/proton/messenger/Status.java 1535439
> /proton/trunk/proton-j/proton/src/main/java/org/apache/qpid/proton/messenger/impl/MessengerImpl.java 1535439
> /proton/trunk/proton-j/proton/src/main/java/org/apache/qpid/proton/messenger/impl/Store.java PRE-CREATION
> /proton/trunk/proton-j/proton/src/main/java/org/apache/qpid/proton/messenger/impl/StoreEntry.java PRE-CREATION
> /proton/trunk/proton-j/proton/src/main/java/org/apache/qpid/proton/messenger/impl/TrackerImpl.java 1535439
> /proton/trunk/proton-j/proton/src/main/java/org/apache/qpid/proton/messenger/impl/TrackerQueue.java 1535439
>
> Diff: https://reviews.apache.org/r/15043/diff/
>
>
> Testing
> -------
>
> existing unit tests pass.
>
>
> Thanks,
>
> Kenneth Giusti
>
>