You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by sl...@apache.org on 2026/08/18 20:43:36 UTC
(maven-wagon) branch tck-docs-junit5-3x created (now 6d552183)
This is an automated email from the ASF dual-hosted git repository.
slachiewicz pushed a change to branch tck-docs-junit5-3x
in repository https://gitbox.apache.org/repos/asf/maven-wagon.git
at 6d552183 Remove the dead JUnit 4 build configuration and stale references
This branch includes the following new commits:
new 6d552183 Remove the dead JUnit 4 build configuration and stale references
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
(maven-wagon) 01/01: Remove the dead JUnit 4 build configuration and stale references
Posted by sl...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
slachiewicz pushed a commit to branch tck-docs-junit5-3x
in repository https://gitbox.apache.org/repos/asf/maven-wagon.git
commit 6d5521834538db707e0652894b94155698da9b5f
Author: Sylwester Lachiewicz <sl...@apache.org>
AuthorDate: Tue Aug 18 22:43:10 2026 +0200
Remove the dead JUnit 4 build configuration and stale references
The four junit:junit exclusions no longer exclude anything: wagon-provider-test
stopped declaring junit, and stripping all four leaves junit:junit absent from
every resolved tree. Do not restore them with the managed version.
---
pom.xml | 7 +------
src/site/markdown/developer-guide.md | 7 ++++---
wagon-providers/pom.xml | 6 ------
wagon-providers/wagon-http-lightweight/pom.xml | 6 ------
wagon-providers/wagon-http/pom.xml | 6 ------
wagon-providers/wagon-scm/pom.xml | 2 +-
wagon-providers/wagon-ssh-common-test/pom.xml | 6 ------
.../org/apache/maven/wagon/providers/ssh/jsch/TestPrompter.java | 2 +-
.../wagon-ssh/src/test/resources/META-INF/plexus/components.xml | 2 +-
9 files changed, 8 insertions(+), 36 deletions(-)
diff --git a/pom.xml b/pom.xml
index 9a12a095..553a7470 100644
--- a/pom.xml
+++ b/pom.xml
@@ -189,11 +189,6 @@ under the License.
<artifactId>wagon-ssh-common</artifactId>
<version>${project.version}</version>
</dependency>
- <dependency>
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <version>4.13.2</version>
- </dependency>
<dependency>
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-testing</artifactId>
@@ -205,7 +200,7 @@ under the License.
<version>1.5.1</version>
</dependency>
<!--
- | The Plexus shim: org.eclipse.sisu.plexus supplies PlexusContainer and PlexusTestCase,
+ | The Plexus shim: org.eclipse.sisu.plexus supplies PlexusContainer,
| and understands both META-INF/plexus/components.xml and JSR-330 @Named beans.
| Its version is managed by maven-parent. Guice is "provided" in the sisu POM,
| so it has to be declared here explicitly.
diff --git a/src/site/markdown/developer-guide.md b/src/site/markdown/developer-guide.md
index 8e0d1f24..6871fb50 100644
--- a/src/site/markdown/developer-guide.md
+++ b/src/site/markdown/developer-guide.md
@@ -225,20 +225,21 @@ for the largest example of this in the project.
`wagon-provider-test` contains abstract test cases that exercise a provider through
the public API against a real endpoint that you set up. It is a `compile`-scope
-artifact that drags in JUnit 3-style `PlexusTestCase`, Mockito and Jetty; the
+artifact that drags in JUnit 5, `plexus-testing`, Mockito and Jetty; the
`wagon-providers` parent POM already declares it at `test` scope for every provider
module.
### `WagonTestCase`
-`WagonTestCase extends PlexusTestCase`. Two abstract methods:
+`WagonTestCase` is annotated `@PlexusTest` and implements `PlexusTestConfiguration`,
+which is what gives it a container. Two abstract methods:
```java
protected abstract String getProtocol(); // the role hint, e.g. "file"
protected abstract String getTestRepositoryUrl(); // where the tests should write
```
-`getWagon()` looks the provider up with `lookup(Wagon.ROLE, getProtocol())` and
+`getWagon()` looks the provider up with `container.lookup(Wagon.class, getProtocol())` and
attaches an `observers.Debug` as both session and transfer listener, so a failing run
prints a transcript.
diff --git a/wagon-providers/pom.xml b/wagon-providers/pom.xml
index dbed163b..6b0a9178 100644
--- a/wagon-providers/pom.xml
+++ b/wagon-providers/pom.xml
@@ -78,12 +78,6 @@ under the License.
<groupId>org.apache.maven.wagon</groupId>
<artifactId>wagon-provider-test</artifactId>
<scope>test</scope>
- <exclusions>
- <exclusion>
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- </exclusion>
- </exclusions>
</dependency>
</dependencies>
</project>
diff --git a/wagon-providers/wagon-http-lightweight/pom.xml b/wagon-providers/wagon-http-lightweight/pom.xml
index 155b6fbd..0c6754f7 100644
--- a/wagon-providers/wagon-http-lightweight/pom.xml
+++ b/wagon-providers/wagon-http-lightweight/pom.xml
@@ -49,12 +49,6 @@ under the License.
<artifactId>wagon-tck-http</artifactId>
<version>${project.version}</version>
<scope>test</scope>
- <exclusions>
- <exclusion>
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- </exclusion>
- </exclusions>
</dependency>
<dependency>
<groupId>org.codehaus.plexus</groupId>
diff --git a/wagon-providers/wagon-http/pom.xml b/wagon-providers/wagon-http/pom.xml
index 9b4f7094..8d635e60 100644
--- a/wagon-providers/wagon-http/pom.xml
+++ b/wagon-providers/wagon-http/pom.xml
@@ -108,12 +108,6 @@ under the License.
<artifactId>wagon-tck-http</artifactId>
<version>${project.version}</version>
<scope>test</scope>
- <exclusions>
- <exclusion>
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- </exclusion>
- </exclusions>
</dependency>
</dependencies>
diff --git a/wagon-providers/wagon-scm/pom.xml b/wagon-providers/wagon-scm/pom.xml
index 4f3f7dcd..1682899a 100644
--- a/wagon-providers/wagon-scm/pom.xml
+++ b/wagon-providers/wagon-scm/pom.xml
@@ -48,7 +48,7 @@ under the License.
<exclusions>
<!--
| Drags in plexus-container-default 1.0-alpha-9, which collides with the Plexus shim
- | (two copies of PlexusContainer/PlexusTestCase on the test classpath).
+ | (two copies of PlexusContainer on the test classpath).
-->
<exclusion>
<groupId>org.codehaus.plexus</groupId>
diff --git a/wagon-providers/wagon-ssh-common-test/pom.xml b/wagon-providers/wagon-ssh-common-test/pom.xml
index 0b4261cb..93b332a8 100644
--- a/wagon-providers/wagon-ssh-common-test/pom.xml
+++ b/wagon-providers/wagon-ssh-common-test/pom.xml
@@ -60,12 +60,6 @@ under the License.
<dependency>
<groupId>org.apache.maven.wagon</groupId>
<artifactId>wagon-provider-test</artifactId>
- <exclusions>
- <exclusion>
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- </exclusion>
- </exclusions>
</dependency>
<dependency>
<groupId>org.apache.maven.wagon</groupId>
diff --git a/wagon-providers/wagon-ssh/src/test/java/org/apache/maven/wagon/providers/ssh/jsch/TestPrompter.java b/wagon-providers/wagon-ssh/src/test/java/org/apache/maven/wagon/providers/ssh/jsch/TestPrompter.java
index 8bc9577b..84f85b7e 100644
--- a/wagon-providers/wagon-ssh/src/test/java/org/apache/maven/wagon/providers/ssh/jsch/TestPrompter.java
+++ b/wagon-providers/wagon-ssh/src/test/java/org/apache/maven/wagon/providers/ssh/jsch/TestPrompter.java
@@ -28,7 +28,7 @@
* {@code src/test/resources/META-INF/plexus/components.xml}.
* <p>
* {@code plexus-interactivity-api} stopped shipping a {@code META-INF/plexus/components.xml} in 1.3, so its
- * {@code DefaultPrompter} is invisible to the {@code plexus-container-default} that {@code PlexusTestCase} runs;
+ * {@code DefaultPrompter} is invisible to the {@code plexus-container-default} the tests run;
* without a replacement every {@code lookup( Wagon.ROLE, "scp" )} fails because {@code ConsoleInteractiveUserInfo}
* and {@code PrompterUIKeyboardInteractive} both require one.
* <p>
diff --git a/wagon-providers/wagon-ssh/src/test/resources/META-INF/plexus/components.xml b/wagon-providers/wagon-ssh/src/test/resources/META-INF/plexus/components.xml
index 5aa9211f..20b67f12 100644
--- a/wagon-providers/wagon-ssh/src/test/resources/META-INF/plexus/components.xml
+++ b/wagon-providers/wagon-ssh/src/test/resources/META-INF/plexus/components.xml
@@ -22,7 +22,7 @@
plexus-interactivity-api dropped its own META-INF/plexus/components.xml in 1.3 and only ships a sisu index, so
plexus-container-default cannot see DefaultPrompter (which in any case now takes its collaborators through a
constructor, which plexus-container-default cannot satisfy). Maven itself runs on sisu and is unaffected; only
- the PlexusTestCase-based tests here need this descriptor.
+ the tests here need this descriptor.
-->
<component-set>
<components>