You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/12/21 04:10:46 UTC
[GitHub] [skywalking] adamni135 opened a new pull request #4097: fix file
writer block application thread
adamni135 opened a new pull request #4097: fix file writer block application thread
URL: https://github.com/apache/skywalking/pull/4097
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Improve performance
- Related issues
https://github.com/apache/skywalking/issues/4087
___
### Bug fix
- Bug description.
when the log queue is full, File writer will block the business thread 2 millis, this will degrade performance very much
- How to fix?
using offer without waiting and print error log
___
### New feature or improvement
- Describe the details and related test reports.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4097:
fix file writer block application thread
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4097: fix file writer block application thread
URL: https://github.com/apache/skywalking/pull/4097#discussion_r360628025
##########
File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/logging/core/FileWriter.java
##########
@@ -72,6 +73,10 @@ private FileWriter() {
for (String log : outputLogs) {
writeToFile(log + Constants.LINE_SEPARATOR);
}
+ if(isQueueFull) { // system error print when the queue is full
+ System.err.println("file log queue is full.");
Review comment:
Take a look at what is system.err. There is a sync lock there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] adamni135 closed pull request #4097: fix file writer
block application thread
Posted by GitBox <gi...@apache.org>.
adamni135 closed pull request #4097: fix file writer block application thread
URL: https://github.com/apache/skywalking/pull/4097
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services