[GitHub] [lucene-solr] zacharymorn commented on pull request #2331: LUCENE-9322: Lucene90VectorWriter can leak open files

[GitBox <gi...@apache.org>]

zacharymorn commented on pull request #2331:
URL: https://github.com/apache/lucene-solr/pull/2331#issuecomment-777222542


   Hi, 
   
   I was looking into https://issues.apache.org/jira/browse/LUCENE-9639 earlier and had the same thought of `BaseVectorFormatTestCase` seems to be missing, which led me to do some search and found this PR. I'm wondering if unit test for `SimpleTextVectorFormat` could be added as part of this PR as well since it appears to be a small change? If it's better to keep this PR focused, I'm willing to pick that up and submit a PR once this one has merged. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org