You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "pitrou (via GitHub)" <gi...@apache.org> on 2024/08/14 13:33:57 UTC
[PR] GH-43688: [C++] Prevent Snappy from disabling RTTI when bundled [arrow]
pitrou opened a new pull request, #43689:
URL: https://github.com/apache/arrow/pull/43689
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
### What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
### Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
### Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43688: [C++] Prevent Snappy from disabling RTTI when bundled [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43689:
URL: https://github.com/apache/arrow/pull/43689#issuecomment-2289045944
Revision: 58adcdb1c0c6130be056d5250c9f83ab5d3efca1
Submitted crossbow builds: [ursacomputing/crossbow @ actions-33516a3bae](https://github.com/ursacomputing/crossbow/branches/all?query=actions-33516a3bae)
|Task|Status|
|----|------|
|test-conda-python-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/10389966320/job/28769293316)|
|test-ubuntu-22.04-cpp-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/10389966287/job/28769293256)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43688: [C++] Prevent Snappy from disabling RTTI when bundled [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43689:
URL: https://github.com/apache/arrow/pull/43689#issuecomment-2288789039
Revision: fe31f589484071f4da8360b54ae833ed54538fcf
Submitted crossbow builds: [ursacomputing/crossbow @ actions-cb70d346bc](https://github.com/ursacomputing/crossbow/branches/all?query=actions-cb70d346bc)
|Task|Status|
|----|------|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/10388720752/job/28764995785)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/10388720598/job/28764994703)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/10388721004/job/28764997319)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/10388720673/job/28764995122)|
|test-cuda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/10388720775/job/28764995923)|
|test-debian-12-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10388720845/job/28764996759)|
|test-debian-12-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/10388720814/job/28764996200)|
|test-fedora-39-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/10388721306/job/28764997662)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/10388720654/job/28764995049)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/10388720875/job/28764996666)|
|test-ubuntu-20.04-cpp-minimal-with-formats|[](https://github.com/ursacomputing/crossbow/actions/runs/10388720859/job/28764996114)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/10388720551/job/28764994708)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/10388720792/job/28764996101)|
|test-ubuntu-22.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/10388720940/job/28764996991)|
|test-ubuntu-22.04-cpp-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/10388720694/job/28764995095)|
|test-ubuntu-22.04-cpp-no-threading|[](https://github.com/ursacomputing/crossbow/actions/runs/10388720904/job/28764996694)|
|test-ubuntu-24.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/10388720910/job/28764997056)|
|test-ubuntu-24.04-cpp-gcc-13-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/10388720604/job/28764994776)|
|test-ubuntu-24.04-cpp-gcc-14|[](https://github.com/ursacomputing/crossbow/actions/runs/10388720623/job/28764994736)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43688: [C++] Prevent Snappy from disabling RTTI when bundled [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #43689:
URL: https://github.com/apache/arrow/pull/43689#issuecomment-2288779769
@github-actions crossbow submit -g python
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43688: [C++] Prevent Snappy from disabling RTTI when bundled [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #43689:
URL: https://github.com/apache/arrow/pull/43689#discussion_r1718169050
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -1353,26 +1353,9 @@ macro(build_snappy)
set(SNAPPY_CMAKE_ARGS
${EP_COMMON_CMAKE_ARGS} -DSNAPPY_BUILD_TESTS=OFF -DSNAPPY_BUILD_BENCHMARKS=OFF
"-DCMAKE_INSTALL_PREFIX=${SNAPPY_PREFIX}")
- # Snappy unconditionally enables -Werror when building with clang this can lead
- # to build failures by way of new compiler warnings. This adds a flag to disable
- # Werror to the very end of the invocation to override the snappy internal setting.
- if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
- foreach(CONFIG DEBUG MINSIZEREL RELEASE RELWITHDEBINFO)
- list(APPEND
- SNAPPY_CMAKE_ARGS
- "-DCMAKE_CXX_FLAGS_${UPPERCASE_BUILD_TYPE}=${EP_CXX_FLAGS_${CONFIG}} -Wno-error"
- )
- endforeach()
- endif()
-
- if(APPLE AND CMAKE_HOST_SYSTEM_VERSION VERSION_LESS 20)
- # On macOS 10.13 we need to explicitly add <functional> to avoid a missing include error
- # This can be removed once CRAN no longer checks on macOS 10.13
- find_program(PATCH patch REQUIRED)
- set(SNAPPY_PATCH_COMMAND ${PATCH} -p1 -i ${CMAKE_CURRENT_LIST_DIR}/snappy.diff)
- else()
- set(SNAPPY_PATCH_COMMAND)
- endif()
+ # See comments in snappy.diff.
+ find_program(PATCH patch REQUIRED)
+ set(SNAPPY_PATCH_COMMAND ${PATCH} -p1 -i ${CMAKE_CURRENT_LIST_DIR}/snappy.diff)
Review Comment:
I agree with this, but as you know Snappy rarely takes outside contributions...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43688: [C++] Prevent Snappy from disabling RTTI when bundled [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #43689:
URL: https://github.com/apache/arrow/pull/43689#issuecomment-2293240872
Closing as outdated, see the alternative and merged PR #43706
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43688: [C++] Prevent Snappy from disabling RTTI when bundled [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #43689:
URL: https://github.com/apache/arrow/pull/43689#issuecomment-2288941463
@github-actions crossbow submit *emscripten*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43688: [C++] Prevent Snappy from disabling RTTI when bundled [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43689:
URL: https://github.com/apache/arrow/pull/43689#issuecomment-2288767702
:warning: GitHub issue #43688 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43688: [C++] Prevent Snappy from disabling RTTI when bundled [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #43689:
URL: https://github.com/apache/arrow/pull/43689#discussion_r1717027028
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -1353,26 +1353,9 @@ macro(build_snappy)
set(SNAPPY_CMAKE_ARGS
${EP_COMMON_CMAKE_ARGS} -DSNAPPY_BUILD_TESTS=OFF -DSNAPPY_BUILD_BENCHMARKS=OFF
"-DCMAKE_INSTALL_PREFIX=${SNAPPY_PREFIX}")
- # Snappy unconditionally enables -Werror when building with clang this can lead
- # to build failures by way of new compiler warnings. This adds a flag to disable
- # Werror to the very end of the invocation to override the snappy internal setting.
- if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
- foreach(CONFIG DEBUG MINSIZEREL RELEASE RELWITHDEBINFO)
- list(APPEND
- SNAPPY_CMAKE_ARGS
- "-DCMAKE_CXX_FLAGS_${UPPERCASE_BUILD_TYPE}=${EP_CXX_FLAGS_${CONFIG}} -Wno-error"
- )
- endforeach()
- endif()
-
- if(APPLE AND CMAKE_HOST_SYSTEM_VERSION VERSION_LESS 20)
- # On macOS 10.13 we need to explicitly add <functional> to avoid a missing include error
- # This can be removed once CRAN no longer checks on macOS 10.13
- find_program(PATCH patch REQUIRED)
- set(SNAPPY_PATCH_COMMAND ${PATCH} -p1 -i ${CMAKE_CURRENT_LIST_DIR}/snappy.diff)
- else()
- set(SNAPPY_PATCH_COMMAND)
- endif()
+ # See comments in snappy.diff.
+ find_program(PATCH patch REQUIRED)
+ set(SNAPPY_PATCH_COMMAND ${PATCH} -p1 -i ${CMAKE_CURRENT_LIST_DIR}/snappy.diff)
Review Comment:
And even some Linux builds such as `test-r-rocker-r-ver-latest` don't seem to have `patch` either. I'll try to make it optional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43688: [C++] Prevent Snappy from disabling RTTI when bundled [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #43689:
URL: https://github.com/apache/arrow/pull/43689#issuecomment-2288779429
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43688: [C++] Prevent Snappy from disabling RTTI when bundled [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #43689:
URL: https://github.com/apache/arrow/pull/43689#issuecomment-2289040694
@github-actions crossbow submit -g r
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43688: [C++] Prevent Snappy from disabling RTTI when bundled [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43689:
URL: https://github.com/apache/arrow/pull/43689#issuecomment-2289108617
Revision: ae1e24b6349f9821982095729e76e892a3c8159e
Submitted crossbow builds: [ursacomputing/crossbow @ actions-9f77ba6cb3](https://github.com/ursacomputing/crossbow/branches/all?query=actions-9f77ba6cb3)
|Task|Status|
|----|------|
|test-conda-python-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/10390437992/job/28770897587)|
|test-ubuntu-22.04-cpp-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/10390437993/job/28770897633)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43688: [C++] Prevent Snappy from disabling RTTI when bundled [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43689:
URL: https://github.com/apache/arrow/pull/43689#issuecomment-2289299625
Revision: 19228c5d00910561fac5af463572d56c38654897
Submitted crossbow builds: [ursacomputing/crossbow @ actions-df81c467d5](https://github.com/ursacomputing/crossbow/branches/all?query=actions-df81c467d5)
|Task|Status|
|----|------|
|example-python-minimal-build-fedora-conda|[](https://github.com/ursacomputing/crossbow/actions/runs/10391631532/job/28774977655)|
|example-python-minimal-build-ubuntu-venv|[](https://github.com/ursacomputing/crossbow/actions/runs/10391628512/job/28774968503)|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/10391629389/job/28774973822)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/10391629043/job/28774971479)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/10391631674/job/28774978364)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/10391629159/job/28774972207)|
|test-conda-python-3.10|[](https://github.com/ursacomputing/crossbow/actions/runs/10391628533/job/28774968534)|
|test-conda-python-3.10-cython2|[](https://github.com/ursacomputing/crossbow/actions/runs/10391628782/job/28774970219)|
|test-conda-python-3.10-hdfs-2.9.2|[](https://github.com/ursacomputing/crossbow/actions/runs/10391629095/job/28774971634)|
|test-conda-python-3.10-hdfs-3.2.1|[](https://github.com/ursacomputing/crossbow/actions/runs/10391628713/job/28774969341)|
|test-conda-python-3.10-pandas-latest-numpy-1.26|[](https://github.com/ursacomputing/crossbow/actions/runs/10391631450/job/28774977257)|
|test-conda-python-3.10-pandas-latest-numpy-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/10391629070/job/28774971522)|
|test-conda-python-3.10-pandas-nightly-numpy-nightly|[](https://github.com/ursacomputing/crossbow/actions/runs/10391628504/job/28774968161)|
|test-conda-python-3.10-substrait|[](https://github.com/ursacomputing/crossbow/actions/runs/10391628741/job/28774969297)|
|test-conda-python-3.11|[](https://github.com/ursacomputing/crossbow/actions/runs/10391628747/job/28774969560)|
|test-conda-python-3.11-dask-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/10391629034/job/28774971180)|
|test-conda-python-3.11-dask-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/10391628585/job/28774968841)|
|test-conda-python-3.11-hypothesis|[](https://github.com/ursacomputing/crossbow/actions/runs/10391628486/job/28774968125)|
|test-conda-python-3.11-pandas-upstream_devel-numpy-nightly|[](https://github.com/ursacomputing/crossbow/actions/runs/10391629021/job/28774971309)|
|test-conda-python-3.11-spark-master|[](https://github.com/ursacomputing/crossbow/actions/runs/10391628492/job/28774968131)|
|test-conda-python-3.12|[](https://github.com/ursacomputing/crossbow/actions/runs/10391628669/job/28774968834)|
|test-conda-python-3.12-cpython-debug|[](https://github.com/ursacomputing/crossbow/actions/runs/10391628790/job/28774969997)|
|test-conda-python-3.8|[](https://github.com/ursacomputing/crossbow/actions/runs/10391628720/job/28774969276)|
|test-conda-python-3.8-pandas-1.0-numpy-1.19|[](https://github.com/ursacomputing/crossbow/actions/runs/10391628563/job/28774968802)|
|test-conda-python-3.9|[](https://github.com/ursacomputing/crossbow/actions/runs/10391628831/job/28774970304)|
|test-conda-python-3.9-pandas-latest-numpy-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/10391628817/job/28774970080)|
|test-conda-python-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/10391629260/job/28774972841)|
|test-cuda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/10391628516/job/28774968160)|
|test-cuda-python|[](https://github.com/ursacomputing/crossbow/actions/runs/10391628990/job/28774971149)|
|test-debian-12-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10391628869/job/28774970472)|
|test-debian-12-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/10391628856/job/28774970443)|
|test-debian-12-python-3-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10391629011/job/28774971175)|
|test-debian-12-python-3-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/10391628725/job/28774969595)|
|test-fedora-39-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/10391628739/job/28774969465)|
|test-fedora-39-python-3|[](https://github.com/ursacomputing/crossbow/actions/runs/10391629203/job/28774972514)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/10391629120/job/28774971682)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/10391628861/job/28774970659)|
|test-ubuntu-20.04-cpp-minimal-with-formats|[](https://github.com/ursacomputing/crossbow/actions/runs/10391628907/job/28774970876)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/10391629199/job/28774972522)|
|test-ubuntu-20.04-python-3|[](https://github.com/ursacomputing/crossbow/actions/runs/10391629296/job/28774972896)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/10391629103/job/28774971939)|
|test-ubuntu-22.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/10391629051/job/28774971395)|
|test-ubuntu-22.04-cpp-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/10391629128/job/28774971842)|
|test-ubuntu-22.04-cpp-no-threading|[](https://github.com/ursacomputing/crossbow/actions/runs/10391631343/job/28774976714)|
|test-ubuntu-22.04-python-3|[](https://github.com/ursacomputing/crossbow/actions/runs/10391628734/job/28774969512)|
|test-ubuntu-24.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/10391628864/job/28774970439)|
|test-ubuntu-24.04-cpp-gcc-13-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/10391629141/job/28774971819)|
|test-ubuntu-24.04-cpp-gcc-14|[](https://github.com/ursacomputing/crossbow/actions/runs/10391628731/job/28774969312)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43688: [C++] Prevent Snappy from disabling RTTI when bundled [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43689:
URL: https://github.com/apache/arrow/pull/43689#issuecomment-2288791339
Revision: fe31f589484071f4da8360b54ae833ed54538fcf
Submitted crossbow builds: [ursacomputing/crossbow @ actions-421f7e343a](https://github.com/ursacomputing/crossbow/branches/all?query=actions-421f7e343a)
|Task|Status|
|----|------|
|example-python-minimal-build-fedora-conda|[](https://github.com/ursacomputing/crossbow/actions/runs/10388724429/job/28765009712)|
|example-python-minimal-build-ubuntu-venv|[](https://github.com/ursacomputing/crossbow/actions/runs/10388724433/job/28765009496)|
|test-conda-python-3.10|[](https://github.com/ursacomputing/crossbow/actions/runs/10388724395/job/28765008828)|
|test-conda-python-3.10-cython2|[](https://github.com/ursacomputing/crossbow/actions/runs/10388724258/job/28765008390)|
|test-conda-python-3.10-hdfs-2.9.2|[](https://github.com/ursacomputing/crossbow/actions/runs/10388724397/job/28765009103)|
|test-conda-python-3.10-hdfs-3.2.1|[](https://github.com/ursacomputing/crossbow/actions/runs/10388724282/job/28765008268)|
|test-conda-python-3.10-pandas-latest-numpy-1.26|[](https://github.com/ursacomputing/crossbow/actions/runs/10388724386/job/28765008765)|
|test-conda-python-3.10-pandas-latest-numpy-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/10388724384/job/28765009092)|
|test-conda-python-3.10-pandas-nightly-numpy-nightly|[](https://github.com/ursacomputing/crossbow/actions/runs/10388724434/job/28765009416)|
|test-conda-python-3.10-substrait|[](https://github.com/ursacomputing/crossbow/actions/runs/10388724422/job/28765009381)|
|test-conda-python-3.11|[](https://github.com/ursacomputing/crossbow/actions/runs/10388724514/job/28765010292)|
|test-conda-python-3.11-dask-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/10388724316/job/28765008420)|
|test-conda-python-3.11-dask-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/10388724439/job/28765009830)|
|test-conda-python-3.11-hypothesis|[](https://github.com/ursacomputing/crossbow/actions/runs/10388724024/job/28765006962)|
|test-conda-python-3.11-pandas-upstream_devel-numpy-nightly|[](https://github.com/ursacomputing/crossbow/actions/runs/10388724670/job/28765010967)|
|test-conda-python-3.11-spark-master|[](https://github.com/ursacomputing/crossbow/actions/runs/10388724106/job/28765007340)|
|test-conda-python-3.12|[](https://github.com/ursacomputing/crossbow/actions/runs/10388724175/job/28765007822)|
|test-conda-python-3.12-cpython-debug|[](https://github.com/ursacomputing/crossbow/actions/runs/10388724121/job/28765007425)|
|test-conda-python-3.8|[](https://github.com/ursacomputing/crossbow/actions/runs/10388724119/job/28765007348)|
|test-conda-python-3.8-pandas-1.0-numpy-1.19|[](https://github.com/ursacomputing/crossbow/actions/runs/10388724380/job/28765008551)|
|test-conda-python-3.9|[](https://github.com/ursacomputing/crossbow/actions/runs/10388724234/job/28765008119)|
|test-conda-python-3.9-pandas-latest-numpy-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/10388724029/job/28765007034)|
|test-conda-python-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/10388724560/job/28765010678)|
|test-cuda-python|[](https://github.com/ursacomputing/crossbow/actions/runs/10388724720/job/28765011154)|
|test-debian-12-python-3-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10388724474/job/28765010018)|
|test-debian-12-python-3-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/10388724526/job/28765010298)|
|test-fedora-39-python-3|[](https://github.com/ursacomputing/crossbow/actions/runs/10388724566/job/28765010727)|
|test-ubuntu-20.04-python-3|[](https://github.com/ursacomputing/crossbow/actions/runs/10388724655/job/28765011142)|
|test-ubuntu-22.04-python-3|[](https://github.com/ursacomputing/crossbow/actions/runs/10388724548/job/28765010538)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43688: [C++] Prevent Snappy from disabling RTTI when bundled [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #43689:
URL: https://github.com/apache/arrow/pull/43689#discussion_r1717063836
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -1353,26 +1353,9 @@ macro(build_snappy)
set(SNAPPY_CMAKE_ARGS
${EP_COMMON_CMAKE_ARGS} -DSNAPPY_BUILD_TESTS=OFF -DSNAPPY_BUILD_BENCHMARKS=OFF
"-DCMAKE_INSTALL_PREFIX=${SNAPPY_PREFIX}")
- # Snappy unconditionally enables -Werror when building with clang this can lead
- # to build failures by way of new compiler warnings. This adds a flag to disable
- # Werror to the very end of the invocation to override the snappy internal setting.
- if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
- foreach(CONFIG DEBUG MINSIZEREL RELEASE RELWITHDEBINFO)
- list(APPEND
- SNAPPY_CMAKE_ARGS
- "-DCMAKE_CXX_FLAGS_${UPPERCASE_BUILD_TYPE}=${EP_CXX_FLAGS_${CONFIG}} -Wno-error"
- )
- endforeach()
- endif()
-
- if(APPLE AND CMAKE_HOST_SYSTEM_VERSION VERSION_LESS 20)
- # On macOS 10.13 we need to explicitly add <functional> to avoid a missing include error
- # This can be removed once CRAN no longer checks on macOS 10.13
- find_program(PATCH patch REQUIRED)
- set(SNAPPY_PATCH_COMMAND ${PATCH} -p1 -i ${CMAKE_CURRENT_LIST_DIR}/snappy.diff)
- else()
- set(SNAPPY_PATCH_COMMAND)
- endif()
+ # See comments in snappy.diff.
+ find_program(PATCH patch REQUIRED)
+ set(SNAPPY_PATCH_COMMAND ${PATCH} -p1 -i ${CMAKE_CURRENT_LIST_DIR}/snappy.diff)
Review Comment:
Ok, unfortunately the patch is required. We either have to make sure that `patch` is available on all images, or do things differently :-/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43688: [C++] Prevent Snappy from disabling RTTI when bundled [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #43689:
URL: https://github.com/apache/arrow/pull/43689#issuecomment-2289103913
@github-actions crossbow submit *emscripten*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43688: [C++] Prevent Snappy from disabling RTTI when bundled [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #43689:
URL: https://github.com/apache/arrow/pull/43689#issuecomment-2289040445
@github-actions crossbow submit *emscripten*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43688: [C++] Prevent Snappy from disabling RTTI when bundled [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43689:
URL: https://github.com/apache/arrow/pull/43689#issuecomment-2289051983
Revision: 58adcdb1c0c6130be056d5250c9f83ab5d3efca1
Submitted crossbow builds: [ursacomputing/crossbow @ actions-62889c8077](https://github.com/ursacomputing/crossbow/branches/all?query=actions-62889c8077)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/10389967910/job/28769329999)|
|test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions/runs/10389967829/job/28769299174)|
|test-r-clang-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/10389968409/job/28769302039)|
|test-r-depsource-bundled|[](https://github.com/ursacomputing/crossbow/runs/28769303888)|
|test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions/runs/10389967874/job/28769299205)|
|test-r-dev-duckdb|[](https://github.com/ursacomputing/crossbow/actions/runs/10389968402/job/28769301962)|
|test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions/runs/10389968217/job/28769301432)|
|test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions/runs/10389968239/job/28769300728)|
|test-r-gcc-12|[](https://github.com/ursacomputing/crossbow/actions/runs/10389968027/job/28769299730)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions/runs/10389968316/job/28769302385)|
|test-r-install-local-minsizerel|[](https://github.com/ursacomputing/crossbow/actions/runs/10389968076/job/28769300404)|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/10389968249/job/28769302710)|
|test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions/runs/10389968265/job/28769301100)|
|test-r-linux-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/10389968257/job/28769300890)|
|test-r-minimal-build|[](https://github.com/ursacomputing/crossbow/runs/28769303178)|
|test-r-offline-maximal|[](https://github.com/ursacomputing/crossbow/actions/runs/10389967979/job/28769299614)|
|test-r-offline-minimal|[](https://github.com/ursacomputing/crossbow/runs/28769303243)|
|test-r-rhub-debian-gcc-devel-lto-latest|[](https://github.com/ursacomputing/crossbow/runs/28769302617)|
|test-r-rhub-debian-gcc-release-custom-ccache|[](https://github.com/ursacomputing/crossbow/runs/28769303947)|
|test-r-rhub-ubuntu-release-latest|[](https://github.com/ursacomputing/crossbow/runs/28769303201)|
|test-r-rocker-r-ver-latest|[](https://github.com/ursacomputing/crossbow/runs/28769303375)|
|test-r-rstudio-r-base-4.1-opensuse155|[](https://github.com/ursacomputing/crossbow/tree/actions-62889c8077-azure-test-r-rstudio-r-base-4.1-opensuse155)|
|test-r-rstudio-r-base-4.2-focal|[](https://github.com/ursacomputing/crossbow/tree/actions-62889c8077-azure-test-r-rstudio-r-base-4.2-focal)|
|test-r-ubuntu-22.04|[](https://github.com/ursacomputing/crossbow/actions/runs/10389968418/job/28769302064)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions/runs/10389968208/job/28769301812)|
|test-ubuntu-r-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/10389968037/job/28769299912)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43688: [C++] Prevent Snappy from disabling RTTI when bundled [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #43689:
URL: https://github.com/apache/arrow/pull/43689#discussion_r1718134258
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -1353,26 +1353,9 @@ macro(build_snappy)
set(SNAPPY_CMAKE_ARGS
${EP_COMMON_CMAKE_ARGS} -DSNAPPY_BUILD_TESTS=OFF -DSNAPPY_BUILD_BENCHMARKS=OFF
"-DCMAKE_INSTALL_PREFIX=${SNAPPY_PREFIX}")
- # Snappy unconditionally enables -Werror when building with clang this can lead
- # to build failures by way of new compiler warnings. This adds a flag to disable
- # Werror to the very end of the invocation to override the snappy internal setting.
- if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
- foreach(CONFIG DEBUG MINSIZEREL RELEASE RELWITHDEBINFO)
- list(APPEND
- SNAPPY_CMAKE_ARGS
- "-DCMAKE_CXX_FLAGS_${UPPERCASE_BUILD_TYPE}=${EP_CXX_FLAGS_${CONFIG}} -Wno-error"
- )
- endforeach()
- endif()
-
- if(APPLE AND CMAKE_HOST_SYSTEM_VERSION VERSION_LESS 20)
- # On macOS 10.13 we need to explicitly add <functional> to avoid a missing include error
- # This can be removed once CRAN no longer checks on macOS 10.13
- find_program(PATCH patch REQUIRED)
- set(SNAPPY_PATCH_COMMAND ${PATCH} -p1 -i ${CMAKE_CURRENT_LIST_DIR}/snappy.diff)
- else()
- set(SNAPPY_PATCH_COMMAND)
- endif()
+ # See comments in snappy.diff.
+ find_program(PATCH patch REQUIRED)
+ set(SNAPPY_PATCH_COMMAND ${PATCH} -p1 -i ${CMAKE_CURRENT_LIST_DIR}/snappy.diff)
Review Comment:
OTOH, `patch` is useful and could be needed for other bundled builds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43688: [C++] Prevent Snappy from disabling RTTI when bundled [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou closed pull request #43689: GH-43688: [C++] Prevent Snappy from disabling RTTI when bundled
URL: https://github.com/apache/arrow/pull/43689
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43688: [C++] Prevent Snappy from disabling RTTI when bundled [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #43689:
URL: https://github.com/apache/arrow/pull/43689#issuecomment-2288832718
@github-actions crossbow submit -g r
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43688: [C++] Prevent Snappy from disabling RTTI when bundled [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #43689:
URL: https://github.com/apache/arrow/pull/43689#issuecomment-2288947113
@github-actions crossbow submit test-r-rocker-r-ver-latest test-r-rstudio-r-base-4.2-focal test-r-versions r-binary-packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43688: [C++] Prevent Snappy from disabling RTTI when bundled [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #43689:
URL: https://github.com/apache/arrow/pull/43689#discussion_r1716945455
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -1353,26 +1353,9 @@ macro(build_snappy)
set(SNAPPY_CMAKE_ARGS
${EP_COMMON_CMAKE_ARGS} -DSNAPPY_BUILD_TESTS=OFF -DSNAPPY_BUILD_BENCHMARKS=OFF
"-DCMAKE_INSTALL_PREFIX=${SNAPPY_PREFIX}")
- # Snappy unconditionally enables -Werror when building with clang this can lead
- # to build failures by way of new compiler warnings. This adds a flag to disable
- # Werror to the very end of the invocation to override the snappy internal setting.
- if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
- foreach(CONFIG DEBUG MINSIZEREL RELEASE RELWITHDEBINFO)
- list(APPEND
- SNAPPY_CMAKE_ARGS
- "-DCMAKE_CXX_FLAGS_${UPPERCASE_BUILD_TYPE}=${EP_CXX_FLAGS_${CONFIG}} -Wno-error"
- )
- endforeach()
- endif()
-
- if(APPLE AND CMAKE_HOST_SYSTEM_VERSION VERSION_LESS 20)
- # On macOS 10.13 we need to explicitly add <functional> to avoid a missing include error
- # This can be removed once CRAN no longer checks on macOS 10.13
- find_program(PATCH patch REQUIRED)
- set(SNAPPY_PATCH_COMMAND ${PATCH} -p1 -i ${CMAKE_CURRENT_LIST_DIR}/snappy.diff)
- else()
- set(SNAPPY_PATCH_COMMAND)
- endif()
+ # See comments in snappy.diff.
+ find_program(PATCH patch REQUIRED)
+ set(SNAPPY_PATCH_COMMAND ${PATCH} -p1 -i ${CMAKE_CURRENT_LIST_DIR}/snappy.diff)
Review Comment:
@kou Do we require `patch` to be present on all platforms, especially Windows? Or should I make this more specific?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43688: [C++] Prevent Snappy from disabling RTTI when bundled [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43689:
URL: https://github.com/apache/arrow/pull/43689#issuecomment-2289183686
Revision: e545bc348f2cb0da1abfef6be8b20ad8475394ab
Submitted crossbow builds: [ursacomputing/crossbow @ actions-74e3a4cd44](https://github.com/ursacomputing/crossbow/branches/all?query=actions-74e3a4cd44)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/10390908195/job/28772523662)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43688: [C++] Prevent Snappy from disabling RTTI when bundled [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #43689:
URL: https://github.com/apache/arrow/pull/43689#issuecomment-2289174754
@github-actions crossbow submit r-binary-packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43688: [C++] Prevent Snappy from disabling RTTI when bundled [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #43689:
URL: https://github.com/apache/arrow/pull/43689#discussion_r1718147611
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -1353,26 +1353,9 @@ macro(build_snappy)
set(SNAPPY_CMAKE_ARGS
${EP_COMMON_CMAKE_ARGS} -DSNAPPY_BUILD_TESTS=OFF -DSNAPPY_BUILD_BENCHMARKS=OFF
"-DCMAKE_INSTALL_PREFIX=${SNAPPY_PREFIX}")
- # Snappy unconditionally enables -Werror when building with clang this can lead
- # to build failures by way of new compiler warnings. This adds a flag to disable
- # Werror to the very end of the invocation to override the snappy internal setting.
- if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
- foreach(CONFIG DEBUG MINSIZEREL RELEASE RELWITHDEBINFO)
- list(APPEND
- SNAPPY_CMAKE_ARGS
- "-DCMAKE_CXX_FLAGS_${UPPERCASE_BUILD_TYPE}=${EP_CXX_FLAGS_${CONFIG}} -Wno-error"
- )
- endforeach()
- endif()
-
- if(APPLE AND CMAKE_HOST_SYSTEM_VERSION VERSION_LESS 20)
- # On macOS 10.13 we need to explicitly add <functional> to avoid a missing include error
- # This can be removed once CRAN no longer checks on macOS 10.13
- find_program(PATCH patch REQUIRED)
- set(SNAPPY_PATCH_COMMAND ${PATCH} -p1 -i ${CMAKE_CURRENT_LIST_DIR}/snappy.diff)
- else()
- set(SNAPPY_PATCH_COMMAND)
- endif()
+ # See comments in snappy.diff.
+ find_program(PATCH patch REQUIRED)
+ set(SNAPPY_PATCH_COMMAND ${PATCH} -p1 -i ${CMAKE_CURRENT_LIST_DIR}/snappy.diff)
Review Comment:
I think that we should fix in upstream instead of using patch as much as possible :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43688: [C++] Prevent Snappy from disabling RTTI when bundled [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43689:
URL: https://github.com/apache/arrow/pull/43689#issuecomment-2288844674
Revision: fe31f589484071f4da8360b54ae833ed54538fcf
Submitted crossbow builds: [ursacomputing/crossbow @ actions-f9b144a207](https://github.com/ursacomputing/crossbow/branches/all?query=actions-f9b144a207)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/10389012103/job/28766047157)|
|test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions/runs/10389011917/job/28766023846)|
|test-r-clang-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/10389011711/job/28766021756)|
|test-r-depsource-bundled|[](https://github.com/ursacomputing/crossbow/tree/actions-f9b144a207-azure-test-r-depsource-bundled)|
|test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions/runs/10389011723/job/28766022262)|
|test-r-dev-duckdb|[](https://github.com/ursacomputing/crossbow/actions/runs/10389011996/job/28766024100)|
|test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions/runs/10389011789/job/28766023835)|
|test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions/runs/10389012090/job/28766024693)|
|test-r-gcc-12|[](https://github.com/ursacomputing/crossbow/actions/runs/10389011838/job/28766023419)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions/runs/10389011681/job/28766022545)|
|test-r-install-local-minsizerel|[](https://github.com/ursacomputing/crossbow/actions/runs/10389012043/job/28766025173)|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/10389011657/job/28766024074)|
|test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions/runs/10389012019/job/28766024259)|
|test-r-linux-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/10389011680/job/28766021757)|
|test-r-minimal-build|[](https://github.com/ursacomputing/crossbow/runs/28766026319)|
|test-r-offline-maximal|[](https://github.com/ursacomputing/crossbow/actions/runs/10389011897/job/28766023490)|
|test-r-offline-minimal|[](https://github.com/ursacomputing/crossbow/runs/28766026813)|
|test-r-rhub-debian-gcc-devel-lto-latest|[](https://github.com/ursacomputing/crossbow/runs/28766026979)|
|test-r-rhub-debian-gcc-release-custom-ccache|[](https://github.com/ursacomputing/crossbow/runs/28766024936)|
|test-r-rhub-ubuntu-release-latest|[](https://github.com/ursacomputing/crossbow/runs/28766026239)|
|test-r-rocker-r-ver-latest|[](https://github.com/ursacomputing/crossbow/runs/28766027549)|
|test-r-rstudio-r-base-4.1-opensuse155|[](https://github.com/ursacomputing/crossbow/runs/28766025590)|
|test-r-rstudio-r-base-4.2-focal|[](https://github.com/ursacomputing/crossbow/runs/28766025605)|
|test-r-ubuntu-22.04|[](https://github.com/ursacomputing/crossbow/actions/runs/10389011869/job/28766023461)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions/runs/10389011793/job/28766024374)|
|test-ubuntu-r-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/10389011703/job/28766021826)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43688: [C++] Prevent Snappy from disabling RTTI when bundled [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43689:
URL: https://github.com/apache/arrow/pull/43689#issuecomment-2288949443
Revision: 80331aa1edd692b2d5e544df524a0ab41fcd5537
Submitted crossbow builds: [ursacomputing/crossbow @ actions-ce8ce2f181](https://github.com/ursacomputing/crossbow/branches/all?query=actions-ce8ce2f181)
|Task|Status|
|----|------|
|test-conda-python-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/10389564742/job/28767867908)|
|test-ubuntu-22.04-cpp-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/10389564676/job/28767867917)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43688: [C++] Prevent Snappy from disabling RTTI when bundled [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #43689:
URL: https://github.com/apache/arrow/pull/43689#discussion_r1716969953
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -1353,26 +1353,9 @@ macro(build_snappy)
set(SNAPPY_CMAKE_ARGS
${EP_COMMON_CMAKE_ARGS} -DSNAPPY_BUILD_TESTS=OFF -DSNAPPY_BUILD_BENCHMARKS=OFF
"-DCMAKE_INSTALL_PREFIX=${SNAPPY_PREFIX}")
- # Snappy unconditionally enables -Werror when building with clang this can lead
- # to build failures by way of new compiler warnings. This adds a flag to disable
- # Werror to the very end of the invocation to override the snappy internal setting.
- if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
- foreach(CONFIG DEBUG MINSIZEREL RELEASE RELWITHDEBINFO)
- list(APPEND
- SNAPPY_CMAKE_ARGS
- "-DCMAKE_CXX_FLAGS_${UPPERCASE_BUILD_TYPE}=${EP_CXX_FLAGS_${CONFIG}} -Wno-error"
- )
- endforeach()
- endif()
-
- if(APPLE AND CMAKE_HOST_SYSTEM_VERSION VERSION_LESS 20)
- # On macOS 10.13 we need to explicitly add <functional> to avoid a missing include error
- # This can be removed once CRAN no longer checks on macOS 10.13
- find_program(PATCH patch REQUIRED)
- set(SNAPPY_PATCH_COMMAND ${PATCH} -p1 -i ${CMAKE_CURRENT_LIST_DIR}/snappy.diff)
- else()
- set(SNAPPY_PATCH_COMMAND)
- endif()
+ # See comments in snappy.diff.
+ find_program(PATCH patch REQUIRED)
+ set(SNAPPY_PATCH_COMMAND ${PATCH} -p1 -i ${CMAKE_CURRENT_LIST_DIR}/snappy.diff)
Review Comment:
Well, to answer myself: our emscripten builds don't have access to a `patch` executable...
https://github.com/ursacomputing/crossbow/actions/runs/10388720694/job/28764995095#step:7:826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43688: [C++] Prevent Snappy from disabling RTTI when bundled [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43689:
URL: https://github.com/apache/arrow/pull/43689#issuecomment-2288955224
Revision: 80331aa1edd692b2d5e544df524a0ab41fcd5537
Submitted crossbow builds: [ursacomputing/crossbow @ actions-d6bcaea23c](https://github.com/ursacomputing/crossbow/branches/all?query=actions-d6bcaea23c)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/10389593557/job/28767996404)|
|test-r-rocker-r-ver-latest|[](https://github.com/ursacomputing/crossbow/runs/28767970076)|
|test-r-rstudio-r-base-4.2-focal|[](https://github.com/ursacomputing/crossbow/runs/28767970850)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions/runs/10389593560/job/28767968562)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43688: [C++] Prevent Snappy from disabling RTTI when bundled [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #43689:
URL: https://github.com/apache/arrow/pull/43689#issuecomment-2289294252
@github-actions crossbow submit -g python -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43688: [C++] Prevent Snappy from disabling RTTI when bundled [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #43689:
URL: https://github.com/apache/arrow/pull/43689#discussion_r1717557127
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -1353,26 +1353,9 @@ macro(build_snappy)
set(SNAPPY_CMAKE_ARGS
${EP_COMMON_CMAKE_ARGS} -DSNAPPY_BUILD_TESTS=OFF -DSNAPPY_BUILD_BENCHMARKS=OFF
"-DCMAKE_INSTALL_PREFIX=${SNAPPY_PREFIX}")
- # Snappy unconditionally enables -Werror when building with clang this can lead
- # to build failures by way of new compiler warnings. This adds a flag to disable
- # Werror to the very end of the invocation to override the snappy internal setting.
- if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
- foreach(CONFIG DEBUG MINSIZEREL RELEASE RELWITHDEBINFO)
- list(APPEND
- SNAPPY_CMAKE_ARGS
- "-DCMAKE_CXX_FLAGS_${UPPERCASE_BUILD_TYPE}=${EP_CXX_FLAGS_${CONFIG}} -Wno-error"
- )
- endforeach()
- endif()
-
- if(APPLE AND CMAKE_HOST_SYSTEM_VERSION VERSION_LESS 20)
- # On macOS 10.13 we need to explicitly add <functional> to avoid a missing include error
- # This can be removed once CRAN no longer checks on macOS 10.13
- find_program(PATCH patch REQUIRED)
- set(SNAPPY_PATCH_COMMAND ${PATCH} -p1 -i ${CMAKE_CURRENT_LIST_DIR}/snappy.diff)
- else()
- set(SNAPPY_PATCH_COMMAND)
- endif()
+ # See comments in snappy.diff.
+ find_program(PATCH patch REQUIRED)
+ set(SNAPPY_PATCH_COMMAND ${PATCH} -p1 -i ${CMAKE_CURRENT_LIST_DIR}/snappy.diff)
Review Comment:
Yes. `patch` is required as you noticed.
I think that another approach is better. See also: https://github.com/apache/arrow/issues/43688#issuecomment-2289907756
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org