You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Hitesh Khamesra <hk...@pivotal.io> on 2016/02/19 23:47:00 UTC
Review Request 43788: Now we do send heartbeat request while doing
tcp check
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43788/
-----------------------------------------------------------
Review request for geode, Bruce Schuchardt, Jianxia Chen, and Udo Kohlmeyer.
Repository: geode
Description
-------
While doing tcp check, now we do request heartbeat from unresponsive member. This is udp call and we don't wait for response. It is processed by another thread. Current thread continue with tcp check and if it fails, then it look for heartbeat.
Added unit test
Diffs
-----
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java beb781d
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java 9562e41
Diff: https://reviews.apache.org/r/43788/diff/
Testing
-------
testing
Thanks,
Hitesh Khamesra
Re: Review Request 43788: Now we do send heartbeat request while
doing tcp check
Posted by Jianxia Chen <jc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43788/#review119990
-----------------------------------------------------------
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java (line 452)
<https://reviews.apache.org/r/43788/#comment181350>
Better add a {} for this if statement
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java (line 488)
<https://reviews.apache.org/r/43788/#comment181351>
Better add a {} for this if statement
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java (line 682)
<https://reviews.apache.org/r/43788/#comment181355>
return super.doTCPCheckMember(suspectMember, port)?
- Jianxia Chen
On Feb. 19, 2016, 10:47 p.m., Hitesh Khamesra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43788/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2016, 10:47 p.m.)
>
>
> Review request for geode, Bruce Schuchardt, Jianxia Chen, and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> -------
>
> While doing tcp check, now we do request heartbeat from unresponsive member. This is udp call and we don't wait for response. It is processed by another thread. Current thread continue with tcp check and if it fails, then it look for heartbeat.
>
> Added unit test
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java beb781d
> gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java 9562e41
>
> Diff: https://reviews.apache.org/r/43788/diff/
>
>
> Testing
> -------
>
> testing
>
>
> Thanks,
>
> Hitesh Khamesra
>
>
Re: Review Request 43788: Now we do send heartbeat request while
doing tcp check
Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43788/#review120343
-----------------------------------------------------------
Looks good except for one small thing. Run splitBrain.bt
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java (line 1067)
<https://reviews.apache.org/r/43788/#comment181777>
Both the "if" and the "else" now invoke contactedBy(), so I think you can pull it out & invoke it before checking to see if the requestId is >= 0.
- Bruce Schuchardt
On Feb. 23, 2016, 5:41 p.m., Hitesh Khamesra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43788/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2016, 5:41 p.m.)
>
>
> Review request for geode, Bruce Schuchardt, Jianxia Chen, and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> -------
>
> While doing tcp check, now we do request heartbeat from unresponsive member. This is udp call and we don't wait for response. It is processed by another thread. Current thread continue with tcp check and if it fails, then it look for heartbeat.
>
> Added unit test
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java beb781d
> gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java 9562e41
>
> Diff: https://reviews.apache.org/r/43788/diff/
>
>
> Testing
> -------
>
> testing
>
>
> Thanks,
>
> Hitesh Khamesra
>
>
Re: Review Request 43788: Now we do send heartbeat request while
doing tcp check
Posted by Hitesh Khamesra <hk...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43788/
-----------------------------------------------------------
(Updated Feb. 23, 2016, 5:41 p.m.)
Review request for geode, Bruce Schuchardt, Jianxia Chen, and Udo Kohlmeyer.
Repository: geode
Description
-------
While doing tcp check, now we do request heartbeat from unresponsive member. This is udp call and we don't wait for response. It is processed by another thread. Current thread continue with tcp check and if it fails, then it look for heartbeat.
Added unit test
Diffs (updated)
-----
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java beb781d
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java 9562e41
Diff: https://reviews.apache.org/r/43788/diff/
Testing
-------
testing
Thanks,
Hitesh Khamesra