You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Sudharsan Sampath (JIRA)" <ji...@apache.org> on 2011/07/19 08:39:57 UTC
[jira] [Created] (MAPREDUCE-2709) Test case to ensure
ReflectionUtils.setConf configures the target object only once
Test case to ensure ReflectionUtils.setConf configures the target object only once
----------------------------------------------------------------------------------
Key: MAPREDUCE-2709
URL: https://issues.apache.org/jira/browse/MAPREDUCE-2709
Project: Hadoop Map/Reduce
Issue Type: Test
Components: test
Reporter: Sudharsan Sampath
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2709) Test case to ensure
ReflectionUtils.setConf configures the target object only once
Posted by "Sudharsan Sampath (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sudharsan Sampath updated MAPREDUCE-2709:
-----------------------------------------
Attachment: MAPREDUCE-2709.patch
test case to make sure ReflectionUtils.setConf does not configure objects twice
> Test case to ensure ReflectionUtils.setConf configures the target object only once
> ----------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2709
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2709
> Project: Hadoop Map/Reduce
> Issue Type: Test
> Components: test
> Reporter: Sudharsan Sampath
> Attachments: MAPREDUCE-2709.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2709) Test case to ensure
ReflectionUtils.setConf configures the target object only once
Posted by "Sudharsan Sampath (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sudharsan Sampath updated MAPREDUCE-2709:
-----------------------------------------
Resolution: Invalid
Status: Resolved (was: Patch Available)
The test case is moved to the common project
> Test case to ensure ReflectionUtils.setConf configures the target object only once
> ----------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2709
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2709
> Project: Hadoop Map/Reduce
> Issue Type: Test
> Components: test
> Reporter: Sudharsan Sampath
> Attachments: MAPREDUCE-2709.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2709) Test case to ensure
ReflectionUtils.setConf configures the target object only once
Posted by "Devaraj K (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067655#comment-13067655 ]
Devaraj K commented on MAPREDUCE-2709:
--------------------------------------
Sudharshan,
As Harsh said TestReflectionUtils.java present in mapreduce project should not be expanded(and will be removed later). It is to test the backward compatibility. You can add the test code in the common project.
> Test case to ensure ReflectionUtils.setConf configures the target object only once
> ----------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2709
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2709
> Project: Hadoop Map/Reduce
> Issue Type: Test
> Components: test
> Reporter: Sudharsan Sampath
> Attachments: MAPREDUCE-2709.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2709) Test case to ensure
ReflectionUtils.setConf configures the target object only once
Posted by "Devaraj K (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067565#comment-13067565 ]
Devaraj K commented on MAPREDUCE-2709:
--------------------------------------
It is better to add this test code as part of the patch HADOOP-7425 in the common itself. It is testing the ReflectionUtils.java, not any mapred functionality.
> Test case to ensure ReflectionUtils.setConf configures the target object only once
> ----------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2709
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2709
> Project: Hadoop Map/Reduce
> Issue Type: Test
> Components: test
> Reporter: Sudharsan Sampath
> Attachments: MAPREDUCE-2709.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2709) Test case to ensure
ReflectionUtils.setConf configures the target object only once
Posted by "Sudharsan Sampath (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068278#comment-13068278 ]
Sudharsan Sampath commented on MAPREDUCE-2709:
----------------------------------------------
Hi,
I dont know how we would write a test to verify this in the common project. This issue is only for the types of JobConfigurable and its present only on the mapred package.
I added a test to the patch in common to just show that the build will fail if we try to test it. Not sure how else will we be able to verify this.
If possible, kindly take a look at the test case with the HADOOP-7425.patch and let me know how should that be modified.
> Test case to ensure ReflectionUtils.setConf configures the target object only once
> ----------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2709
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2709
> Project: Hadoop Map/Reduce
> Issue Type: Test
> Components: test
> Reporter: Sudharsan Sampath
> Attachments: MAPREDUCE-2709.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2709) Test case to ensure
ReflectionUtils.setConf configures the target object only once
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067614#comment-13067614 ]
Harsh J commented on MAPREDUCE-2709:
------------------------------------
Looks like TestReflectionUtils exists in both of the projects. The mapreduce one is just to test backward compatibility with the deprecated API components. This test should not be expanded (it will be removed later), and ideally the test should go to the common project itself. Test should be doable with any dummy class too, I should think.
> Test case to ensure ReflectionUtils.setConf configures the target object only once
> ----------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2709
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2709
> Project: Hadoop Map/Reduce
> Issue Type: Test
> Components: test
> Reporter: Sudharsan Sampath
> Attachments: MAPREDUCE-2709.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2709) Test case to ensure
ReflectionUtils.setConf configures the target object only once
Posted by "Sudharsan Sampath (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sudharsan Sampath updated MAPREDUCE-2709:
-----------------------------------------
Status: Patch Available (was: Open)
> Test case to ensure ReflectionUtils.setConf configures the target object only once
> ----------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2709
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2709
> Project: Hadoop Map/Reduce
> Issue Type: Test
> Components: test
> Reporter: Sudharsan Sampath
> Attachments: MAPREDUCE-2709.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2709) Test case to ensure
ReflectionUtils.setConf configures the target object only once
Posted by "Sudharsan Sampath (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067624#comment-13067624 ]
Sudharsan Sampath commented on MAPREDUCE-2709:
----------------------------------------------
True. But, the api that's fixed will also be removed when we remove the
mapred package in which case this test will become void.
> Test case to ensure ReflectionUtils.setConf configures the target object only once
> ----------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2709
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2709
> Project: Hadoop Map/Reduce
> Issue Type: Test
> Components: test
> Reporter: Sudharsan Sampath
> Attachments: MAPREDUCE-2709.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2709) Test case to ensure
ReflectionUtils.setConf configures the target object only once
Posted by "Sudharsan Sampath (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067570#comment-13067570 ]
Sudharsan Sampath commented on MAPREDUCE-2709:
----------------------------------------------
Hi,
I was under the same thought. But this test class existed in the mapreduce code. Also the original issue was that KeyFieldBasedPartitioner was configured twice. So I thought it will be better to test here if the patch addresses the reported bug also.
If you still think it should be moved, would be happy to do that after making the code generic.
> Test case to ensure ReflectionUtils.setConf configures the target object only once
> ----------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2709
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2709
> Project: Hadoop Map/Reduce
> Issue Type: Test
> Components: test
> Reporter: Sudharsan Sampath
> Attachments: MAPREDUCE-2709.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira