You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by marcuspridham <gi...@git.apache.org> on 2015/05/25 16:02:14 UTC
[GitHub] cordova-plugin-test-framework pull request: CB-9071 Update test fr...
GitHub user marcuspridham opened a pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/13
CB-9071 Update test framework plugin to use Jasmine 2.3.4
Updating Jasmine version from 2.2.0 to 2.3.4.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/marcuspridham/cordova-plugin-test-framework CB-9071
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-test-framework/pull/13.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13
----
commit 910619b065b81fc63d508e591dae4865f16c0237
Author: Marcus Pridham <ma...@sap.com>
Date: 2015-05-15T15:41:03Z
CB-9071 Update test framework plugin to use Jasmine 2.3.4
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-test-framework pull request: CB-9071 Update test fr...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-116774679
@dblotsky Can you take a look at this change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-test-framework pull request #13: CB-9071 Update test framewor...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-test-framework/pull/13
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-test-framework pull request: CB-9071 Update test fr...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-116850705
On it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-test-framework pull request: CB-9071 Update test fr...
Posted by marcuspridham <gi...@git.apache.org>.
Github user marcuspridham commented on the pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-117172177
Just updating the Jasmine files. No custom changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-test-framework pull request: CB-9071 Update test fr...
Posted by marcuspridham <gi...@git.apache.org>.
Github user marcuspridham commented on the pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-117386712
Code does work. I have been running my plugin tests with this change.
For the Cordova mobile spec, I don't have an iOS device on me right now. An iOS 8.3 simulator gives the same result with and without my change (459 spec, 11 failures, 3 pending) this is against Cordova iOS 3.8.0. Failures seem to be with contacts and location which I don't think work with a simulator.
I have signed the Apache iCLA and committed changes to Cordova before.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-test-framework pull request: CB-9071 Update test fr...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-117366652
Also, Marcus have you filed the Apache iCLA? If not please sign, scan and send one to secretary@apache.org: http://www.apache.org/licenses/icla.txt
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-test-framework pull request: CB-9071 Update test fr...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-116949803
I've tested on iOS and it seems to work fine. @marcuspridham, did you make any custom changes, or is it just an update of the files that belong to Jasmine?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-test-framework pull request: CB-9071 Update test fr...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-117282507
Ok, LGTM. Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-test-framework pull request: CB-9071 Update test fr...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-117333658
Due to some bugs with iOS, I'm unable to test this after the rebase on my machine. @marcuspridham have you verified that the code works?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org