You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by pengcheng xiong <px...@hortonworks.com> on 2016/03/13 03:46:45 UTC

Review Request 44756: Support masking and filtering of rows/columns

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44756/
-----------------------------------------------------------

Review request for hive and Ashutosh Chauhan.


Repository: hive-git


Description
-------

HIVE-13125


Diffs
-----

  itests/util/src/main/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidatorForTest.java fd39c67 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 633c212 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TableMask.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationValidator.java 59aabe4 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java c93e334 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java 00fa8cf 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveV1Authorizer.java 8a03989 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/DummyHiveAuthorizationValidator.java 26e3a2c 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java 9f586be 
  ql/src/test/queries/clientpositive/masking_1.q PRE-CREATION 
  ql/src/test/queries/clientpositive/masking_2.q PRE-CREATION 
  ql/src/test/queries/clientpositive/masking_3.q PRE-CREATION 
  ql/src/test/queries/clientpositive/masking_disablecbo_1.q PRE-CREATION 
  ql/src/test/queries/clientpositive/masking_disablecbo_2.q PRE-CREATION 
  ql/src/test/queries/clientpositive/masking_disablecbo_3.q PRE-CREATION 
  ql/src/test/results/clientpositive/masking_1.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/masking_2.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/masking_3.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/masking_disablecbo_1.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/masking_disablecbo_2.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/masking_disablecbo_3.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/44756/diff/


Testing
-------


Thanks,

pengcheng xiong

Re: Review Request 44756: Support masking and filtering of rows/columns

Posted by pengcheng xiong <px...@hortonworks.com>.

> On March 16, 2016, 1:44 a.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/TableMask.java, line 43
> > <https://reviews.apache.org/r/44756/diff/2/?file=1298301#file1298301line43>
> >
> >     We should enable only if new method suggested in interface returns true.

We can do this after interface is stable.


- pengcheng


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44756/#review123813
-----------------------------------------------------------


On March 17, 2016, 6:03 a.m., pengcheng xiong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44756/
> -----------------------------------------------------------
> 
> (Updated March 17, 2016, 6:03 a.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-13125
> 
> 
> Diffs
> -----
> 
>   itests/util/src/main/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidatorForTest.java fd39c67 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 2dcb6d6 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/TableMask.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationValidator.java 59aabe4 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java c93e334 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java 00fa8cf 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveV1Authorizer.java 8a03989 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/DummyHiveAuthorizationValidator.java 26e3a2c 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java 9f586be 
>   ql/src/test/queries/clientpositive/masking_1.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/masking_2.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/masking_3.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/masking_4.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/masking_5.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/masking_disablecbo_1.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/masking_disablecbo_2.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/masking_disablecbo_3.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/masking_disablecbo_4.q PRE-CREATION 
>   ql/src/test/results/clientpositive/masking_1.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/masking_2.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/masking_3.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/masking_4.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/masking_5.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/masking_disablecbo_1.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/masking_disablecbo_2.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/masking_disablecbo_3.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/masking_disablecbo_4.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44756/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengcheng xiong
> 
>

Re: Review Request 44756: Support masking and filtering of rows/columns

Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44756/#review123813
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java (line 10327)
<https://reviews.apache.org/r/44756/#comment186087>

    We need to add support for these tokens or throw exception. Ignoring them leaves a security hole.



ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java (line 10381)
<https://reviews.apache.org/r/44756/#comment186088>

    We need an early exit critirea from parts of tree where we know for sure table token cannot appear like GBY, over clause etc.



ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java (line 10395)
<https://reviews.apache.org/r/44756/#comment186090>

    This cache should be maintained at SemanticAnalyzer level, because we may retrieve metadata for tables later in compilation as well.



ql/src/java/org/apache/hadoop/hive/ql/parse/TableMask.java (line 31)
<https://reviews.apache.org/r/44756/#comment186096>

    Add javadocs for purpose of this class.



ql/src/java/org/apache/hadoop/hive/ql/parse/TableMask.java (line 43)
<https://reviews.apache.org/r/44756/#comment186094>

    We should enable only if new method suggested in interface returns true.



ql/src/java/org/apache/hadoop/hive/ql/parse/TableMask.java (line 95)
<https://reviews.apache.org/r/44756/#comment186097>

    Add LOG.debug (sb) here.



ql/src/java/org/apache/hadoop/hive/ql/parse/TableMask.java (line 99)
<https://reviews.apache.org/r/44756/#comment186099>

    Better name: addQueryBlock?



ql/src/java/org/apache/hadoop/hive/ql/parse/TableMask.java (line 103)
<https://reviews.apache.org/r/44756/#comment186100>

    Better name.



ql/src/java/org/apache/hadoop/hive/ql/parse/TableMask.java (line 107)
<https://reviews.apache.org/r/44756/#comment186098>

    Better name: needsRewrite()



ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java (line 300)
<https://reviews.apache.org/r/44756/#comment186093>

    We should add additional method boolean needToEnforceRowColumnTransformation(String username) so that we can avoid traversing AST tree if this method returns false.


- Ashutosh Chauhan


On March 14, 2016, 10:50 p.m., pengcheng xiong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44756/
> -----------------------------------------------------------
> 
> (Updated March 14, 2016, 10:50 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-13125
> 
> 
> Diffs
> -----
> 
>   itests/util/src/main/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidatorForTest.java fd39c67 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 2dcb6d6 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/TableMask.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationValidator.java 59aabe4 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java c93e334 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java 00fa8cf 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveV1Authorizer.java 8a03989 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/DummyHiveAuthorizationValidator.java 26e3a2c 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java 9f586be 
>   ql/src/test/queries/clientpositive/masking_1.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/masking_2.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/masking_3.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/masking_4.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/masking_disablecbo_1.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/masking_disablecbo_2.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/masking_disablecbo_3.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/masking_disablecbo_4.q PRE-CREATION 
>   ql/src/test/results/clientpositive/masking_1.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/masking_2.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/masking_3.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/masking_4.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/masking_disablecbo_1.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/masking_disablecbo_2.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/masking_disablecbo_3.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/masking_disablecbo_4.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44756/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengcheng xiong
> 
>

Re: Review Request 44756: Support masking and filtering of rows/columns

Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44756/#review124193
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java (line 270)
<https://reviews.apache.org/r/44756/#comment186634>

    Name : needTransform()



ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java (line 285)
<https://reviews.apache.org/r/44756/#comment186635>

    needTransform(String database, String table);


- Ashutosh Chauhan


On March 18, 2016, 4:59 a.m., pengcheng xiong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44756/
> -----------------------------------------------------------
> 
> (Updated March 18, 2016, 4:59 a.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-13125
> 
> 
> Diffs
> -----
> 
>   itests/util/src/main/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidatorForTest.java fd39c67 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 2dcb6d6 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/TableMask.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationValidator.java 59aabe4 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java c93e334 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java 00fa8cf 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveV1Authorizer.java 8a03989 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/DummyHiveAuthorizationValidator.java 26e3a2c 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java 9f586be 
>   ql/src/test/queries/clientpositive/masking_1.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/masking_2.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/masking_3.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/masking_4.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/masking_5.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/masking_disablecbo_1.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/masking_disablecbo_2.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/masking_disablecbo_3.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/masking_disablecbo_4.q PRE-CREATION 
>   ql/src/test/results/clientpositive/masking_1.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/masking_2.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/masking_3.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/masking_4.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/masking_5.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/masking_disablecbo_1.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/masking_disablecbo_2.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/masking_disablecbo_3.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/masking_disablecbo_4.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44756/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengcheng xiong
> 
>

Re: Review Request 44756: Support masking and filtering of rows/columns

Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44756/
-----------------------------------------------------------

(Updated March 18, 2016, 4:59 a.m.)


Review request for hive and Ashutosh Chauhan.


Repository: hive-git


Description
-------

HIVE-13125


Diffs (updated)
-----

  itests/util/src/main/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidatorForTest.java fd39c67 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 2dcb6d6 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TableMask.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationValidator.java 59aabe4 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java c93e334 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java 00fa8cf 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveV1Authorizer.java 8a03989 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/DummyHiveAuthorizationValidator.java 26e3a2c 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java 9f586be 
  ql/src/test/queries/clientpositive/masking_1.q PRE-CREATION 
  ql/src/test/queries/clientpositive/masking_2.q PRE-CREATION 
  ql/src/test/queries/clientpositive/masking_3.q PRE-CREATION 
  ql/src/test/queries/clientpositive/masking_4.q PRE-CREATION 
  ql/src/test/queries/clientpositive/masking_5.q PRE-CREATION 
  ql/src/test/queries/clientpositive/masking_disablecbo_1.q PRE-CREATION 
  ql/src/test/queries/clientpositive/masking_disablecbo_2.q PRE-CREATION 
  ql/src/test/queries/clientpositive/masking_disablecbo_3.q PRE-CREATION 
  ql/src/test/queries/clientpositive/masking_disablecbo_4.q PRE-CREATION 
  ql/src/test/results/clientpositive/masking_1.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/masking_2.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/masking_3.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/masking_4.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/masking_5.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/masking_disablecbo_1.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/masking_disablecbo_2.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/masking_disablecbo_3.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/masking_disablecbo_4.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/44756/diff/


Testing
-------


Thanks,

pengcheng xiong

Re: Review Request 44756: Support masking and filtering of rows/columns

Posted by pengcheng xiong <px...@hortonworks.com>.

> On March 18, 2016, 1:09 a.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java, line 374
> > <https://reviews.apache.org/r/44756/diff/3/?file=1302184#file1302184line374>
> >
> >     We need to have this cache shared for full lifecycle of query.

Sure, we will do that in a separate JIRA.


- pengcheng


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44756/#review124138
-----------------------------------------------------------


On March 18, 2016, 4:59 a.m., pengcheng xiong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44756/
> -----------------------------------------------------------
> 
> (Updated March 18, 2016, 4:59 a.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-13125
> 
> 
> Diffs
> -----
> 
>   itests/util/src/main/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidatorForTest.java fd39c67 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 2dcb6d6 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/TableMask.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationValidator.java 59aabe4 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java c93e334 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java 00fa8cf 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveV1Authorizer.java 8a03989 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/DummyHiveAuthorizationValidator.java 26e3a2c 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java 9f586be 
>   ql/src/test/queries/clientpositive/masking_1.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/masking_2.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/masking_3.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/masking_4.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/masking_5.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/masking_disablecbo_1.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/masking_disablecbo_2.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/masking_disablecbo_3.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/masking_disablecbo_4.q PRE-CREATION 
>   ql/src/test/results/clientpositive/masking_1.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/masking_2.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/masking_3.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/masking_4.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/masking_5.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/masking_disablecbo_1.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/masking_disablecbo_2.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/masking_disablecbo_3.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/masking_disablecbo_4.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44756/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengcheng xiong
> 
>

Re: Review Request 44756: Support masking and filtering of rows/columns

Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44756/#review124138
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java (line 374)
<https://reviews.apache.org/r/44756/#comment186527>

    We need to have this cache shared for full lifecycle of query.



ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java (line 270)
<https://reviews.apache.org/r/44756/#comment186525>

    No need to provide context. Its already available to impl.


- Ashutosh Chauhan


On March 17, 2016, 6:03 a.m., pengcheng xiong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44756/
> -----------------------------------------------------------
> 
> (Updated March 17, 2016, 6:03 a.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-13125
> 
> 
> Diffs
> -----
> 
>   itests/util/src/main/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidatorForTest.java fd39c67 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 2dcb6d6 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/TableMask.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationValidator.java 59aabe4 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java c93e334 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java 00fa8cf 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveV1Authorizer.java 8a03989 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/DummyHiveAuthorizationValidator.java 26e3a2c 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java 9f586be 
>   ql/src/test/queries/clientpositive/masking_1.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/masking_2.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/masking_3.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/masking_4.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/masking_5.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/masking_disablecbo_1.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/masking_disablecbo_2.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/masking_disablecbo_3.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/masking_disablecbo_4.q PRE-CREATION 
>   ql/src/test/results/clientpositive/masking_1.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/masking_2.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/masking_3.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/masking_4.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/masking_5.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/masking_disablecbo_1.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/masking_disablecbo_2.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/masking_disablecbo_3.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/masking_disablecbo_4.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44756/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengcheng xiong
> 
>

Re: Review Request 44756: Support masking and filtering of rows/columns

Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44756/
-----------------------------------------------------------

(Updated March 17, 2016, 6:03 a.m.)


Review request for hive and Ashutosh Chauhan.


Repository: hive-git


Description
-------

HIVE-13125


Diffs (updated)
-----

  itests/util/src/main/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidatorForTest.java fd39c67 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 2dcb6d6 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TableMask.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationValidator.java 59aabe4 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java c93e334 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java 00fa8cf 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveV1Authorizer.java 8a03989 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/DummyHiveAuthorizationValidator.java 26e3a2c 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java 9f586be 
  ql/src/test/queries/clientpositive/masking_1.q PRE-CREATION 
  ql/src/test/queries/clientpositive/masking_2.q PRE-CREATION 
  ql/src/test/queries/clientpositive/masking_3.q PRE-CREATION 
  ql/src/test/queries/clientpositive/masking_4.q PRE-CREATION 
  ql/src/test/queries/clientpositive/masking_5.q PRE-CREATION 
  ql/src/test/queries/clientpositive/masking_disablecbo_1.q PRE-CREATION 
  ql/src/test/queries/clientpositive/masking_disablecbo_2.q PRE-CREATION 
  ql/src/test/queries/clientpositive/masking_disablecbo_3.q PRE-CREATION 
  ql/src/test/queries/clientpositive/masking_disablecbo_4.q PRE-CREATION 
  ql/src/test/results/clientpositive/masking_1.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/masking_2.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/masking_3.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/masking_4.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/masking_5.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/masking_disablecbo_1.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/masking_disablecbo_2.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/masking_disablecbo_3.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/masking_disablecbo_4.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/44756/diff/


Testing
-------


Thanks,

pengcheng xiong

Re: Review Request 44756: Support masking and filtering of rows/columns

Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44756/
-----------------------------------------------------------

(Updated March 14, 2016, 10:50 p.m.)


Review request for hive and Ashutosh Chauhan.


Repository: hive-git


Description
-------

HIVE-13125


Diffs (updated)
-----

  itests/util/src/main/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidatorForTest.java fd39c67 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 2dcb6d6 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TableMask.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationValidator.java 59aabe4 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java c93e334 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java 00fa8cf 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveV1Authorizer.java 8a03989 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/DummyHiveAuthorizationValidator.java 26e3a2c 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java 9f586be 
  ql/src/test/queries/clientpositive/masking_1.q PRE-CREATION 
  ql/src/test/queries/clientpositive/masking_2.q PRE-CREATION 
  ql/src/test/queries/clientpositive/masking_3.q PRE-CREATION 
  ql/src/test/queries/clientpositive/masking_4.q PRE-CREATION 
  ql/src/test/queries/clientpositive/masking_disablecbo_1.q PRE-CREATION 
  ql/src/test/queries/clientpositive/masking_disablecbo_2.q PRE-CREATION 
  ql/src/test/queries/clientpositive/masking_disablecbo_3.q PRE-CREATION 
  ql/src/test/queries/clientpositive/masking_disablecbo_4.q PRE-CREATION 
  ql/src/test/results/clientpositive/masking_1.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/masking_2.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/masking_3.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/masking_4.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/masking_disablecbo_1.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/masking_disablecbo_2.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/masking_disablecbo_3.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/masking_disablecbo_4.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/44756/diff/


Testing
-------


Thanks,

pengcheng xiong