You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whirr.apache.org by Andrei Savu <sa...@gmail.com> on 2012/03/07 23:38:19 UTC
Commit Policy
Just a quick reminder for the new committers that the Commit Policy for
Apache Whirr is Review-Then-Commit.
This means that for each code change we need to have:
* a JIRA issue
* an attached patch to that JIRA issue
* at least one +1 vote from another committer or PMC member
Also before committing please update CHANGES.txt as needed.
By following this process we can be sure that JIRA is always up to
date and a good reflection of the development work we are doing.
Tom please correct me if I'm wrong.
Cheers,
-- Andrei Savu
Re: Commit Policy
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Thanks Andrei,
it makes sense.
I can prepare my patches ;)
Regards
JB
On 03/08/2012 09:46 AM, Andrei Savu wrote:
> On Thu, Mar 8, 2012 at 8:27 AM, Jean-Baptiste Onofré<jb...@nanthrax.net>wrote:
>
>> Regarding contributor, is the patch attached to the Jira should contain
>> the update of the CHANGES.txt or the "reviewer" will update it ?
>
>
> No, it should be added before commit to avoid useless conflicts.
>
--
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
Re: Commit Policy
Posted by Andrei Savu <sa...@gmail.com>.
On Thu, Mar 8, 2012 at 8:27 AM, Jean-Baptiste Onofré <jb...@nanthrax.net>wrote:
> Regarding contributor, is the patch attached to the Jira should contain
> the update of the CHANGES.txt or the "reviewer" will update it ?
No, it should be added before commit to avoid useless conflicts.
Re: Commit Policy
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Hi Andrei,
thanks for the reminder.
Regarding contributor, is the patch attached to the Jira should contain
the update of the CHANGES.txt or the "reviewer" will update it ?
Regards
JB
On 03/07/2012 11:38 PM, Andrei Savu wrote:
> Just a quick reminder for the new committers that the Commit Policy for
> Apache Whirr is Review-Then-Commit.
>
> This means that for each code change we need to have:
>
> * a JIRA issue
> * an attached patch to that JIRA issue
> * at least one +1 vote from another committer or PMC member
>
> Also before committing please update CHANGES.txt as needed.
>
> By following this process we can be sure that JIRA is always up to
> date and a good reflection of the development work we are doing.
>
> Tom please correct me if I'm wrong.
>
> Cheers,
>
> -- Andrei Savu
>
--
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
Re: Commit Policy
Posted by Tom White <to...@cloudera.com>.
Thanks Andrei.
BTW the commit guidelines are described on
https://cwiki.apache.org/confluence/display/WHIRR/How+To+Contribute
too.
Tom
On Thu, Mar 8, 2012 at 3:05 AM, Ioannis Canellos <io...@gmail.com> wrote:
> Thanks for clarifying.
>
> --
> *Ioannis Canellos*
> *
> FuseSource <http://fusesource.com>
>
> **
> Blog: http://iocanel.blogspot.com
> **
> Twitter: iocanel
> *
Re: Commit Policy
Posted by Ioannis Canellos <io...@gmail.com>.
Thanks for clarifying.
--
*Ioannis Canellos*
*
FuseSource <http://fusesource.com>
**
Blog: http://iocanel.blogspot.com
**
Twitter: iocanel
*
Re: Commit Policy
Posted by Frank Scholten <fr...@frankscholten.nl>.
Ok, thanks for the reminder!
Cheers,
Frank
On Wed, Mar 7, 2012 at 11:38 PM, Andrei Savu <sa...@gmail.com> wrote:
> Just a quick reminder for the new committers that the Commit Policy for
> Apache Whirr is Review-Then-Commit.
>
> This means that for each code change we need to have:
>
> * a JIRA issue
> * an attached patch to that JIRA issue
> * at least one +1 vote from another committer or PMC member
>
> Also before committing please update CHANGES.txt as needed.
>
> By following this process we can be sure that JIRA is always up to
> date and a good reflection of the development work we are doing.
>
> Tom please correct me if I'm wrong.
>
> Cheers,
>
> -- Andrei Savu