You are viewing a plain text version of this content. The canonical link for it is here.
Posted to c-dev@xerces.apache.org by "Roger Leigh (JIRA)" <xe...@xml.apache.org> on 2018/01/04 11:57:00 UTC
[jira] [Commented] (XERCESC-2122) CMake: wrong substitutions in
pkg-config file
[ https://issues.apache.org/jira/browse/XERCESC-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311248#comment-16311248 ]
Roger Leigh commented on XERCESC-2122:
--------------------------------------
The CURL substitution was fixed in SVN commit 1820069.
Note that the discrepancies are to be expected. The existing template expansions are using unexpanded variables set by autoconf, which don't exist in CMake. The CMake libdir and includedir don't include the unexpanded prefix variable in their definitions, and the user could override them, so including the whole expanded path is the best we can do. Likewise for CURL, we aren't using curl-config, so we include the discovered library from FindCURL with the above change.
The changes should be functionally identical to the autoconf-generated file, but if not I'll be happy to look into this further. If you have any suggestions, I'd be happy to consider them.
> CMake: wrong substitutions in pkg-config file
> ---------------------------------------------
>
> Key: XERCESC-2122
> URL: https://issues.apache.org/jira/browse/XERCESC-2122
> Project: Xerces-C++
> Issue Type: Bug
> Components: Build
> Affects Versions: 3.2.0
> Environment: Debian GNU/Linux unstable
> Reporter: Ferenc Wágner
> Fix For: 3.2.1
>
>
> Here's a diff between the {{xerces-c.pc}} files created by CMake and Autotools:
> {code}
> --- ../xerces-c.pc.cmake 2017-10-06 11:33:55.580393801 +0000
> +++ xerces-c.pc 2017-10-06 11:34:28.129103784 +0000
> @@ -1,11 +1,11 @@
> prefix=/usr/local
> -exec_prefix=/usr/local
> -libdir=/usr/local/lib
> -includedir=/usr/local/include
> +exec_prefix=${prefix}
> +libdir=${exec_prefix}/lib
> +includedir=${prefix}/include
>
> Name: Xerces-C++
> Description: Validating XML parser library for C++
> -Version:
> -Libs: -L/usr/local/lib -lxerces-c
> -Libs.private:
> -Cflags: -I/usr/local/include
> +Version: 3.2.0
> +Libs: -L${libdir} -lxerces-c
> +Libs.private: -lcurl
> +Cflags: -I${includedir}
> {code}
> In my opinion the CMake version has the following problems:
> * variables are expanded ({{prefix}} and {{includedir}}),
> * the version string is missing,
> * static linking options ({{-lcurl}}) are missing (after {{Libs.private}}).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: c-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: c-dev-help@xerces.apache.org