[jira] [Commented] (FLINK-5851) Renaming AsyncCollector into ResultPromise/ResultFuture

["Stephan Ewen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-5851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874957#comment-15874957 ] 

Stephan Ewen commented on FLINK-5851:
-------------------------------------

My preference would be to stay with the {{(Completable)Future}} naming scheme.
For some reason, the term {{Promise}} never resonated with me, especially since completing it with an exception seems totally valid, but "breaks" the promise.

> Renaming AsyncCollector into ResultPromise/ResultFuture
> -------------------------------------------------------
>
>                 Key: FLINK-5851
>                 URL: https://issues.apache.org/jira/browse/FLINK-5851
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataStream API
>    Affects Versions: 1.2.0, 1.3.0
>            Reporter: Till Rohrmann
>             Fix For: 1.3.0
>
>
> Currently, the async I/O API gives an {{AsyncCollector}} to an {{AsyncFunction}} implementation. The name does not really reflect what the {{AsyncCollector}} does since it does not collect but is actually a one time completable future. Therefore, I propose to rename the {{AsyncCollector}} into {{ResultPromise}} or {{ResultFuture}}. This is API changing.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)