[jira] [Assigned] (MESOS-4331) git commit-msg hook completely breaks fixup commits

["Andrew Schwartzmeyer (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/MESOS-4331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Schwartzmeyer reassigned MESOS-4331:
-------------------------------------------

    Assignee: Andrew Schwartzmeyer

> git commit-msg hook completely breaks fixup commits
> ---------------------------------------------------
>
>                 Key: MESOS-4331
>                 URL: https://issues.apache.org/jira/browse/MESOS-4331
>             Project: Mesos
>          Issue Type: Bug
>            Reporter: Benjamin Bannier
>            Assignee: Andrew Schwartzmeyer
>              Labels: mesosphere
>
> https://reviews.apache.org/r/41586/ added a git hook to check the commit message format. This completely breaks fixup commits which can be created with
> {code}
> % git commit --fixup=$SHA1 
> {code}
> The resulting commit message will then be the one of {{$SHA1}}, but prefixed with {{fixup!}} (followed by a literal space). Tools like {{git rebase}} can automatically use these to e.g., squash matching commits like
> {code}
> % git rebase -i origin/master --autosquash
> {code}
> Here all commits for e.g., {{$SHA1}} would be grouped together and squash automatically which is valuable when working on reviews.
> We should find a way to reenable such functionality; otherwise we risk that developers completely disable this hook.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)