You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "zjxxzjwang (via GitHub)" <gi...@apache.org> on 2025/03/21 11:11:17 UTC
[PR] Add an indicator for the count of expired messages within a cycle [pulsar]
zjxxzjwang opened a new pull request, #24106:
URL: https://github.com/apache/pulsar/pull/24106
### Motivation
<!-- Explain here the context, and why you're making that change. What is the problem you're trying to solve. -->
At present, there is only one indicator called 'countsMsgExpired' that calculates the number of messages that have expired under the current subscription over a long period of time. There is a missing indicator that calculates the number of messages that have expired under the current subscription in the past cycle. This makes it difficult to fully and directly understand the true situation of message expiration.
### Modifications
Add the msgExpiredCounter indicator to count the number of messages that have expired under the current subscription in the past cycle
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE -->
<!--
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][broker]Add the expired message count metric from this subscription within the last interval. [pulsar]
Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece closed pull request #24106: [improve][broker]Add the expired message count metric from this subscription within the last interval.
URL: https://github.com/apache/pulsar/pull/24106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][broker]Add the expired message count metric from this subscription within the last interval. [pulsar]
Posted by "zjxxzjwang (via GitHub)" <gi...@apache.org>.
zjxxzjwang commented on PR #24106:
URL: https://github.com/apache/pulsar/pull/24106#issuecomment-2841182022
Can you help me with the review？ @lhotari
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][broker]Add the expired message count metric from this subscription within the last interval. [pulsar]
Posted by "HQebupt (via GitHub)" <gi...@apache.org>.
HQebupt commented on PR #24106:
URL: https://github.com/apache/pulsar/pull/24106#issuecomment-2912568665
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add an indicator for the count of expired messages during a sampling period [pulsar]
Posted by "zjxxzjwang (via GitHub)" <gi...@apache.org>.
zjxxzjwang commented on PR #24106:
URL: https://github.com/apache/pulsar/pull/24106#issuecomment-2781899116
hello， Can you help me review it
@lhotari
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add an indicator for the count of expired messages during a sampling period [pulsar]
Posted by "zjxxzjwang (via GitHub)" <gi...@apache.org>.
zjxxzjwang commented on PR #24106:
URL: https://github.com/apache/pulsar/pull/24106#issuecomment-2774642255
@lhotari
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][broker]Add the expired message count metric from this subscription within the last interval. [pulsar]
Posted by "zjxxzjwang (via GitHub)" <gi...@apache.org>.
zjxxzjwang commented on PR #24106:
URL: https://github.com/apache/pulsar/pull/24106#issuecomment-2826206228
@lhotari Can you help me with the review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add an indicator for the count of expired messages within a cycle [pulsar]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #24106:
URL: https://github.com/apache/pulsar/pull/24106#issuecomment-2743050307
@zjxxzjwang Please add the following content to your PR description and select a checkbox:
```
- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add an indicator for the count of expired messages within a cycle [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on code in PR #24106:
URL: https://github.com/apache/pulsar/pull/24106#discussion_r2013747541
##########
pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/stats/SubscriptionStatsImpl.java:
##########
@@ -93,6 +93,9 @@ public class SubscriptionStatsImpl implements SubscriptionStats {
/** Total rate of messages expired on this subscription (msg/s). */
public double msgRateExpired;
+ /** The count of expired messages on this subscription. */
+ public long msgExpired;
Review Comment:
Is the counter behind `msgRateExpired` matching `msgExpired` or `totalMsgExpired`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add an indicator for the count of expired messages during a sampling period [pulsar]
Posted by "zjxxzjwang (via GitHub)" <gi...@apache.org>.
zjxxzjwang commented on PR #24106:
URL: https://github.com/apache/pulsar/pull/24106#issuecomment-2765028917
> > 很好的建议，我已做出必要的修改
>
> @zjxxzjwang“循环”仍然在 PR 标题中，它不是一个现有概念，因此可以改进。
@lhotari I have made the modifications, do you think this is appropriate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][broker]Add the expired message count metric from this subscription within the last interval. [pulsar]
Posted by "zjxxzjwang (via GitHub)" <gi...@apache.org>.
zjxxzjwang commented on PR #24106:
URL: https://github.com/apache/pulsar/pull/24106#issuecomment-2909181088
@nodece Hello, can you help me merge this PR? Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][broker]Add the expired message count metric from this subscription within the last interval. [pulsar]
Posted by "zjxxzjwang (via GitHub)" <gi...@apache.org>.
zjxxzjwang commented on PR #24106:
URL: https://github.com/apache/pulsar/pull/24106#issuecomment-2815078110
> > I used Deepseek for modification. Do you think this is feasible now. @lhotari
>
> @zjxxzjwang Yes, it's better now. I'm sorry for the slow feedback. I've been busy on releases and addressing CI flakiness.
>
> > [improve][broker]Add expired message count metric for monitoring periods in subscription stats
> > Added msgExpired counter in subscription statistics tracking message expirations per monitoring interval
>
> Also define what the "monitoring period" and "monitoring interval" is. Reference existing documentation or if there are gaps, explain what this is exactly. The existing documentation doesn't really seem to explain things properly: https://pulsar.apache.org/docs/4.0.x/administration-stats/ . However, there needs to be a way to explain what this is about.
>
> > The existing totalMsgExpired metric tracks cumulative message expiration counts since subscription creation, but lacks granularity for time-bound monitoring. This PR introduces a new metric to track message expiration counts per monitoring interval, enabling better observation of expiration patterns through time-series monitoring systems.
>
> It would be useful to expand this description and explain why it "lacks granularity for time-bound monitoring". Referencing previous changes in Pulsar could be useful in this. You can use the git history to research why it's like this currently.
Hello, I have made modifications to the title content based on the description of the "averageMsSize" metric. Please help me review it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add an indicator for the count of expired messages within a cycle [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #24106:
URL: https://github.com/apache/pulsar/pull/24106#issuecomment-2760816985
> Good suggestion, I have made the necessary modifications
@zjxxzjwang "cycle" is still in the PR title and it's not an existing concept so it could be improved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add an indicator for the count of expired messages within a cycle [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #24106:
URL: https://github.com/apache/pulsar/pull/24106#issuecomment-2753713181
@zjxxzjwang Please revisit the PR title and description. "within a cycle" and "over a long period of time" are vague and confusing and explaining it in other words would be useful. Once you have a draft version with other wording, you can also use the help of GenAI such as DeepSeek by following the instructions at https://gist.github.com/lhotari/81f533af4b9ad515e02d96e543c4408b for improving the title and description and then doing final edits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add an indicator for the count of expired messages within a cycle [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on code in PR #24106:
URL: https://github.com/apache/pulsar/pull/24106#discussion_r2013668176
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java:
##########
@@ -1336,6 +1336,7 @@ public CompletableFuture<SubscriptionStatsImpl> getStatsAsync(GetStatsOptions ge
}
subStats.msgBacklogNoDelayed = subStats.msgBacklog - subStats.msgDelayed;
subStats.msgRateExpired = expiryMonitor.getMessageExpiryRate();
+ subStats.msgExpiredCounter = expiryMonitor.getMessageExpiryCount();
Review Comment:
could this be named `msgExpired` so that the name is consistent with the existing other field names?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add an indicator for the count of expired messages during a sampling period [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #24106:
URL: https://github.com/apache/pulsar/pull/24106#issuecomment-2786336537
> hello， Can you help me review it @lhotari
@zjxxzjwang Did you already pass this through LLM like DeepSeek using https://gist.github.com/lhotari/81f533af4b9ad515e02d96e543c4408b ?
The concepts such as "indicator" and "during a sampling period", "timed task execution cycle", or "scheduled task execution period" aren't well known in Pulsar. It would be useful to improve the title and description of this PR further. I'm pretty sure that using an LLM and asking it to address review feedback about the PR title and description will be helpful. It will get to know about it by printing this PR page to PDF and providing it as context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][broker]Add expired message count metric for monitoring periods in subscription stats [pulsar]
Posted by "zjxxzjwang (via GitHub)" <gi...@apache.org>.
zjxxzjwang commented on PR #24106:
URL: https://github.com/apache/pulsar/pull/24106#issuecomment-2789604320
> > 你好，你能帮我审核一下吗@lhotari
>
> @zjxxzjwang[您是否已经像 DeepSeek 一样使用https://gist.github.com/lhotari/81f533af4b9ad515e02d96e543c4408b](https://gist.github.com/lhotari/81f533af4b9ad515e02d96e543c4408b)通过了 LLM ？
>
> 诸如“指标”、“采样周期”、“定时任务执行周期”或“计划任务执行周期”等概念在 Pulsar 中并不常见。进一步改进此 PR 的标题和描述会很有帮助。我确信，使用 LLM 并请求其处理关于 PR 标题和描述的审核反馈会很有帮助。它会通过将此 PR 页面打印为 PDF 并将其作为上下文提供来了解相关信息。
I used Deepseek for modification. Do you think this is feasible now. @lhotari
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][broker]Add the expired message count metric from this subscription within the last interval. [pulsar]
Posted by "Jason918 (via GitHub)" <gi...@apache.org>.
Jason918 merged PR #24106:
URL: https://github.com/apache/pulsar/pull/24106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][broker]Add the expired message count metric from this subscription within the last interval. [pulsar]
Posted by "zjxxzjwang (via GitHub)" <gi...@apache.org>.
zjxxzjwang commented on PR #24106:
URL: https://github.com/apache/pulsar/pull/24106#issuecomment-2833325045
Can you help me with the review? @lhotari
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add an indicator for the count of expired messages during a sampling period [pulsar]
Posted by "zjxxzjwang (via GitHub)" <gi...@apache.org>.
zjxxzjwang commented on PR #24106:
URL: https://github.com/apache/pulsar/pull/24106#issuecomment-2774642760
@lhotari Hello, please help me review it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][broker]Add the expired message count metric from this subscription within the last interval. [pulsar]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24106:
URL: https://github.com/apache/pulsar/pull/24106#issuecomment-2996008946
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/24106?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 74.21%. Comparing base [(`bbc6224`)](https://app.codecov.io/gh/apache/pulsar/commit/bbc62245c5ddba1de4b1e7cee4ab49334bc36277?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`d0e26fb`)](https://app.codecov.io/gh/apache/pulsar/commit/d0e26fbe70ca412ff68f688867dc01744fa69f62?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 1159 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/pulsar/pull/24106?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #24106 +/- ##
============================================
+ Coverage 73.57% 74.21% +0.64%
- Complexity 32624 32675 +51
============================================
Files 1877 1868 -9
Lines 139502 145368 +5866
Branches 15299 16629 +1330
============================================
+ Hits 102638 107885 +5247
- Misses 28908 28932 +24
- Partials 7956 8551 +595
```
| [Flag](https://app.codecov.io/gh/apache/pulsar/pull/24106/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [inttests](https://app.codecov.io/gh/apache/pulsar/pull/24106/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `26.77% <50.00%> (+2.18%)` | :arrow_up: |
| [systests](https://app.codecov.io/gh/apache/pulsar/pull/24106/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.33% <50.00%> (-0.99%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pulsar/pull/24106/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.70% <100.00%> (+0.85%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/pulsar/pull/24106?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ice/persistent/PersistentMessageExpiryMonitor.java](https://app.codecov.io/gh/apache/pulsar/pull/24106?src=pr&el=tree&filepath=pulsar-broker%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fbroker%2Fservice%2Fpersistent%2FPersistentMessageExpiryMonitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL3BlcnNpc3RlbnQvUGVyc2lzdGVudE1lc3NhZ2VFeHBpcnlNb25pdG9yLmphdmE=) | `72.88% <100.00%> (+8.71%)` | :arrow_up: |
| [...ker/service/persistent/PersistentSubscription.java](https://app.codecov.io/gh/apache/pulsar/pull/24106?src=pr&el=tree&filepath=pulsar-broker%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fbroker%2Fservice%2Fpersistent%2FPersistentSubscription.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL3BlcnNpc3RlbnQvUGVyc2lzdGVudFN1YnNjcmlwdGlvbi5qYXZh) | `76.67% <100.00%> (-0.02%)` | :arrow_down: |
| [...mon/policies/data/stats/SubscriptionStatsImpl.java](https://app.codecov.io/gh/apache/pulsar/pull/24106?src=pr&el=tree&filepath=pulsar-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fcommon%2Fpolicies%2Fdata%2Fstats%2FSubscriptionStatsImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NvbW1vbi9wb2xpY2llcy9kYXRhL3N0YXRzL1N1YnNjcmlwdGlvblN0YXRzSW1wbC5qYXZh) | `94.17% <100.00%> (+0.05%)` | :arrow_up: |
... and [1082 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/24106/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][broker]Add the expired message count metric from this subscription within the last interval. [pulsar]
Posted by "zjxxzjwang (via GitHub)" <gi...@apache.org>.
zjxxzjwang commented on PR #24106:
URL: https://github.com/apache/pulsar/pull/24106#issuecomment-2815078950
> > I used Deepseek for modification. Do you think this is feasible now. @lhotari
>
> @zjxxzjwang Yes, it's better now. I'm sorry for the slow feedback. I've been busy on releases and addressing CI flakiness.
>
> > [improve][broker]Add expired message count metric for monitoring periods in subscription stats
> > Added msgExpired counter in subscription statistics tracking message expirations per monitoring interval
>
> Also define what the "monitoring period" and "monitoring interval" is. Reference existing documentation or if there are gaps, explain what this is exactly. The existing documentation doesn't really seem to explain things properly: https://pulsar.apache.org/docs/4.0.x/administration-stats/ . However, there needs to be a way to explain what this is about.
>
> > The existing totalMsgExpired metric tracks cumulative message expiration counts since subscription creation, but lacks granularity for time-bound monitoring. This PR introduces a new metric to track message expiration counts per monitoring interval, enabling better observation of expiration patterns through time-series monitoring systems.
>
> It would be useful to expand this description and explain why it "lacks granularity for time-bound monitoring". Referencing previous changes in Pulsar could be useful in this. You can use the git history to research why it's like this currently.
Hello, I have made modifications to the title content based on the description of the "averageMsSize" metric. Please help me review it. @lhotari
<img width="921" alt="Clipboard_Screenshot_1744968814" src="https://github.com/user-attachments/assets/c67953d8-d845-4375-9d51-7469626ce9a0" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][broker]Add expired message count metric for monitoring periods in subscription stats [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #24106:
URL: https://github.com/apache/pulsar/pull/24106#issuecomment-2796309445
> I used Deepseek for modification. Do you think this is feasible now. @lhotari
@zjxxzjwang Yes, it's better now. I'm sorry for the slow feedback. I've been busy on releases and addressing CI flakiness.
> [improve][broker]Add expired message count metric for monitoring periods in subscription stats
> Added msgExpired counter in subscription statistics tracking message expirations per monitoring interval
Also define what the "monitoring period" and "monitoring interval" is. Reference existing documentation or if there are gaps, explain what this is exactly.
> The existing totalMsgExpired metric tracks cumulative message expiration counts since subscription creation, but lacks granularity for time-bound monitoring. This PR introduces a new metric to track message expiration counts per monitoring interval, enabling better observation of expiration patterns through time-series monitoring systems.
It would be useful to expand this description and explain why it "lacks granularity for time-bound monitoring". Referencing previous changes in Pulsar could be useful in this. You can use the git history to research why it's like this currently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add an indicator for the count of expired messages within a cycle [pulsar]
Posted by "zjxxzjwang (via GitHub)" <gi...@apache.org>.
zjxxzjwang commented on PR #24106:
URL: https://github.com/apache/pulsar/pull/24106#issuecomment-2754038048
> @zjxxzjwang请重新审视 PR 标题和描述。“在一个周期内”和“在很长一段时间内”含糊不清且令人困惑，用其他词语解释会很有用。一旦您有了其他措辞的草稿版本，您还可以按照https://gist.github.com/lhotari/81f533af4b9ad515e02d96e543c4408b上的说明，使用 GenAI（如 DeepSeek）的帮助来改进标题和描述，然后进行最终编辑。
Good suggestion, I have made the necessary modifications
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org