You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/01/02 03:08:58 UTC
[jira] [Commented] (DRILL-5080) Create a memory-managed version of
the External Sort operator
[ https://issues.apache.org/jira/browse/DRILL-5080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15792082#comment-15792082 ]
ASF GitHub Bot commented on DRILL-5080:
---------------------------------------
GitHub user paul-rogers opened a pull request:
https://github.com/apache/drill/pull/717
DRILL-5080: Memory-managed version of external sort
Please see the DRILL-5080 JIRA, and subtasks, for reasons for revision, design spec and list of changes. Basically the idea is to beef up the logic in the external sort to ensure that it operates within a defined memory budget. In order to do the work, the code was first refactored into smaller, easier to digest functions.
As a precaution, the original external sort code is unchanged. The "managed" version was created as a new operator that must be enabled. Reviewers can compare the old and new versions. Users can continue to favor the old version until the new version is fully ready for prime-time.
This PR covers the changes to the external sort itself. Tests for this operator require the test framework in DRILL-5126 and the mock data source in DRILL-5152. Tests for this operator will be issued as a separate PR once those two dependencies are committed.
Until then, the new operator is disabled by default. It can be enabled using
```
drill.sort.external.disable_managed: false
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paul-rogers/drill DRILL-5080
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/717.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #717
----
commit 716e422bc70fa16b193ecce245d392c759784247
Author: Paul Rogers <pr...@maprtech.com>
Date: 2016-12-16T03:54:05Z
DRILL-5080: Memory-managed version of external sort
Please see JIRA entry for reasons for revision, design spec and list of
changes.
This PR covers the changes to the external sort itself. Tests for this
operator require the test framework in DRILL-5126 and the mock data
source in DRILL-5152. Tests for this operator will be issued as a
separate PR once those two dependencies are committed.
Until then, the new operator is disabled by default. It can be enabled
using drill.sort.external.disable_managed: false.
----
> Create a memory-managed version of the External Sort operator
> -------------------------------------------------------------
>
> Key: DRILL-5080
> URL: https://issues.apache.org/jira/browse/DRILL-5080
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.8.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Fix For: 1.10
>
> Attachments: ManagedExternalSortDesign.pdf
>
>
> We propose to create a "managed" version of the external sort operator that works to a clearly-defined memory limit. Attached is a design specification for the work.
> The project will include fixing a number of bugs related to the external sort, include as sub-tasks of this umbrella task.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)