You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Joshua Humphries (JIRA)" <ji...@apache.org> on 2017/05/09 22:05:05 UTC
[jira] [Updated] (SOLR-10285) Reduce state messages when there are
leader only shards
[ https://issues.apache.org/jira/browse/SOLR-10285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joshua Humphries updated SOLR-10285:
------------------------------------
Attachment: SOLR-10285.patch
> "Yonik's law of patches" reads "A half-baked patch with no documentation, no tests and no backwards compatibility is better than no patch at all.".
Erick,
In that spirit, I managed to dig up this small patch. But full warning: it is not tested and has a couple of TODOs that are likely critical to actually address.
I had kicked off a run of the existing test suite to see what this broke, but I no longer have the results of that run. I had not yet started to write new tests.
Also, the patch was created from a fork of 5.5.3. Hopefully it will apply cleanly for you.
> Reduce state messages when there are leader only shards
> -------------------------------------------------------
>
> Key: SOLR-10285
> URL: https://issues.apache.org/jira/browse/SOLR-10285
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Varun Thacker
> Assignee: Cao Manh Dat
> Attachments: SOLR-10285.patch
>
>
> For shards which have 1 replica ( leader ) we know it doesn't need to recover from anyone. We should short-circuit the recovery process in this case.
> The motivation for this being that we will generate less state events and be able to mark these replicas as active again without it needing to go into 'recovering' state.
> We already short circuit when you set {{-Dsolrcloud.skip.autorecovery=true}} but that sys prop was meant for tests only. Extending this to make sure the code short-circuits when the core knows its the only replica in the shard is the motivation of the Jira.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org