[GitHub] [beam] TheNeuralBit commented on a change in pull request #11502: [BEAM-9797] use virtualenv for Java license pulling

[GitBox <gi...@apache.org>]

TheNeuralBit commented on a change in pull request #11502:
URL: https://github.com/apache/beam/pull/11502#discussion_r417686263



##########
File path: sdks/java/container/license_scripts/pull_licenses_java.py
##########
@@ -35,18 +35,9 @@
 from tenacity import retry
 from tenacity import stop_after_attempt
 from tenacity import wait_exponential
+from urllib.request import urlopen, URLError, HTTPError
+
 
-try:
-    # py2
-    from future.moves.urllib.request import urlopen
-    from future.moves.urllib.request import URLError, HTTPError
-except:
-    # py3
-    from future import standard_library
-    from urllib.request import urlopen, URLError, HTTPError

Review comment:
       @Hannah-Jiang @udim should we keep the py2 imports for now? I still have python 2 as the default `python` on my machine, so this change broke :sdks:java:container:docker for me
   
   Or maybe I should have changed the default by now?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org