You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/10 21:12:49 UTC

[GitHub] [incubator-superset] suddjian opened a new pull request #10288: Dynamically imported viz plugins

suddjian opened a new pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   Work-in-progress to add functionality to import plugins dynamically. A corresponding plugin can be found here: https://github.com/apache-superset/dynamic-import-demo-plugin
   
   Goals:
   - Make it possible to create plugins without changing code in other repos
   - Allow users of Superset to add new chart types without backend access
   - Allow plugin authors to use whatever languages and code styles they prefer
   - Open the door to developing a future “app store” so that plugins can be conveniently searched and installed at the press of a button
   
   How it works:
   - Plugin author starts with the template repo with a structure similar to existing plugins. Builds a bundle using Webpack.
   - Shared packages (react, lodash, @superset-ui) are externals provided superset-side and are referenced as externals.
   - Bundle is hosted somewhere on the web - CDN, github etc. The plugin has `serve` command to help with local development.
   - Use the new Custom Plugin UI in Superset (under the "Manage" menu) to add the plugin to Superset.
   
   Various hacks were necessary to build a PoC, but I believe they can all be solved with some kind of arcane webpack incantation:
   - Assigning modules to namespaced global objects to support a plugin's external dependencies instead of an actual dependency management system
   - Can’t async import from inside the plugin
   - Images/other assets. How do we load them if we don't know where the plugin is going to be hosted? Currently using url-loader with limit: Infinity, which works but is kinda sad.
   -  I'm still tracking down all the places in Superset that need to change to respect async import of plugins.
   
   I'd greatly appreciate any help addressing these issues, or any feedback on the code that anyone has!
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] suddjian commented on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
suddjian commented on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747313544


   Opening a PR in superset-ui to support this branch.
   
   https://github.com/apache-superset/superset-ui/pull/871


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] villebro commented on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-750344981


   @betodealmeida what version of MySQL are you seeing this on?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (e9b88ca) into [master](https://codecov.io/gh/apache/incubator-superset/commit/49ec13c68c183b110b5c7ad18dfb829ce9f34245?el=desc) (49ec13c) will **decrease** coverage by `1.97%`.
   > The diff coverage is `69.76%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   65.86%   63.89%   -1.98%     
   ==========================================
     Files         972      484     -488     
     Lines       48051    29721   -18330     
     Branches     4716        0    -4716     
   ==========================================
   - Hits        31650    18990   -12660     
   + Misses      16259    10731    -5528     
   + Partials      142        0     -142     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.89% <69.76%> (-0.32%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.51% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.24% <100.00%> (-0.27%)` | :arrow_down: |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.34% <100.00%> (ø)` | |
   | ... and [497 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [49ec13c...e9b88ca](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (5caac5d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/865beae3d8644bb5e9df156e5fea80c3ec0202a2?el=desc) (865beae) will **decrease** coverage by `1.60%`.
   > The diff coverage is `75.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   65.82%   64.21%   -1.61%     
   ==========================================
     Files         988      484     -504     
     Lines       48702    29759   -18943     
     Branches     4907        0    -4907     
   ==========================================
   - Hits        32056    19110   -12946     
   + Misses      16501    10649    -5852     
   + Partials      145        0     -145     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `64.21% <75.00%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.54% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.50% <100.00%> (ø)` | |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.71% <100.00%> (ø)` | |
   | ... and [498 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [865beae...5caac5d](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] suddjian commented on a change in pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#discussion_r546194904



##########
File path: superset/security/manager.py
##########
@@ -109,7 +109,12 @@ class SupersetSecurityManager(  # pylint: disable=too-many-public-methods
     SecurityManager
 ):
     userstatschartview = None
-    READ_ONLY_MODEL_VIEWS = {"DatabaseAsync", "DatabaseView", "DruidClusterModelView"}
+    READ_ONLY_MODEL_VIEWS = {
+        "DatabaseAsync",
+        "DatabaseView",
+        "DruidClusterModelView",
+        "DynamicPlugin",

Review comment:
       this makes it so that only admins can write to dynamic plugins endpoints




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (2547086) into [master](https://codecov.io/gh/apache/incubator-superset/commit/865beae3d8644bb5e9df156e5fea80c3ec0202a2?el=desc) (865beae) will **decrease** coverage by `2.80%`.
   > The diff coverage is `36.27%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   65.82%   63.01%   -2.81%     
   ==========================================
     Files         988      992       +4     
     Lines       48702    48812     +110     
     Branches     4907     4922      +15     
   ==========================================
   - Hits        32056    30759    -1297     
   - Misses      16501    17856    +1355     
   - Partials      145      197      +52     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `61.38% <27.98%> (-0.60%)` | :arrow_down: |
   | python | `64.06% <75.00%> (-0.15%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/addSlice/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FwcC50c3g=) | `0.00% <0.00%> (ø)` | |
   | [superset-frontend/src/chart/chartReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci5qcw==) | `24.24% <0.00%> (-20.21%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <ø> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <ø> (-100.00%)` | :arrow_down: |
   | [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `8.57% <ø> (-40.73%)` | :arrow_down: |
   | [...src/explore/components/controls/VizTypeControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC5qc3g=) | `72.72% <0.00%> (-19.59%)` | :arrow_down: |
   | [...et-frontend/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZXhwbG9yZVJlZHVjZXIuanM=) | `31.57% <0.00%> (-2.97%)` | :arrow_down: |
   | [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | `0.00% <0.00%> (-26.83%)` | :arrow_down: |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.54% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | ... and [177 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [865beae...2547086](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (7624937) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92fdf54aa34ed2edd5c85b5b47053bf4ce559517?el=desc) (92fdf54) will **decrease** coverage by `2.75%`.
   > The diff coverage is `70.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   66.71%   63.95%   -2.76%     
   ==========================================
     Files         967      484     -483     
     Lines       47543    29710   -17833     
     Branches     4650        0    -4650     
   ==========================================
   - Hits        31716    19000   -12716     
   + Misses      15706    10710    -4996     
   + Partials      121        0     -121     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.95% <70.45%> (-0.09%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.51% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.37% <100.00%> (-0.14%)` | :arrow_down: |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.59% <100.00%> (ø)` | |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | ... and [487 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [92fdf54...7624937](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] suddjian commented on a change in pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#discussion_r547511658



##########
File path: superset-frontend/cypress-base/cypress/integration/chart_list/card_view.test.ts
##########
@@ -107,11 +113,12 @@ describe('chart card view', () => {
     cy.get('[data-test="modal-cancel-button"]').click();
   });
 
-  it('should edit correctly', () => {
+  // flaky
+  xit('should edit correctly', () => {

Review comment:
       All of these tests failed and passed at various times, as well as on other PRs. We did a little investigation but haven't found the cause of flakiness yet.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] ktmud commented on a change in pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#discussion_r546507469



##########
File path: superset-frontend/cypress-base/cypress/integration/chart_list/card_view.test.ts
##########
@@ -107,11 +113,12 @@ describe('chart card view', () => {
     cy.get('[data-test="modal-cancel-button"]').click();
   });
 
-  it('should edit correctly', () => {
+  // flaky
+  xit('should edit correctly', () => {

Review comment:
       Why did we nix  so many tests? Were they causing problems in other PRs, too? If yes, I think it would be better if they were turned off in a separate PR so we can keep  better track of them.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] suddjian commented on a change in pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#discussion_r546193026



##########
File path: superset-frontend/src/utils/getControlsForVizType.js
##########
@@ -21,26 +21,29 @@ import memoize from 'lodash/memoize';
 import { getChartControlPanelRegistry } from '@superset-ui/core';
 import { controls } from '../explore/controls';
 
-const getControlsForVizType = memoize(vizType => {
+const memoizedControls = memoize((vizType, controlPanel) => {

Review comment:
       had to change memoization again here




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (32ecf2d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92fdf54aa34ed2edd5c85b5b47053bf4ce559517?el=desc) (92fdf54) will **decrease** coverage by `3.11%`.
   > The diff coverage is `70.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   66.71%   63.59%   -3.12%     
   ==========================================
     Files         967      484     -483     
     Lines       47543    29695   -17848     
     Branches     4650        0    -4650     
   ==========================================
   - Hits        31716    18886   -12830     
   + Misses      15706    10809    -4897     
   + Partials      121        0     -121     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.59% <70.45%> (-0.44%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.51% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.36% <100.00%> (-0.15%)` | :arrow_down: |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.59% <100.00%> (ø)` | |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | ... and [495 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [92fdf54...7624937](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (32ecf2d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92fdf54aa34ed2edd5c85b5b47053bf4ce559517?el=desc) (92fdf54) will **decrease** coverage by `2.70%`.
   > The diff coverage is `70.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   66.71%   64.00%   -2.71%     
   ==========================================
     Files         967      484     -483     
     Lines       47543    29710   -17833     
     Branches     4650        0    -4650     
   ==========================================
   - Hits        31716    19015   -12701     
   + Misses      15706    10695    -5011     
   + Partials      121        0     -121     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `64.00% <70.45%> (-0.04%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.51% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.37% <100.00%> (-0.14%)` | :arrow_down: |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.59% <100.00%> (ø)` | |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | ... and [485 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [92fdf54...7624937](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (c5821c2) into [master](https://codecov.io/gh/apache/incubator-superset/commit/49ec13c68c183b110b5c7ad18dfb829ce9f34245?el=desc) (49ec13c) will **decrease** coverage by `2.77%`.
   > The diff coverage is `32.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   65.86%   63.09%   -2.78%     
   ==========================================
     Files         972      977       +5     
     Lines       48051    48174     +123     
     Branches     4716     4774      +58     
   ==========================================
   - Hits        31650    30395    -1255     
   - Misses      16259    17587    +1328     
   - Partials      142      192      +50     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `61.29% <25.71%> (-0.70%)` | :arrow_down: |
   | python | `64.21% <69.76%> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/addSlice/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FwcC50c3g=) | `0.00% <0.00%> (ø)` | |
   | [superset-frontend/src/chart/chartReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci5qcw==) | `24.24% <0.00%> (-20.21%)` | :arrow_down: |
   | [...omponents/DynamicPlugins/DynamicPluginProvider.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRHluYW1pY1BsdWdpbnMvRHluYW1pY1BsdWdpblByb3ZpZGVyLnRzeA==) | `0.00% <0.00%> (ø)` | |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <ø> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <ø> (-100.00%)` | :arrow_down: |
   | [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `8.57% <ø> (-40.73%)` | :arrow_down: |
   | [...src/explore/components/controls/VizTypeControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC5qc3g=) | `73.58% <0.00%> (-14.42%)` | :arrow_down: |
   | [...et-frontend/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZXhwbG9yZVJlZHVjZXIuanM=) | `31.57% <0.00%> (-2.97%)` | :arrow_down: |
   | [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | `0.00% <0.00%> (-26.83%)` | :arrow_down: |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.51% <ø> (ø)` | |
   | ... and [178 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [49ec13c...c5821c2](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (4f23ee6) into [master](https://codecov.io/gh/apache/incubator-superset/commit/865beae3d8644bb5e9df156e5fea80c3ec0202a2?el=desc) (865beae) will **decrease** coverage by `2.22%`.
   > The diff coverage is `75.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   65.82%   63.59%   -2.23%     
   ==========================================
     Files         988      484     -504     
     Lines       48702    29759   -18943     
     Branches     4907        0    -4907     
   ==========================================
   - Hits        32056    18925   -13131     
   + Misses      16501    10834    -5667     
   + Partials      145        0     -145     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.59% <75.00%> (-0.61%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.54% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.24% <100.00%> (-0.27%)` | :arrow_down: |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.71% <100.00%> (ø)` | |
   | ... and [508 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [865beae...4f23ee6](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] rusackas commented on a change in pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#discussion_r545659665



##########
File path: superset-frontend/src/explore/components/ControlPanelsContainer.jsx
##########
@@ -182,6 +186,15 @@ class ControlPanelsContainer extends React.Component {
   }
 
   render() {
+    const controlPanelRegistry = getChartControlPanelRegistry();
+    if (
+      !controlPanelRegistry.has(this.props.form_data.viz_type) &&
+      this.context.loading
+    ) {
+      // TODO [dynamic-plugins] replace with a snazzy loading spinner

Review comment:
       You could just `import Loading from 'src/components/Loading';` and then here just `return <Loading />;`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (c5821c2) into [master](https://codecov.io/gh/apache/incubator-superset/commit/49ec13c68c183b110b5c7ad18dfb829ce9f34245?el=desc) (49ec13c) will **decrease** coverage by `2.22%`.
   > The diff coverage is `69.76%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   65.86%   63.64%   -2.23%     
   ==========================================
     Files         972      484     -488     
     Lines       48051    29721   -18330     
     Branches     4716        0    -4716     
   ==========================================
   - Hits        31650    18916   -12734     
   + Misses      16259    10805    -5454     
   + Partials      142        0     -142     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.64% <69.76%> (-0.57%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.51% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.37% <100.00%> (-0.14%)` | :arrow_down: |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.34% <100.00%> (ø)` | |
   | ... and [489 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [49ec13c...c5821c2](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (c5821c2) into [master](https://codecov.io/gh/apache/incubator-superset/commit/49ec13c68c183b110b5c7ad18dfb829ce9f34245?el=desc) (49ec13c) will **decrease** coverage by `3.12%`.
   > The diff coverage is `32.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   65.86%   62.74%   -3.13%     
   ==========================================
     Files         972      977       +5     
     Lines       48051    48174     +123     
     Branches     4716     4774      +58     
   ==========================================
   - Hits        31650    30227    -1423     
   - Misses      16259    17755    +1496     
   - Partials      142      192      +50     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `61.29% <25.71%> (-0.70%)` | :arrow_down: |
   | python | `63.64% <69.76%> (-0.57%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/addSlice/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FwcC50c3g=) | `0.00% <0.00%> (ø)` | |
   | [superset-frontend/src/chart/chartReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci5qcw==) | `24.24% <0.00%> (-20.21%)` | :arrow_down: |
   | [...omponents/DynamicPlugins/DynamicPluginProvider.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRHluYW1pY1BsdWdpbnMvRHluYW1pY1BsdWdpblByb3ZpZGVyLnRzeA==) | `0.00% <0.00%> (ø)` | |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <ø> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <ø> (-100.00%)` | :arrow_down: |
   | [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `8.57% <ø> (-40.73%)` | :arrow_down: |
   | [...src/explore/components/controls/VizTypeControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC5qc3g=) | `73.58% <0.00%> (-14.42%)` | :arrow_down: |
   | [...et-frontend/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZXhwbG9yZVJlZHVjZXIuanM=) | `31.57% <0.00%> (-2.97%)` | :arrow_down: |
   | [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | `0.00% <0.00%> (-26.83%)` | :arrow_down: |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.51% <ø> (ø)` | |
   | ... and [186 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [49ec13c...c5821c2](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (c5821c2) into [master](https://codecov.io/gh/apache/incubator-superset/commit/49ec13c68c183b110b5c7ad18dfb829ce9f34245?el=desc) (49ec13c) will **decrease** coverage by `2.27%`.
   > The diff coverage is `69.76%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   65.86%   63.59%   -2.28%     
   ==========================================
     Files         972      484     -488     
     Lines       48051    29721   -18330     
     Branches     4716        0    -4716     
   ==========================================
   - Hits        31650    18900   -12750     
   + Misses      16259    10821    -5438     
   + Partials      142        0     -142     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.59% <69.76%> (-0.62%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.51% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.24% <100.00%> (-0.27%)` | :arrow_down: |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.34% <100.00%> (ø)` | |
   | ... and [491 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [49ec13c...c5821c2](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (080675f) into [master](https://codecov.io/gh/apache/incubator-superset/commit/865beae3d8644bb5e9df156e5fea80c3ec0202a2?el=desc) (865beae) will **decrease** coverage by `2.17%`.
   > The diff coverage is `75.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   65.82%   63.64%   -2.18%     
   ==========================================
     Files         988      484     -504     
     Lines       48702    29759   -18943     
     Branches     4907        0    -4907     
   ==========================================
   - Hits        32056    18941   -13115     
   + Misses      16501    10818    -5683     
   + Partials      145        0     -145     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.64% <75.00%> (-0.56%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.54% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.37% <100.00%> (-0.14%)` | :arrow_down: |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.71% <100.00%> (ø)` | |
   | ... and [506 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [865beae...080675f](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] dpgaspar commented on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
dpgaspar commented on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-750354683


   @betodealmeida can you share the entire log, was there any data present during the mig? could explain why it passed CI


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (32ecf2d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92fdf54aa34ed2edd5c85b5b47053bf4ce559517?el=desc) (92fdf54) will **decrease** coverage by `2.55%`.
   > The diff coverage is `70.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   66.71%   64.15%   -2.56%     
   ==========================================
     Files         967      484     -483     
     Lines       47543    29710   -17833     
     Branches     4650        0    -4650     
   ==========================================
   - Hits        31716    19061   -12655     
   + Misses      15706    10649    -5057     
   + Partials      121        0     -121     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `64.15% <70.45%> (+0.12%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.51% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.50% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.59% <100.00%> (ø)` | |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | ... and [480 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [92fdf54...7624937](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (4f23ee6) into [master](https://codecov.io/gh/apache/incubator-superset/commit/865beae3d8644bb5e9df156e5fea80c3ec0202a2?el=desc) (865beae) will **decrease** coverage by `2.17%`.
   > The diff coverage is `75.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   65.82%   63.64%   -2.18%     
   ==========================================
     Files         988      484     -504     
     Lines       48702    29759   -18943     
     Branches     4907        0    -4907     
   ==========================================
   - Hits        32056    18941   -13115     
   + Misses      16501    10818    -5683     
   + Partials      145        0     -145     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.64% <75.00%> (-0.56%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.54% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.37% <100.00%> (-0.14%)` | :arrow_down: |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.71% <100.00%> (ø)` | |
   | ... and [506 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [865beae...4f23ee6](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] suddjian removed a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
suddjian removed a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747313544


   Opening a PR in superset-ui to support this branch.
   
   https://github.com/apache-superset/superset-ui/pull/871


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] dpgaspar removed a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
dpgaspar removed a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-750354683


   @betodealmeida can you share the entire log


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (7624937) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92fdf54aa34ed2edd5c85b5b47053bf4ce559517?el=desc) (92fdf54) will **decrease** coverage by `2.55%`.
   > The diff coverage is `70.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   66.71%   64.15%   -2.56%     
   ==========================================
     Files         967      484     -483     
     Lines       47543    29710   -17833     
     Branches     4650        0    -4650     
   ==========================================
   - Hits        31716    19061   -12655     
   + Misses      15706    10649    -5057     
   + Partials      121        0     -121     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `64.15% <70.45%> (+0.12%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.51% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.50% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.59% <100.00%> (ø)` | |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | ... and [480 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [92fdf54...7624937](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (080675f) into [master](https://codecov.io/gh/apache/incubator-superset/commit/865beae3d8644bb5e9df156e5fea80c3ec0202a2?el=desc) (865beae) will **decrease** coverage by `2.22%`.
   > The diff coverage is `75.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   65.82%   63.59%   -2.23%     
   ==========================================
     Files         988      484     -504     
     Lines       48702    29759   -18943     
     Branches     4907        0    -4907     
   ==========================================
   - Hits        32056    18925   -13131     
   + Misses      16501    10834    -5667     
   + Partials      145        0     -145     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.59% <75.00%> (-0.61%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.54% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.24% <100.00%> (-0.27%)` | :arrow_down: |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.71% <100.00%> (ø)` | |
   | ... and [508 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [865beae...080675f](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] suddjian commented on a change in pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#discussion_r546189887



##########
File path: superset-frontend/spec/javascripts/explore/store_spec.jsx
##########
@@ -66,18 +66,5 @@ describe('store', () => {
       const outputFormData = applyDefaultFormData(inputFormData);
       expect(outputFormData.row_limit).toBe(null);
     });
-
-    it('removes out of scope, or deprecated keys', () => {

Review comment:
       This is testing behavior we no longer want




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (680feb2) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92fdf54aa34ed2edd5c85b5b47053bf4ce559517?el=desc) (92fdf54) will **decrease** coverage by `2.56%`.
   > The diff coverage is `70.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   66.71%   64.14%   -2.57%     
   ==========================================
     Files         967      484     -483     
     Lines       47543    29710   -17833     
     Branches     4650        0    -4650     
   ==========================================
   - Hits        31716    19058   -12658     
   + Misses      15706    10652    -5054     
   + Partials      121        0     -121     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `64.14% <70.45%> (+0.11%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.51% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.50% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.59% <100.00%> (ø)` | |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | ... and [481 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [92fdf54...7624937](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (2547086) into [master](https://codecov.io/gh/apache/incubator-superset/commit/865beae3d8644bb5e9df156e5fea80c3ec0202a2?el=desc) (865beae) will **decrease** coverage by `1.75%`.
   > The diff coverage is `75.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   65.82%   64.06%   -1.76%     
   ==========================================
     Files         988      484     -504     
     Lines       48702    29759   -18943     
     Branches     4907        0    -4907     
   ==========================================
   - Hits        32056    19064   -12992     
   + Misses      16501    10695    -5806     
   + Partials      145        0     -145     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `64.06% <75.00%> (-0.15%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.54% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.37% <100.00%> (-0.14%)` | :arrow_down: |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.71% <100.00%> (ø)` | |
   | ... and [503 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [865beae...2547086](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] suddjian edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
suddjian edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-684058017


   A cypress test sounds like a good idea to me.
   
   I have the example plugin working locally, maybe I can help there?
   
   I think dynamic plugins in the long run will have a different set of requirements than static plugins. I'm thinking about adding some kind of `manifest` json file to specify the plugin name, key, thumbnail, version, and main module. That would allow the backend to inspect plugin info without loading the plugin in a js environment. We could build these things into the yeoman generator, but I think for now this should be considered a very experimental feature and the interface is subject to change.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (2547086) into [master](https://codecov.io/gh/apache/incubator-superset/commit/865beae3d8644bb5e9df156e5fea80c3ec0202a2?el=desc) (865beae) will **decrease** coverage by `2.17%`.
   > The diff coverage is `75.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   65.82%   63.64%   -2.18%     
   ==========================================
     Files         988      484     -504     
     Lines       48702    29759   -18943     
     Branches     4907        0    -4907     
   ==========================================
   - Hits        32056    18941   -13115     
   + Misses      16501    10818    -5683     
   + Partials      145        0     -145     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.64% <75.00%> (-0.56%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.54% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.37% <100.00%> (-0.14%)` | :arrow_down: |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.71% <100.00%> (ø)` | |
   | ... and [506 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [865beae...2547086](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (521dccf) into [master](https://codecov.io/gh/apache/incubator-superset/commit/865beae3d8644bb5e9df156e5fea80c3ec0202a2?el=desc) (865beae) will **decrease** coverage by `2.53%`.
   > The diff coverage is `75.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   65.82%   63.29%   -2.54%     
   ==========================================
     Files         988      484     -504     
     Lines       48702    29744   -18958     
     Branches     4907        0    -4907     
   ==========================================
   - Hits        32056    18825   -13231     
   + Misses      16501    10919    -5582     
   + Partials      145        0     -145     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.29% <75.00%> (-0.92%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.54% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.23% <100.00%> (-0.28%)` | :arrow_down: |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.71% <100.00%> (ø)` | |
   | ... and [529 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [865beae...521dccf](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] dpgaspar edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
dpgaspar edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-750354683


   @betodealmeida can you share the entire log


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (e9b88ca) into [master](https://codecov.io/gh/apache/incubator-superset/commit/49ec13c68c183b110b5c7ad18dfb829ce9f34245?el=desc) (49ec13c) will **decrease** coverage by `1.97%`.
   > The diff coverage is `69.76%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   65.86%   63.89%   -1.98%     
   ==========================================
     Files         972      484     -488     
     Lines       48051    29719   -18332     
     Branches     4716        0    -4716     
   ==========================================
   - Hits        31650    18988   -12662     
   + Misses      16259    10731    -5528     
   + Partials      142        0     -142     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.89% <69.76%> (-0.32%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.51% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.24% <100.00%> (-0.27%)` | :arrow_down: |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.34% <100.00%> (ø)` | |
   | ... and [499 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [49ec13c...e9b88ca](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] amitNielsen commented on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
amitNielsen commented on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-674350328


   @suddjian I'm happy to help out here 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] suddjian commented on a change in pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#discussion_r546199584



##########
File path: superset-frontend/src/explore/components/ExploreViewContainer.jsx
##########
@@ -265,88 +242,100 @@ class ExploreViewContainer extends React.Component {
     }
   }
 
-  findChangedControlKeys(prevControls, currentControls) {
-    return Object.keys(currentControls).filter(
-      key =>
-        typeof prevControls[key] !== 'undefined' &&
-        !areObjectsEqual(currentControls[key].value, prevControls[key].value),
-    );
+  function onStop() {
+    if (props.chart && props.chart.queryController) {
+      props.chart.queryController.abort();
+    }
   }
 
-  hasDisplayControlChanged(changedControlKeys, currentControls) {
-    return changedControlKeys.some(key => currentControls[key].renderTrigger);
+  function toggleModal() {
+    setShowingModal(!showingModal);
   }
 
-  hasQueryControlChanged(changedControlKeys, currentControls) {
-    return changedControlKeys.some(
-      key =>
-        !currentControls[key].renderTrigger &&
-        !currentControls[key].dontRefreshOnChange,
-    );
+  function toggleCollapse() {
+    setIsCollapsed(!isCollapsed);
   }
 
-  addHistory({ isReplace = false, title }) {
-    const payload = { ...this.props.form_data };
-    const longUrl = getExploreLongUrl(this.props.form_data, null, false);
-    try {
-      if (isReplace) {
-        window.history.replaceState(payload, title, longUrl);
-      } else {
-        window.history.pushState(payload, title, longUrl);
-      }
-    } catch (e) {
-      logging.warn(
-        'Failed at altering browser history',
-        payload,
-        title,
-        longUrl,
-      );
-    }
+  // effect to run on mount
+  useEffect(() => {
+    props.actions.logEvent(LOG_ACTIONS_MOUNT_EXPLORER);
+    addHistory({ isReplace: true });
+    window.addEventListener('popstate', handlePopstate);
+    document.addEventListener('keydown', handleKeydown);
+    return () => {
+      window.removeEventListener('popstate', handlePopstate);
+      document.removeEventListener('keydown', handleKeydown);
+    };
+  }, []);
 
-    // it seems some browsers don't support pushState title attribute
-    if (title) {
-      document.title = title;
+  useEffect(() => {
+    if (wasDynamicPluginLoading && !isDynamicPluginLoading) {

Review comment:
       this effect is the only functionality in this file that's actually new




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] stale[bot] commented on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-734494777


   This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (2547086) into [master](https://codecov.io/gh/apache/incubator-superset/commit/865beae3d8644bb5e9df156e5fea80c3ec0202a2?el=desc) (865beae) will **decrease** coverage by `2.71%`.
   > The diff coverage is `36.27%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   65.82%   63.10%   -2.72%     
   ==========================================
     Files         988      992       +4     
     Lines       48702    48812     +110     
     Branches     4907     4922      +15     
   ==========================================
   - Hits        32056    30802    -1254     
   - Misses      16501    17813    +1312     
   - Partials      145      197      +52     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `61.38% <27.98%> (-0.60%)` | :arrow_down: |
   | python | `64.20% <75.00%> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/addSlice/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FwcC50c3g=) | `0.00% <0.00%> (ø)` | |
   | [superset-frontend/src/chart/chartReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci5qcw==) | `24.24% <0.00%> (-20.21%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <ø> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <ø> (-100.00%)` | :arrow_down: |
   | [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `8.57% <ø> (-40.73%)` | :arrow_down: |
   | [...src/explore/components/controls/VizTypeControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC5qc3g=) | `72.72% <0.00%> (-19.59%)` | :arrow_down: |
   | [...et-frontend/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZXhwbG9yZVJlZHVjZXIuanM=) | `31.57% <0.00%> (-2.97%)` | :arrow_down: |
   | [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | `0.00% <0.00%> (-26.83%)` | :arrow_down: |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.54% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | ... and [173 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [865beae...2547086](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (7624937) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92fdf54aa34ed2edd5c85b5b47053bf4ce559517?el=desc) (92fdf54) will **decrease** coverage by `2.84%`.
   > The diff coverage is `70.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   66.71%   63.86%   -2.85%     
   ==========================================
     Files         967      484     -483     
     Lines       47543    29710   -17833     
     Branches     4650        0    -4650     
   ==========================================
   - Hits        31716    18975   -12741     
   + Misses      15706    10735    -4971     
   + Partials      121        0     -121     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.86% <70.45%> (-0.17%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.51% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.37% <100.00%> (-0.14%)` | :arrow_down: |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.07% <100.00%> (-0.53%)` | :arrow_down: |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | ... and [494 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [92fdf54...7624937](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (080675f) into [master](https://codecov.io/gh/apache/incubator-superset/commit/865beae3d8644bb5e9df156e5fea80c3ec0202a2?el=desc) (865beae) will **decrease** coverage by `2.92%`.
   > The diff coverage is `35.59%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   65.82%   62.89%   -2.93%     
   ==========================================
     Files         988      992       +4     
     Lines       48702    48812     +110     
     Branches     4907     4922      +15     
   ==========================================
   - Hits        32056    30701    -1355     
   - Misses      16501    17914    +1413     
   - Partials      145      197      +52     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `61.37% <27.16%> (-0.61%)` | :arrow_down: |
   | python | `63.87% <75.00%> (-0.33%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/addSlice/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FwcC50c3g=) | `0.00% <0.00%> (ø)` | |
   | [superset-frontend/src/chart/chartReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci5qcw==) | `24.24% <0.00%> (-20.21%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <ø> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <ø> (-100.00%)` | :arrow_down: |
   | [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `8.57% <ø> (-40.73%)` | :arrow_down: |
   | [...src/explore/components/controls/VizTypeControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC5qc3g=) | `72.72% <0.00%> (-19.59%)` | :arrow_down: |
   | [...et-frontend/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZXhwbG9yZVJlZHVjZXIuanM=) | `31.57% <0.00%> (-2.97%)` | :arrow_down: |
   | [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | `0.00% <0.00%> (-26.83%)` | :arrow_down: |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.54% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | ... and [175 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [865beae...080675f](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (286f804) into [master](https://codecov.io/gh/apache/incubator-superset/commit/49ec13c68c183b110b5c7ad18dfb829ce9f34245?el=desc) (49ec13c) will **decrease** coverage by `1.66%`.
   > The diff coverage is `70.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   65.86%   64.20%   -1.67%     
   ==========================================
     Files         972      484     -488     
     Lines       48051    29721   -18330     
     Branches     4716        0    -4716     
   ==========================================
   - Hits        31650    19081   -12569     
   + Misses      16259    10640    -5619     
   + Partials      142        0     -142     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `64.20% <70.45%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.51% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.50% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.59% <100.00%> (ø)` | |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | ... and [484 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [49ec13c...286f804](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] suddjian commented on a change in pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#discussion_r544928976



##########
File path: superset-frontend/src/components/DynamicPlugins/DynamicPluginProvider.tsx
##########
@@ -0,0 +1,181 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useReducer } from 'react';
+import { SupersetClient, JsonObject } from '@superset-ui/connection';
+import { isFeatureEnabled, FeatureFlag } from 'src/featureFlags';
+import {
+  PluginContext,
+  PluginContextType,
+  dummyPluginContext,
+} from './PluginContext';
+
+// the plugin returned from the API
+type Plugin = {
+  name: string;
+  key: string;
+  bundle_url: string;
+  id: number;
+};
+
+// TODO: Make this function an export of @superset-ui/chart or some such
+async function defineSharedModule(name: string, promise: Promise<any>) {
+  // dependency management using global variables, because for the life of me
+  // I can't figure out how to hook into UMD from a dynamically imported package.
+  // Maybe someone else can help figure that out.
+  const loadingKey = `__superset__loading__/${name}`;
+  const packageKey = `__superset__/${name}`;
+  if (window[loadingKey]) {
+    await window[loadingKey];
+    return window[packageKey];
+  }
+  window[loadingKey] = promise;
+  const pkg = await promise;
+  window[packageKey] = pkg;

Review comment:
       I actually cleaned up this logic a bit and moved it to superset-ui https://github.com/apache-superset/superset-ui/pull/871




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (5caac5d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/865beae3d8644bb5e9df156e5fea80c3ec0202a2?el=desc) (865beae) will **decrease** coverage by `2.20%`.
   > The diff coverage is `75.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   65.82%   63.61%   -2.21%     
   ==========================================
     Files         988      484     -504     
     Lines       48702    29744   -18958     
     Branches     4907        0    -4907     
   ==========================================
   - Hits        32056    18922   -13134     
   + Misses      16501    10822    -5679     
   + Partials      145        0     -145     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.61% <75.00%> (-0.59%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.54% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.36% <100.00%> (-0.15%)` | :arrow_down: |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.71% <100.00%> (ø)` | |
   | ... and [516 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [865beae...5caac5d](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] suddjian commented on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
suddjian commented on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-674546471


   Thanks for the offer @amitNielsen! I won't have a chance to get back on this until next week, but if we can address the CI errors I think it should be just about ready for review. Just needs one last pass to make sure that every part of the app knows how to wait for the async plugins.
   
    If you make some fixes I can merge your branch 🙂


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (5caac5d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/865beae3d8644bb5e9df156e5fea80c3ec0202a2?el=desc) (865beae) will **decrease** coverage by `2.53%`.
   > The diff coverage is `75.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   65.82%   63.29%   -2.54%     
   ==========================================
     Files         988      484     -504     
     Lines       48702    29744   -18958     
     Branches     4907        0    -4907     
   ==========================================
   - Hits        32056    18825   -13231     
   + Misses      16501    10919    -5582     
   + Partials      145        0     -145     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.29% <75.00%> (-0.92%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.54% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.23% <100.00%> (-0.28%)` | :arrow_down: |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.71% <100.00%> (ø)` | |
   | ... and [529 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [865beae...5caac5d](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (521dccf) into [master](https://codecov.io/gh/apache/incubator-superset/commit/865beae3d8644bb5e9df156e5fea80c3ec0202a2?el=desc) (865beae) will **decrease** coverage by `1.94%`.
   > The diff coverage is `75.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   65.82%   63.87%   -1.95%     
   ==========================================
     Files         988      484     -504     
     Lines       48702    29759   -18943     
     Branches     4907        0    -4907     
   ==========================================
   - Hits        32056    19008   -13048     
   + Misses      16501    10751    -5750     
   + Partials      145        0     -145     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.87% <75.00%> (-0.33%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.54% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.50% <100.00%> (ø)` | |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.71% <100.00%> (ø)` | |
   | ... and [501 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [865beae...7e637ab](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] suddjian commented on a change in pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#discussion_r546192207



##########
File path: superset-frontend/src/explore/controlUtils.js
##########
@@ -66,22 +66,25 @@ export function findControlItem(controlPanelSections, controlKey) {
   );
 }
 
-export const getControlConfig = memoizeOne(function getControlConfig(
-  controlKey,
-  vizType,
-) {
+const getMemoizedControlConfig = memoizeOne(
+  (controlKey, controlPanelConfig) => {
+    const {
+      controlOverrides = {},
+      controlPanelSections = [],
+    } = controlPanelConfig;
+
+    const control = expandControlConfig(
+      findControlItem(controlPanelSections, controlKey),
+      controlOverrides,
+    );
+    return control?.config || control;
+  },
+);
+
+export const getControlConfig = function getControlConfig(controlKey, vizType) {

Review comment:
       had to change where the memoization was happening, so that it calculates a new value when the plugin loads




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] villebro commented on a change in pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#discussion_r546236397



##########
File path: superset-frontend/spec/javascripts/explore/components/ExploreViewContainer_spec.jsx
##########
@@ -31,19 +28,23 @@ import ConnectedControlPanelsContainer from 'src/explore/components/ControlPanel
 import ChartContainer from 'src/explore/components/ExploreChartPanel';
 import * as featureFlags from 'src/featureFlags';
 
-describe('ExploreViewContainer', () => {
+// I added .skip to this entire suite because none of these tests
+// are actually testing particularly useful things,
+// and too many hacks were needed to get enzyme to play well with context.
+// Leaving it here in the hopes that someone can salvage this.
+describe.skip('ExploreViewContainer', () => {
   const middlewares = [thunk];
   const mockStore = configureStore(middlewares);
   let store;
   let wrapper;
   let isFeatureEnabledMock;
 
-  jest.spyOn(ReactAll, 'useContext').mockImplementation(() => {
-    return {
-      store,
-      subscription: new Subscription(store),
-    };
-  });
+  // jest.spyOn(ReactAll, 'useContext').mockImplementation(() => {
+  //   return {
+  //     store,
+  //     subscription: new Subscription(store),
+  //   };
+  // });

Review comment:
       nit: I prefer `/* */` for multi-line comments

##########
File path: superset/errors.py
##########
@@ -15,7 +15,7 @@
 # specific language governing permissions and limitations
 # under the License.
 # pylint: disable=too-few-public-methods,invalid-name
-from dataclasses import dataclass
+from dataclasses import dataclass  # pylint: disable=wrong-import-order

Review comment:
       What version of Python are you on? I'm guessing the ordering fails due to dataclasses being built-in on 3.7 but an addon in previous versions. But no need to fix here, I can clean this up later.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] suddjian edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
suddjian edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747847363


   I'd like plugins to declare a `superset-plugin.json` file, with info about versions, dependencies, icon, name, etc. This would open the door to do lots of good things with Superset. But this project has been on the back-burner since July and I'd rather merge it as-is and let people play with it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (521dccf) into [master](https://codecov.io/gh/apache/incubator-superset/commit/865beae3d8644bb5e9df156e5fea80c3ec0202a2?el=desc) (865beae) will **decrease** coverage by `2.17%`.
   > The diff coverage is `75.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   65.82%   63.64%   -2.18%     
   ==========================================
     Files         988      484     -504     
     Lines       48702    29759   -18943     
     Branches     4907        0    -4907     
   ==========================================
   - Hits        32056    18941   -13115     
   + Misses      16501    10818    -5683     
   + Partials      145        0     -145     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.64% <75.00%> (-0.56%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.54% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.37% <100.00%> (-0.14%)` | :arrow_down: |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.71% <100.00%> (ø)` | |
   | ... and [506 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [865beae...521dccf](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (680feb2) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92fdf54aa34ed2edd5c85b5b47053bf4ce559517?el=desc) (92fdf54) will **decrease** coverage by `2.71%`.
   > The diff coverage is `70.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   66.71%   63.99%   -2.72%     
   ==========================================
     Files         967      484     -483     
     Lines       47543    29710   -17833     
     Branches     4650        0    -4650     
   ==========================================
   - Hits        31716    19014   -12702     
   + Misses      15706    10696    -5010     
   + Partials      121        0     -121     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.99% <70.45%> (-0.04%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.51% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.37% <100.00%> (-0.14%)` | :arrow_down: |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.59% <100.00%> (ø)` | |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | ... and [486 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [92fdf54...7624937](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] suddjian commented on a change in pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#discussion_r546193371



##########
File path: superset-frontend/src/explore/components/ExploreViewContainer.jsx
##########
@@ -122,138 +127,110 @@ const Styles = styled.div`
   }
 `;
 
-class ExploreViewContainer extends React.Component {

Review comment:
       Converted this to a function component out of frustration with trying to change behavior. Didn't have the stamina to go all the way and convert it to typescript.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] suddjian edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
suddjian edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747847363


   I'd like plugins to declare a `superset-plugin.json` file, with info about versions, dependencies, icon, name, etc. This would open the door to do lots of good things with Superset. But this project has been on the back-burner since March and I'd rather merge it as-is and let people play with it, then improve things with a json manifest later.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] amitNielsen commented on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
amitNielsen commented on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-679143510


   @suddjian I tried solving the issue in the explore page where controlsPanel section / row is not re-rendering the exiting parameters of the query like group by and metrics.
   
   Can we maybe do some knowledge transfer on how what exactly should be done there and maybe do some refactoring in those areas
   
   you can also have a look at my PR that solves few of the issues already
   https://github.com/suddjian/incubator-superset/pull/2


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] amitNielsen commented on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
amitNielsen commented on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-683393471


   @suddjian  I suggest we also write an E2E cypress test for the explore page and dashboard page that loads a dynamic plugin stable
   
   currently with the https://github.com/apache-superset/dynamic-import-demo-plugin
   I can't say for certain that plugins work 100% , currently this plugin doesn't do the initial load currently 
   
   we should also stabalize the demo plugin to be aligned with the latest yeo generated plugin, which is what all community plugins are starting from


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (c5821c2) into [master](https://codecov.io/gh/apache/incubator-superset/commit/49ec13c68c183b110b5c7ad18dfb829ce9f34245?el=desc) (49ec13c) will **decrease** coverage by `2.86%`.
   > The diff coverage is `32.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   65.86%   62.99%   -2.87%     
   ==========================================
     Files         972      977       +5     
     Lines       48051    48174     +123     
     Branches     4716     4774      +58     
   ==========================================
   - Hits        31650    30349    -1301     
   - Misses      16259    17633    +1374     
   - Partials      142      192      +50     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `61.29% <25.71%> (-0.70%)` | :arrow_down: |
   | python | `64.05% <69.76%> (-0.16%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/addSlice/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FwcC50c3g=) | `0.00% <0.00%> (ø)` | |
   | [superset-frontend/src/chart/chartReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci5qcw==) | `24.24% <0.00%> (-20.21%)` | :arrow_down: |
   | [...omponents/DynamicPlugins/DynamicPluginProvider.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRHluYW1pY1BsdWdpbnMvRHluYW1pY1BsdWdpblByb3ZpZGVyLnRzeA==) | `0.00% <0.00%> (ø)` | |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <ø> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <ø> (-100.00%)` | :arrow_down: |
   | [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `8.57% <ø> (-40.73%)` | :arrow_down: |
   | [...src/explore/components/controls/VizTypeControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC5qc3g=) | `73.58% <0.00%> (-14.42%)` | :arrow_down: |
   | [...et-frontend/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZXhwbG9yZVJlZHVjZXIuanM=) | `31.57% <0.00%> (-2.97%)` | :arrow_down: |
   | [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | `0.00% <0.00%> (-26.83%)` | :arrow_down: |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.51% <ø> (ø)` | |
   | ... and [183 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [49ec13c...c5821c2](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (2547086) into [master](https://codecov.io/gh/apache/incubator-superset/commit/865beae3d8644bb5e9df156e5fea80c3ec0202a2?el=desc) (865beae) will **decrease** coverage by `2.71%`.
   > The diff coverage is `36.27%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   65.82%   63.10%   -2.72%     
   ==========================================
     Files         988      992       +4     
     Lines       48702    48812     +110     
     Branches     4907     4922      +15     
   ==========================================
   - Hits        32056    30805    -1251     
   - Misses      16501    17810    +1309     
   - Partials      145      197      +52     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `61.38% <27.98%> (-0.60%)` | :arrow_down: |
   | python | `64.21% <75.00%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/addSlice/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FwcC50c3g=) | `0.00% <0.00%> (ø)` | |
   | [superset-frontend/src/chart/chartReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci5qcw==) | `24.24% <0.00%> (-20.21%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <ø> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <ø> (-100.00%)` | :arrow_down: |
   | [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `8.57% <ø> (-40.73%)` | :arrow_down: |
   | [...src/explore/components/controls/VizTypeControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC5qc3g=) | `72.72% <0.00%> (-19.59%)` | :arrow_down: |
   | [...et-frontend/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZXhwbG9yZVJlZHVjZXIuanM=) | `31.57% <0.00%> (-2.97%)` | :arrow_down: |
   | [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | `0.00% <0.00%> (-26.83%)` | :arrow_down: |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.54% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | ... and [172 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [865beae...2547086](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (4f23ee6) into [master](https://codecov.io/gh/apache/incubator-superset/commit/865beae3d8644bb5e9df156e5fea80c3ec0202a2?el=desc) (865beae) will **decrease** coverage by `2.71%`.
   > The diff coverage is `36.27%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   65.82%   63.10%   -2.72%     
   ==========================================
     Files         988      992       +4     
     Lines       48702    48812     +110     
     Branches     4907     4922      +15     
   ==========================================
   - Hits        32056    30805    -1251     
   - Misses      16501    17810    +1309     
   - Partials      145      197      +52     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `61.38% <27.98%> (-0.60%)` | :arrow_down: |
   | python | `64.21% <75.00%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/addSlice/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FwcC50c3g=) | `0.00% <0.00%> (ø)` | |
   | [superset-frontend/src/chart/chartReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci5qcw==) | `24.24% <0.00%> (-20.21%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <ø> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <ø> (-100.00%)` | :arrow_down: |
   | [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `8.57% <ø> (-40.73%)` | :arrow_down: |
   | [...src/explore/components/controls/VizTypeControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC5qc3g=) | `72.72% <0.00%> (-19.59%)` | :arrow_down: |
   | [...et-frontend/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZXhwbG9yZVJlZHVjZXIuanM=) | `31.57% <0.00%> (-2.97%)` | :arrow_down: |
   | [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | `0.00% <0.00%> (-26.83%)` | :arrow_down: |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.54% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | ... and [172 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [865beae...4f23ee6](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (521dccf) into [master](https://codecov.io/gh/apache/incubator-superset/commit/865beae3d8644bb5e9df156e5fea80c3ec0202a2?el=desc) (865beae) will **decrease** coverage by `1.60%`.
   > The diff coverage is `75.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   65.82%   64.21%   -1.61%     
   ==========================================
     Files         988      484     -504     
     Lines       48702    29759   -18943     
     Branches     4907        0    -4907     
   ==========================================
   - Hits        32056    19110   -12946     
   + Misses      16501    10649    -5852     
   + Partials      145        0     -145     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `64.21% <75.00%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.54% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.50% <100.00%> (ø)` | |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.71% <100.00%> (ø)` | |
   | ... and [498 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [865beae...7e637ab](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (7624937) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92fdf54aa34ed2edd5c85b5b47053bf4ce559517?el=desc) (92fdf54) will **decrease** coverage by `2.70%`.
   > The diff coverage is `70.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   66.71%   64.00%   -2.71%     
   ==========================================
     Files         967      484     -483     
     Lines       47543    29710   -17833     
     Branches     4650        0    -4650     
   ==========================================
   - Hits        31716    19015   -12701     
   + Misses      15706    10695    -5011     
   + Partials      121        0     -121     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `64.00% <70.45%> (-0.04%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.51% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.37% <100.00%> (-0.14%)` | :arrow_down: |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.59% <100.00%> (ø)` | |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | ... and [485 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [92fdf54...7624937](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (680feb2) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92fdf54aa34ed2edd5c85b5b47053bf4ce559517?el=desc) (92fdf54) will **decrease** coverage by `2.56%`.
   > The diff coverage is `70.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   66.71%   64.14%   -2.57%     
   ==========================================
     Files         967      484     -483     
     Lines       47543    29710   -17833     
     Branches     4650        0    -4650     
   ==========================================
   - Hits        31716    19058   -12658     
   + Misses      15706    10652    -5054     
   + Partials      121        0     -121     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `64.14% <70.45%> (+0.11%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.51% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.50% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.59% <100.00%> (ø)` | |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | ... and [481 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [92fdf54...7624937](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] suddjian commented on a change in pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#discussion_r546280047



##########
File path: superset/errors.py
##########
@@ -15,7 +15,7 @@
 # specific language governing permissions and limitations
 # under the License.
 # pylint: disable=too-few-public-methods,invalid-name
-from dataclasses import dataclass
+from dataclasses import dataclass  # pylint: disable=wrong-import-order

Review comment:
       I'm on 3.7




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (5caac5d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/865beae3d8644bb5e9df156e5fea80c3ec0202a2?el=desc) (865beae) will **decrease** coverage by `2.71%`.
   > The diff coverage is `35.59%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   65.82%   63.10%   -2.72%     
   ==========================================
     Files         988      992       +4     
     Lines       48702    48812     +110     
     Branches     4907     4922      +15     
   ==========================================
   - Hits        32056    30803    -1253     
   - Misses      16501    17812    +1311     
   - Partials      145      197      +52     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `61.37% <27.16%> (-0.61%)` | :arrow_down: |
   | python | `64.21% <75.00%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/addSlice/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FwcC50c3g=) | `0.00% <0.00%> (ø)` | |
   | [superset-frontend/src/chart/chartReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci5qcw==) | `24.24% <0.00%> (-20.21%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <ø> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <ø> (-100.00%)` | :arrow_down: |
   | [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `8.57% <ø> (-40.73%)` | :arrow_down: |
   | [...src/explore/components/controls/VizTypeControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC5qc3g=) | `72.72% <0.00%> (-19.59%)` | :arrow_down: |
   | [...et-frontend/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZXhwbG9yZVJlZHVjZXIuanM=) | `31.57% <0.00%> (-2.97%)` | :arrow_down: |
   | [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | `0.00% <0.00%> (-26.83%)` | :arrow_down: |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.54% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | ... and [172 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [865beae...5caac5d](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (080675f) into [master](https://codecov.io/gh/apache/incubator-superset/commit/865beae3d8644bb5e9df156e5fea80c3ec0202a2?el=desc) (865beae) will **decrease** coverage by `2.71%`.
   > The diff coverage is `35.59%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   65.82%   63.10%   -2.72%     
   ==========================================
     Files         988      992       +4     
     Lines       48702    48812     +110     
     Branches     4907     4922      +15     
   ==========================================
   - Hits        32056    30803    -1253     
   - Misses      16501    17812    +1311     
   - Partials      145      197      +52     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `61.37% <27.16%> (-0.61%)` | :arrow_down: |
   | python | `64.21% <75.00%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/addSlice/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FwcC50c3g=) | `0.00% <0.00%> (ø)` | |
   | [superset-frontend/src/chart/chartReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci5qcw==) | `24.24% <0.00%> (-20.21%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <ø> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <ø> (-100.00%)` | :arrow_down: |
   | [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `8.57% <ø> (-40.73%)` | :arrow_down: |
   | [...src/explore/components/controls/VizTypeControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC5qc3g=) | `72.72% <0.00%> (-19.59%)` | :arrow_down: |
   | [...et-frontend/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZXhwbG9yZVJlZHVjZXIuanM=) | `31.57% <0.00%> (-2.97%)` | :arrow_down: |
   | [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | `0.00% <0.00%> (-26.83%)` | :arrow_down: |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.54% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | ... and [172 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [865beae...080675f](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] lozbrown commented on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
lozbrown commented on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-736521587


   > This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue.
   
   Really bot, no! this would be super useful


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter commented on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-682254000


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c715cad48ea16bb616c9db174e30ea3f5af39fc7?el=desc) will **decrease** coverage by `6.04%`.
   > The diff coverage is `63.73%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   64.76%   58.71%   -6.05%     
   ==========================================
     Files         789      762      -27     
     Lines       37091    36106     -985     
     Branches     3555     3315     -240     
   ==========================================
   - Hits        24021    21200    -2821     
   - Misses      12963    14720    +1757     
   - Partials      107      186      +79     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `55.94% <63.15%> (+0.32%)` | :arrow_up: |
   | #javascript | `?` | |
   | #python | `60.25% <67.56%> (+0.22%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/chart/chartReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci5qcw==) | `62.50% <0.00%> (-6.36%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...et-frontend/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZXhwbG9yZVJlZHVjZXIuanM=) | `42.62% <0.00%> (-4.84%)` | :arrow_down: |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [...omponents/DynamicPlugins/DynamicPluginProvider.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRHluYW1pY1BsdWdpbnMvRHluYW1pY1BsdWdpblByb3ZpZGVyLnRzeA==) | `10.41% <10.41%> (ø)` | |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `65.21% <40.00%> (-8.53%)` | :arrow_down: |
   | [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `32.35% <42.85%> (-56.84%)` | :arrow_down: |
   | ... and [281 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [c715cad...d8b2b0a](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (680feb2) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92fdf54aa34ed2edd5c85b5b47053bf4ce559517?el=desc) (92fdf54) will **decrease** coverage by `3.11%`.
   > The diff coverage is `70.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   66.71%   63.59%   -3.12%     
   ==========================================
     Files         967      484     -483     
     Lines       47543    29710   -17833     
     Branches     4650        0    -4650     
   ==========================================
   - Hits        31716    18893   -12823     
   + Misses      15706    10817    -4889     
   + Partials      121        0     -121     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.59% <70.45%> (-0.45%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.51% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.37% <100.00%> (-0.14%)` | :arrow_down: |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.59% <100.00%> (ø)` | |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | ... and [488 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [92fdf54...7624937](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (286f804) into [master](https://codecov.io/gh/apache/incubator-superset/commit/49ec13c68c183b110b5c7ad18dfb829ce9f34245?el=desc) (49ec13c) will **decrease** coverage by `1.65%`.
   > The diff coverage is `70.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   65.86%   64.21%   -1.66%     
   ==========================================
     Files         972      484     -488     
     Lines       48051    29721   -18330     
     Branches     4716        0    -4716     
   ==========================================
   - Hits        31650    19084   -12566     
   + Misses      16259    10637    -5622     
   + Partials      142        0     -142     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `64.21% <70.45%> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.51% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.50% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.59% <100.00%> (ø)` | |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | ... and [483 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [49ec13c...286f804](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (7624937) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92fdf54aa34ed2edd5c85b5b47053bf4ce559517?el=desc) (92fdf54) will **decrease** coverage by `3.31%`.
   > The diff coverage is `70.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   66.71%   63.39%   -3.32%     
   ==========================================
     Files         967      484     -483     
     Lines       47543    29710   -17833     
     Branches     4650        0    -4650     
   ==========================================
   - Hits        31716    18834   -12882     
   + Misses      15706    10876    -4830     
   + Partials      121        0     -121     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.39% <70.45%> (-0.65%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.51% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.11% <100.00%> (-0.40%)` | :arrow_down: |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `80.73% <100.00%> (-6.87%)` | :arrow_down: |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | ... and [502 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [92fdf54...7624937](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] suddjian commented on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
suddjian commented on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-684058017


   A cypress test sounds like a good idea to me.
   
   I have the example plugin working locally, maybe I can help there?
   
   I think dynamic plugins in the long run will have a different set of requirements than static plugins. I'm thinking about adding some kind of `manifest` json file to specify the plugin name, thumbnail, and main module. That would allow the backend to inspect plugin info without loading the plugin in a js environment. We could build these things into the yeoman generator, but I think for now this should be considered a very experimental feature and the interface is subject to change.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (680feb2) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92fdf54aa34ed2edd5c85b5b47053bf4ce559517?el=desc) (92fdf54) will **decrease** coverage by `3.17%`.
   > The diff coverage is `70.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   66.71%   63.53%   -3.18%     
   ==========================================
     Files         967      484     -483     
     Lines       47543    29710   -17833     
     Branches     4650        0    -4650     
   ==========================================
   - Hits        31716    18877   -12839     
   + Misses      15706    10833    -4873     
   + Partials      121        0     -121     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.53% <70.45%> (-0.50%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.51% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.24% <100.00%> (-0.27%)` | :arrow_down: |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.59% <100.00%> (ø)` | |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | ... and [490 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [92fdf54...7624937](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (286f804) into [master](https://codecov.io/gh/apache/incubator-superset/commit/49ec13c68c183b110b5c7ad18dfb829ce9f34245?el=desc) (49ec13c) will **decrease** coverage by `2.25%`.
   > The diff coverage is `70.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   65.86%   63.61%   -2.26%     
   ==========================================
     Files         972      484     -488     
     Lines       48051    29721   -18330     
     Branches     4716        0    -4716     
   ==========================================
   - Hits        31650    18906   -12744     
   + Misses      16259    10815    -5444     
   + Partials      142        0     -142     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.61% <70.45%> (-0.60%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.51% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.11% <100.00%> (-0.40%)` | :arrow_down: |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.07% <100.00%> (-0.53%)` | :arrow_down: |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | ... and [495 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [49ec13c...286f804](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] suddjian commented on a change in pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#discussion_r546192236



##########
File path: superset-frontend/src/explore/controlUtils.js
##########
@@ -167,53 +170,59 @@ export function getControlState(controlKey, vizType, state, value) {
   );
 }
 
+const getMemoizedSectionsToRender = memoizeOne(

Review comment:
       same here




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] suddjian commented on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
suddjian commented on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747847363


   I'd like plugins to declare a `superset-plugin.json` file, with info about versions, dependencies, icon, name, etc. But this has been on the back-burner since March and I'd rather merge it as-is and let people play with it, then improve things with a json manifest later.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] suddjian commented on a change in pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#discussion_r546192820



##########
File path: superset-frontend/src/explore/store.js
##########
@@ -69,13 +69,15 @@ export function applyDefaultFormData(inputFormData) {
   const controlFormData = getFormDataFromControls(controlsState);
 
   const formData = {};
-  Object.keys(controlsState).forEach(controlName => {
-    if (inputFormData[controlName] === undefined) {
-      formData[controlName] = controlFormData[controlName];
-    } else {
-      formData[controlName] = inputFormData[controlName];
-    }
-  });
+  Object.keys(controlsState)
+    .concat(Object.keys(inputFormData))

Review comment:
       Dynamically imported plugins don't have any controls state available until after the plugin has loaded. This change makes it so that we use the fields from the chart's form data instead of only using the controls.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (c5821c2) into [master](https://codecov.io/gh/apache/incubator-superset/commit/49ec13c68c183b110b5c7ad18dfb829ce9f34245?el=desc) (49ec13c) will **decrease** coverage by `2.57%`.
   > The diff coverage is `69.76%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   65.86%   63.29%   -2.58%     
   ==========================================
     Files         972      484     -488     
     Lines       48051    29706   -18345     
     Branches     4716        0    -4716     
   ==========================================
   - Hits        31650    18801   -12849     
   + Misses      16259    10905    -5354     
   + Partials      142        0     -142     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.29% <69.76%> (-0.92%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.51% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.23% <100.00%> (-0.28%)` | :arrow_down: |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.33% <100.00%> (-0.01%)` | :arrow_down: |
   | ... and [512 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [49ec13c...c5821c2](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] suddjian commented on a change in pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#discussion_r544930426



##########
File path: superset-frontend/src/components/DynamicPlugins/DynamicPluginProvider.tsx
##########
@@ -0,0 +1,181 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useReducer } from 'react';
+import { SupersetClient, JsonObject } from '@superset-ui/connection';
+import { isFeatureEnabled, FeatureFlag } from 'src/featureFlags';
+import {
+  PluginContext,
+  PluginContextType,
+  dummyPluginContext,
+} from './PluginContext';
+
+// the plugin returned from the API
+type Plugin = {
+  name: string;
+  key: string;
+  bundle_url: string;
+  id: number;
+};
+
+// TODO: Make this function an export of @superset-ui/chart or some such
+async function defineSharedModule(name: string, promise: Promise<any>) {
+  // dependency management using global variables, because for the life of me
+  // I can't figure out how to hook into UMD from a dynamically imported package.
+  // Maybe someone else can help figure that out.
+  const loadingKey = `__superset__loading__/${name}`;
+  const packageKey = `__superset__/${name}`;
+  if (window[loadingKey]) {
+    await window[loadingKey];
+    return window[packageKey];
+  }
+  window[loadingKey] = promise;
+  const pkg = await promise;
+  window[packageKey] = pkg;
+  return pkg;
+}
+
+async function defineSharedModules(moduleMap: { [key: string]: Promise<any> }) {
+  return Promise.all(
+    Object.entries(moduleMap).map(([name, promise]) => {
+      defineSharedModule(name, promise);
+      return promise;
+    }),
+  );
+}
+
+type CompleteAction = {
+  type: 'complete';
+  key: string;
+  error: null | Error;
+};
+
+type BeginAction = {
+  type: 'begin';
+  keys: string[];
+};
+
+function pluginContextReducer(
+  state: PluginContextType,
+  action: BeginAction | CompleteAction,
+): PluginContextType {
+  switch (action.type) {
+    case 'begin': {
+      const plugins = { ...state.plugins };
+      for (const key of action.keys) {
+        plugins[key] = { key, error: null, loading: true };
+      }
+      return {
+        ...state,
+        loading: true,
+        plugins,
+      };
+    }
+    case 'complete': {
+      return {
+        ...state,
+        loading: Object.values(state.plugins).some(
+          plugin => plugin.loading && plugin.key !== action.key,
+        ),
+        plugins: {
+          ...state.plugins,
+          [action.key]: {
+            key: action.key,
+            loading: false,
+            error: action.error,
+          },
+        },
+      };
+    }
+    default:
+      return state;
+  }
+}
+
+export type Props = React.PropsWithChildren<{}>;
+
+export default function DynamicPluginProvider({ children }: Props) {
+  const [pluginState, dispatch] = useReducer(pluginContextReducer, {
+    // use the dummy plugin context, and override the methods
+    ...dummyPluginContext,
+    // eslint-disable-next-line @typescript-eslint/no-use-before-define
+    fetchAll,
+    loading: isFeatureEnabled(FeatureFlag.DYNAMIC_PLUGINS),
+    // TODO: Write fetchByKeys
+  });
+
+  async function fetchAll() {
+    try {
+      await defineSharedModules({
+        react: import('react'),
+        lodash: import('lodash'),
+        'react-dom': import('react-dom'),
+        '@superset-ui/chart': import('@superset-ui/chart'),
+        '@superset-ui/chart-controls': import('@superset-ui/chart-controls'),
+        '@superset-ui/connection': import('@superset-ui/connection'),
+        '@superset-ui/color': import('@superset-ui/color'),
+        '@superset-ui/core': import('@superset-ui/core'),
+        '@superset-ui/dimension': import('@superset-ui/dimension'),
+        '@superset-ui/query': import('@superset-ui/query'),
+        '@superset-ui/style': import('@superset-ui/style'),
+        '@superset-ui/translation': import('@superset-ui/translation'),
+        '@superset-ui/validator': import('@superset-ui/validator'),
+      });

Review comment:
       I would like to do loading on demand, but the way I got the example plugin's webpack to work is it references global variables on the `window`. I intend to define a `superset-plugin.json` manifest file for dynamic plugins in the future, which would be a good place to put dependency info. For now I'd like to keep this minimal.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (32ecf2d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92fdf54aa34ed2edd5c85b5b47053bf4ce559517?el=desc) (92fdf54) will **decrease** coverage by `3.47%`.
   > The diff coverage is `70.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   66.71%   63.23%   -3.48%     
   ==========================================
     Files         967      484     -483     
     Lines       47543    29695   -17848     
     Branches     4650        0    -4650     
   ==========================================
   - Hits        31716    18778   -12938     
   + Misses      15706    10917    -4789     
   + Partials      121        0     -121     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.23% <70.45%> (-0.81%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.51% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.23% <100.00%> (-0.28%)` | :arrow_down: |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.07% <100.00%> (-0.53%)` | :arrow_down: |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | ... and [511 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [92fdf54...7624937](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-682254000


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c715cad48ea16bb616c9db174e30ea3f5af39fc7?el=desc) will **decrease** coverage by `6.16%`.
   > The diff coverage is `64.26%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   64.76%   58.59%   -6.17%     
   ==========================================
     Files         789      762      -27     
     Lines       37091    36142     -949     
     Branches     3555     3315     -240     
   ==========================================
   - Hits        24021    21177    -2844     
   - Misses      12963    14774    +1811     
   - Partials      107      191      +84     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `55.52% <63.00%> (-0.10%)` | :arrow_down: |
   | #javascript | `?` | |
   | #python | `60.29% <71.11%> (+0.26%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/chart/chartReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci5qcw==) | `62.50% <0.00%> (-6.36%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...et-frontend/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZXhwbG9yZVJlZHVjZXIuanM=) | `42.62% <0.00%> (-4.84%)` | :arrow_down: |
   | [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | `100.00% <ø> (+42.10%)` | :arrow_up: |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [...omponents/DynamicPlugins/DynamicPluginProvider.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRHluYW1pY1BsdWdpbnMvRHluYW1pY1BsdWdpblByb3ZpZGVyLnRzeA==) | `10.41% <10.41%> (ø)` | |
   | ... and [300 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [c715cad...2cf793f](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] suddjian edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
suddjian edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747847363


   I'd like plugins to declare a `superset-plugin.json` file, with info about versions, dependencies, icon, name, etc. This would open the door to do lots of good things with Superset. But this project has been on the back-burner since July and I'd rather merge it as-is and let people play with it, then improve things with a json manifest later.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] rusackas commented on a change in pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#discussion_r545650844



##########
File path: superset-frontend/src/components/DynamicPlugins/DynamicPluginProvider.tsx
##########
@@ -0,0 +1,157 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useReducer } from 'react';
+import { defineSharedModules, SupersetClient } from '@superset-ui/core';
+import { FeatureFlag, isFeatureEnabled } from 'src/featureFlags';
+import {
+  dummyPluginContext,
+  PluginContext,
+  PluginContextType,
+} from './PluginContext';
+
+// the plugin returned from the API
+type Plugin = {
+  name: string;
+  key: string;
+  bundle_url: string;
+  id: number;
+};
+
+type CompleteAction = {
+  type: 'complete';
+  key: string;
+  error: null | Error;
+};
+
+type BeginAction = {
+  type: 'begin';
+  keys: string[];
+};
+
+function pluginContextReducer(
+  state: PluginContextType,
+  action: BeginAction | CompleteAction,
+): PluginContextType {
+  switch (action.type) {
+    case 'begin': {
+      const plugins = { ...state.plugins };
+      action.keys.forEach(key => {
+        plugins[key] = { key, error: null, loading: true };
+      });
+      return {
+        ...state,
+        loading: true,
+        plugins,
+      };
+    }
+    case 'complete': {
+      return {
+        ...state,
+        loading: Object.values(state.plugins).some(
+          plugin => plugin.loading && plugin.key !== action.key,
+        ),
+        plugins: {
+          ...state.plugins,
+          [action.key]: {
+            key: action.key,
+            loading: false,
+            error: action.error,
+          },
+        },
+      };
+    }
+    default:
+      return state;
+  }
+}
+
+export type Props = React.PropsWithChildren<{}>;
+
+const sharedModules = {
+  react: () => import('react'),
+  lodash: () => import('lodash'),
+  'react-dom': () => import('react-dom'),
+  '@superset-ui/chart-controls': () => import('@superset-ui/chart-controls'),
+  '@superset-ui/core': () => import('@superset-ui/core'),
+};
+
+export default function DynamicPluginProvider({ children }: Props) {
+  const [pluginState, dispatch] = useReducer(pluginContextReducer, {
+    // use the dummy plugin context, and override the methods
+    ...dummyPluginContext,
+    // eslint-disable-next-line @typescript-eslint/no-use-before-define
+    fetchAll,
+    loading: isFeatureEnabled(FeatureFlag.DYNAMIC_PLUGINS),
+    // TODO: Write fetchByKeys
+  });
+
+  async function fetchAll() {
+    try {
+      await defineSharedModules(sharedModules);
+      const response = await SupersetClient.get({
+        endpoint: '/dynamic-plugins/api/read',
+      });
+      const plugins: Plugin[] = response.json.result;
+      // const plugins: Plugin[] = [
+      //   {
+      //     name: 'Hello World',
+      //     key: 'superset-chart-hello-world',
+      //     id: 0,
+      //     bundle_url: 'http://127.0.0.1:8080/main.js',
+      //   },
+      // ];
+      dispatch({ type: 'begin', keys: plugins.map(plugin => plugin.key) });
+      await Promise.all(
+        plugins.map(async plugin => {
+          let error: Error | null = null;
+          try {
+            await import(/* webpackIgnore: true */ plugin.bundle_url);
+          } catch (err) {
+            // eslint-disable-next-line no-console
+            console.error(
+              `Failed to load plugin ${plugin.key} with the following error:`,
+              err.stack,
+            );
+            error = err;
+          }
+          dispatch({
+            type: 'complete',
+            key: plugin.key,
+            error,
+          });
+        }),
+      );
+    } catch (error) {
+      // eslint-disable-next-line no-console
+      console.error(error.stack || error);

Review comment:
       You can `import { logging } from '@superset-ui/core';` and use it as `logging.error(stuff)` and get rid of the `eslint-disable`
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (5caac5d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/865beae3d8644bb5e9df156e5fea80c3ec0202a2?el=desc) (865beae) will **decrease** coverage by `2.17%`.
   > The diff coverage is `75.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   65.82%   63.64%   -2.18%     
   ==========================================
     Files         988      484     -504     
     Lines       48702    29759   -18943     
     Branches     4907        0    -4907     
   ==========================================
   - Hits        32056    18941   -13115     
   + Misses      16501    10818    -5683     
   + Partials      145        0     -145     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.64% <75.00%> (-0.56%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.54% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.37% <100.00%> (-0.14%)` | :arrow_down: |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.71% <100.00%> (ø)` | |
   | ... and [506 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [865beae...5caac5d](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (5caac5d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/865beae3d8644bb5e9df156e5fea80c3ec0202a2?el=desc) (865beae) will **decrease** coverage by `1.94%`.
   > The diff coverage is `75.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   65.82%   63.87%   -1.95%     
   ==========================================
     Files         988      484     -504     
     Lines       48702    29759   -18943     
     Branches     4907        0    -4907     
   ==========================================
   - Hits        32056    19008   -13048     
   + Misses      16501    10751    -5750     
   + Partials      145        0     -145     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.87% <75.00%> (-0.33%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.54% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.50% <100.00%> (ø)` | |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.71% <100.00%> (ø)` | |
   | ... and [501 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [865beae...5caac5d](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (080675f) into [master](https://codecov.io/gh/apache/incubator-superset/commit/865beae3d8644bb5e9df156e5fea80c3ec0202a2?el=desc) (865beae) will **decrease** coverage by `3.06%`.
   > The diff coverage is `35.59%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   65.82%   62.75%   -3.07%     
   ==========================================
     Files         988      992       +4     
     Lines       48702    48812     +110     
     Branches     4907     4922      +15     
   ==========================================
   - Hits        32056    30634    -1422     
   - Misses      16501    17981    +1480     
   - Partials      145      197      +52     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `61.37% <27.16%> (-0.61%)` | :arrow_down: |
   | python | `63.64% <75.00%> (-0.56%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/addSlice/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FwcC50c3g=) | `0.00% <0.00%> (ø)` | |
   | [superset-frontend/src/chart/chartReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci5qcw==) | `24.24% <0.00%> (-20.21%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <ø> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <ø> (-100.00%)` | :arrow_down: |
   | [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `8.57% <ø> (-40.73%)` | :arrow_down: |
   | [...src/explore/components/controls/VizTypeControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC5qc3g=) | `72.72% <0.00%> (-19.59%)` | :arrow_down: |
   | [...et-frontend/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZXhwbG9yZVJlZHVjZXIuanM=) | `31.57% <0.00%> (-2.97%)` | :arrow_down: |
   | [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | `0.00% <0.00%> (-26.83%)` | :arrow_down: |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.54% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | ... and [180 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [865beae...080675f](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (e9b88ca) into [master](https://codecov.io/gh/apache/incubator-superset/commit/49ec13c68c183b110b5c7ad18dfb829ce9f34245?el=desc) (49ec13c) will **decrease** coverage by `1.98%`.
   > The diff coverage is `69.76%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   65.86%   63.88%   -1.99%     
   ==========================================
     Files         972      484     -488     
     Lines       48051    29719   -18332     
     Branches     4716        0    -4716     
   ==========================================
   - Hits        31650    18985   -12665     
   + Misses      16259    10734    -5525     
   + Partials      142        0     -142     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.88% <69.76%> (-0.33%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.51% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.24% <100.00%> (-0.27%)` | :arrow_down: |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.34% <100.00%> (ø)` | |
   | ... and [500 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [49ec13c...e9b88ca](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (4f23ee6) into [master](https://codecov.io/gh/apache/incubator-superset/commit/865beae3d8644bb5e9df156e5fea80c3ec0202a2?el=desc) (865beae) will **decrease** coverage by `2.26%`.
   > The diff coverage is `75.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   65.82%   63.55%   -2.27%     
   ==========================================
     Files         988      484     -504     
     Lines       48702    29757   -18945     
     Branches     4907        0    -4907     
   ==========================================
   - Hits        32056    18913   -13143     
   + Misses      16501    10844    -5657     
   + Partials      145        0     -145     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.55% <75.00%> (-0.65%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.54% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.98% <100.00%> (-0.53%)` | :arrow_down: |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.71% <100.00%> (ø)` | |
   | ... and [513 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [865beae...4f23ee6](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io commented on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (680feb2) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92fdf54aa34ed2edd5c85b5b47053bf4ce559517?el=desc) (92fdf54) will **decrease** coverage by `3.47%`.
   > The diff coverage is `70.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   66.71%   63.23%   -3.48%     
   ==========================================
     Files         967      484     -483     
     Lines       47543    29695   -17848     
     Branches     4650        0    -4650     
   ==========================================
   - Hits        31716    18778   -12938     
   + Misses      15706    10917    -4789     
   + Partials      121        0     -121     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.23% <70.45%> (-0.81%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.51% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.23% <100.00%> (-0.28%)` | :arrow_down: |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.07% <100.00%> (-0.53%)` | :arrow_down: |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | ... and [511 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [92fdf54...7624937](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (286f804) into [master](https://codecov.io/gh/apache/incubator-superset/commit/49ec13c68c183b110b5c7ad18dfb829ce9f34245?el=desc) (49ec13c) will **decrease** coverage by `2.22%`.
   > The diff coverage is `70.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   65.86%   63.64%   -2.23%     
   ==========================================
     Files         972      484     -488     
     Lines       48051    29721   -18330     
     Branches     4716        0    -4716     
   ==========================================
   - Hits        31650    18916   -12734     
   + Misses      16259    10805    -5454     
   + Partials      142        0     -142     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.64% <70.45%> (-0.57%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.51% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.37% <100.00%> (-0.14%)` | :arrow_down: |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.59% <100.00%> (ø)` | |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | ... and [491 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [49ec13c...286f804](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] amitNielsen edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
amitNielsen edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-683288270


   @suddjian I've fix the pre-commit issues for re configuring 3rd party and then re running sort 
   for some reason I can't pull request to your repo as last time 🤔 
   
   here is my branch with the fix : https://github.com/amitnielsen/incubator-superset/tree/dynamic-plugin-import
   
   ================ update =================
   I've also removed a depracted test
   added Loading component instead of '...loading'


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (32ecf2d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92fdf54aa34ed2edd5c85b5b47053bf4ce559517?el=desc) (92fdf54) will **decrease** coverage by `3.14%`.
   > The diff coverage is `70.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   66.71%   63.56%   -3.15%     
   ==========================================
     Files         967      484     -483     
     Lines       47543    29695   -17848     
     Branches     4650        0    -4650     
   ==========================================
   - Hits        31716    18875   -12841     
   + Misses      15706    10820    -4886     
   + Partials      121        0     -121     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.56% <70.45%> (-0.48%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.51% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.36% <100.00%> (-0.15%)` | :arrow_down: |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.59% <100.00%> (ø)` | |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | ... and [498 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [92fdf54...7624937](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (32ecf2d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92fdf54aa34ed2edd5c85b5b47053bf4ce559517?el=desc) (92fdf54) will **decrease** coverage by `3.11%`.
   > The diff coverage is `70.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   66.71%   63.59%   -3.12%     
   ==========================================
     Files         967      484     -483     
     Lines       47543    29710   -17833     
     Branches     4650        0    -4650     
   ==========================================
   - Hits        31716    18893   -12823     
   + Misses      15706    10817    -4889     
   + Partials      121        0     -121     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.59% <70.45%> (-0.45%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.51% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.37% <100.00%> (-0.14%)` | :arrow_down: |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.59% <100.00%> (ø)` | |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | ... and [488 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [92fdf54...7624937](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] suddjian commented on a change in pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#discussion_r544931621



##########
File path: superset-frontend/src/components/DynamicPlugins/DynamicPluginProvider.tsx
##########
@@ -0,0 +1,181 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useReducer } from 'react';
+import { SupersetClient, JsonObject } from '@superset-ui/connection';
+import { isFeatureEnabled, FeatureFlag } from 'src/featureFlags';
+import {
+  PluginContext,
+  PluginContextType,
+  dummyPluginContext,
+} from './PluginContext';
+
+// the plugin returned from the API
+type Plugin = {
+  name: string;
+  key: string;
+  bundle_url: string;
+  id: number;
+};
+
+// TODO: Make this function an export of @superset-ui/chart or some such
+async function defineSharedModule(name: string, promise: Promise<any>) {
+  // dependency management using global variables, because for the life of me
+  // I can't figure out how to hook into UMD from a dynamically imported package.
+  // Maybe someone else can help figure that out.
+  const loadingKey = `__superset__loading__/${name}`;
+  const packageKey = `__superset__/${name}`;
+  if (window[loadingKey]) {
+    await window[loadingKey];
+    return window[packageKey];
+  }
+  window[loadingKey] = promise;
+  const pkg = await promise;
+  window[packageKey] = pkg;
+  return pkg;
+}
+
+async function defineSharedModules(moduleMap: { [key: string]: Promise<any> }) {
+  return Promise.all(
+    Object.entries(moduleMap).map(([name, promise]) => {
+      defineSharedModule(name, promise);
+      return promise;
+    }),
+  );
+}
+
+type CompleteAction = {
+  type: 'complete';
+  key: string;
+  error: null | Error;
+};
+
+type BeginAction = {
+  type: 'begin';
+  keys: string[];
+};
+
+function pluginContextReducer(
+  state: PluginContextType,
+  action: BeginAction | CompleteAction,
+): PluginContextType {
+  switch (action.type) {
+    case 'begin': {
+      const plugins = { ...state.plugins };
+      for (const key of action.keys) {
+        plugins[key] = { key, error: null, loading: true };
+      }
+      return {
+        ...state,
+        loading: true,
+        plugins,
+      };
+    }
+    case 'complete': {
+      return {
+        ...state,
+        loading: Object.values(state.plugins).some(
+          plugin => plugin.loading && plugin.key !== action.key,
+        ),
+        plugins: {
+          ...state.plugins,
+          [action.key]: {
+            key: action.key,
+            loading: false,
+            error: action.error,
+          },
+        },
+      };
+    }
+    default:
+      return state;
+  }
+}
+
+export type Props = React.PropsWithChildren<{}>;
+
+export default function DynamicPluginProvider({ children }: Props) {
+  const [pluginState, dispatch] = useReducer(pluginContextReducer, {
+    // use the dummy plugin context, and override the methods
+    ...dummyPluginContext,
+    // eslint-disable-next-line @typescript-eslint/no-use-before-define
+    fetchAll,
+    loading: isFeatureEnabled(FeatureFlag.DYNAMIC_PLUGINS),
+    // TODO: Write fetchByKeys
+  });
+
+  async function fetchAll() {
+    try {
+      await defineSharedModules({
+        react: import('react'),
+        lodash: import('lodash'),
+        'react-dom': import('react-dom'),
+        '@superset-ui/chart': import('@superset-ui/chart'),
+        '@superset-ui/chart-controls': import('@superset-ui/chart-controls'),
+        '@superset-ui/connection': import('@superset-ui/connection'),
+        '@superset-ui/color': import('@superset-ui/color'),
+        '@superset-ui/core': import('@superset-ui/core'),
+        '@superset-ui/dimension': import('@superset-ui/dimension'),
+        '@superset-ui/query': import('@superset-ui/query'),
+        '@superset-ui/style': import('@superset-ui/style'),
+        '@superset-ui/translation': import('@superset-ui/translation'),
+        '@superset-ui/validator': import('@superset-ui/validator'),
+      });

Review comment:
       This design is also not ideal for third-party plugins that may want to add libraries for other plugins to depend on. Definitely should be improved.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (286f804) into [master](https://codecov.io/gh/apache/incubator-superset/commit/49ec13c68c183b110b5c7ad18dfb829ce9f34245?el=desc) (49ec13c) will **decrease** coverage by `1.67%`.
   > The diff coverage is `70.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   65.86%   64.19%   -1.68%     
   ==========================================
     Files         972      484     -488     
     Lines       48051    29721   -18330     
     Branches     4716        0    -4716     
   ==========================================
   - Hits        31650    19080   -12570     
   + Misses      16259    10641    -5618     
   + Partials      142        0     -142     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `64.19% <70.45%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.51% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.50% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.59% <100.00%> (ø)` | |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | ... and [485 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [49ec13c...286f804](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] junlincc merged pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
junlincc merged pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] betodealmeida commented on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
betodealmeida commented on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-749727425


   Migration is failing on MySQL with:
   
   ```
   sqlalchemy.exc.OperationalError: (MySQLdb._exceptions.OperationalError) (1071, 'Specified key was too long; max key length is 3072 bytes')
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (32ecf2d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92fdf54aa34ed2edd5c85b5b47053bf4ce559517?el=desc) (92fdf54) will **decrease** coverage by `2.55%`.
   > The diff coverage is `70.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   66.71%   64.15%   -2.56%     
   ==========================================
     Files         967      484     -483     
     Lines       47543    29710   -17833     
     Branches     4650        0    -4650     
   ==========================================
   - Hits        31716    19061   -12655     
   + Misses      15706    10649    -5057     
   + Partials      121        0     -121     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `64.15% <70.45%> (+0.12%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.51% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.50% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.59% <100.00%> (ø)` | |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | ... and [480 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [92fdf54...7624937](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (680feb2) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92fdf54aa34ed2edd5c85b5b47053bf4ce559517?el=desc) (92fdf54) will **decrease** coverage by `2.70%`.
   > The diff coverage is `70.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   66.71%   64.00%   -2.71%     
   ==========================================
     Files         967      484     -483     
     Lines       47543    29710   -17833     
     Branches     4650        0    -4650     
   ==========================================
   - Hits        31716    19015   -12701     
   + Misses      15706    10695    -5011     
   + Partials      121        0     -121     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `64.00% <70.45%> (-0.04%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.51% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.37% <100.00%> (-0.14%)` | :arrow_down: |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.59% <100.00%> (ø)` | |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | ... and [485 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [92fdf54...7624937](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] suddjian commented on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
suddjian commented on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-749797635


   @betodealmeida That's very strange... Any idea why? It passed CI.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] ktmud commented on a change in pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#discussion_r483117076



##########
File path: superset-frontend/src/explore/App.jsx
##########
@@ -33,10 +34,12 @@ setupPlugins();
 const App = ({ store }) => (
   <Provider store={store}>
     <ThemeProvider theme={supersetTheme}>
-      <>
-        <ExploreViewContainer />
-        <ToastPresenter />
-      </>
+      <DynamicPluginProvider>
+        <>

Review comment:
       The fragment wrap is probably not needed.

##########
File path: superset-frontend/src/components/DynamicPlugins/DynamicPluginProvider.tsx
##########
@@ -0,0 +1,181 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useReducer } from 'react';
+import { SupersetClient, JsonObject } from '@superset-ui/connection';
+import { isFeatureEnabled, FeatureFlag } from 'src/featureFlags';
+import {
+  PluginContext,
+  PluginContextType,
+  dummyPluginContext,
+} from './PluginContext';
+
+// the plugin returned from the API
+type Plugin = {
+  name: string;
+  key: string;
+  bundle_url: string;
+  id: number;
+};
+
+// TODO: Make this function an export of @superset-ui/chart or some such
+async function defineSharedModule(name: string, promise: Promise<any>) {
+  // dependency management using global variables, because for the life of me
+  // I can't figure out how to hook into UMD from a dynamically imported package.
+  // Maybe someone else can help figure that out.
+  const loadingKey = `__superset__loading__/${name}`;
+  const packageKey = `__superset__/${name}`;
+  if (window[loadingKey]) {
+    await window[loadingKey];
+    return window[packageKey];
+  }
+  window[loadingKey] = promise;
+  const pkg = await promise;
+  window[packageKey] = pkg;
+  return pkg;
+}
+
+async function defineSharedModules(moduleMap: { [key: string]: Promise<any> }) {
+  return Promise.all(
+    Object.entries(moduleMap).map(([name, promise]) => {
+      defineSharedModule(name, promise);
+      return promise;
+    }),
+  );
+}
+
+type CompleteAction = {
+  type: 'complete';
+  key: string;
+  error: null | Error;
+};
+
+type BeginAction = {
+  type: 'begin';
+  keys: string[];
+};
+
+function pluginContextReducer(
+  state: PluginContextType,
+  action: BeginAction | CompleteAction,
+): PluginContextType {
+  switch (action.type) {
+    case 'begin': {
+      const plugins = { ...state.plugins };
+      for (const key of action.keys) {
+        plugins[key] = { key, error: null, loading: true };
+      }
+      return {
+        ...state,
+        loading: true,
+        plugins,
+      };
+    }
+    case 'complete': {
+      return {
+        ...state,
+        loading: Object.values(state.plugins).some(
+          plugin => plugin.loading && plugin.key !== action.key,
+        ),
+        plugins: {
+          ...state.plugins,
+          [action.key]: {
+            key: action.key,
+            loading: false,
+            error: action.error,
+          },
+        },
+      };
+    }
+    default:
+      return state;
+  }
+}
+
+export type Props = React.PropsWithChildren<{}>;
+
+export default function DynamicPluginProvider({ children }: Props) {
+  const [pluginState, dispatch] = useReducer(pluginContextReducer, {
+    // use the dummy plugin context, and override the methods
+    ...dummyPluginContext,
+    // eslint-disable-next-line @typescript-eslint/no-use-before-define
+    fetchAll,
+    loading: isFeatureEnabled(FeatureFlag.DYNAMIC_PLUGINS),
+    // TODO: Write fetchByKeys
+  });
+
+  async function fetchAll() {
+    try {
+      await defineSharedModules({
+        react: import('react'),
+        lodash: import('lodash'),
+        'react-dom': import('react-dom'),
+        '@superset-ui/chart': import('@superset-ui/chart'),
+        '@superset-ui/chart-controls': import('@superset-ui/chart-controls'),
+        '@superset-ui/connection': import('@superset-ui/connection'),
+        '@superset-ui/color': import('@superset-ui/color'),
+        '@superset-ui/core': import('@superset-ui/core'),
+        '@superset-ui/dimension': import('@superset-ui/dimension'),
+        '@superset-ui/query': import('@superset-ui/query'),
+        '@superset-ui/style': import('@superset-ui/style'),
+        '@superset-ui/translation': import('@superset-ui/translation'),
+        '@superset-ui/validator': import('@superset-ui/validator'),
+      });

Review comment:
       Nice

##########
File path: superset-frontend/src/components/DynamicPlugins/DynamicPluginProvider.tsx
##########
@@ -0,0 +1,181 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useReducer } from 'react';
+import { SupersetClient, JsonObject } from '@superset-ui/connection';
+import { isFeatureEnabled, FeatureFlag } from 'src/featureFlags';
+import {
+  PluginContext,
+  PluginContextType,
+  dummyPluginContext,
+} from './PluginContext';
+
+// the plugin returned from the API
+type Plugin = {
+  name: string;
+  key: string;
+  bundle_url: string;
+  id: number;
+};
+
+// TODO: Make this function an export of @superset-ui/chart or some such
+async function defineSharedModule(name: string, promise: Promise<any>) {
+  // dependency management using global variables, because for the life of me
+  // I can't figure out how to hook into UMD from a dynamically imported package.
+  // Maybe someone else can help figure that out.
+  const loadingKey = `__superset__loading__/${name}`;
+  const packageKey = `__superset__/${name}`;
+  if (window[loadingKey]) {
+    await window[loadingKey];
+    return window[packageKey];
+  }
+  window[loadingKey] = promise;
+  const pkg = await promise;
+  window[packageKey] = pkg;

Review comment:
       Should we clean up the `loadingKey` when loading is complete?

##########
File path: superset-frontend/src/components/DynamicPlugins/DynamicPluginProvider.tsx
##########
@@ -0,0 +1,181 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useReducer } from 'react';
+import { SupersetClient, JsonObject } from '@superset-ui/connection';
+import { isFeatureEnabled, FeatureFlag } from 'src/featureFlags';
+import {
+  PluginContext,
+  PluginContextType,
+  dummyPluginContext,
+} from './PluginContext';
+
+// the plugin returned from the API
+type Plugin = {
+  name: string;
+  key: string;
+  bundle_url: string;
+  id: number;
+};
+
+// TODO: Make this function an export of @superset-ui/chart or some such
+async function defineSharedModule(name: string, promise: Promise<any>) {
+  // dependency management using global variables, because for the life of me
+  // I can't figure out how to hook into UMD from a dynamically imported package.
+  // Maybe someone else can help figure that out.
+  const loadingKey = `__superset__loading__/${name}`;
+  const packageKey = `__superset__/${name}`;
+  if (window[loadingKey]) {
+    await window[loadingKey];
+    return window[packageKey];
+  }
+  window[loadingKey] = promise;
+  const pkg = await promise;
+  window[packageKey] = pkg;
+  return pkg;
+}
+
+async function defineSharedModules(moduleMap: { [key: string]: Promise<any> }) {
+  return Promise.all(
+    Object.entries(moduleMap).map(([name, promise]) => {
+      defineSharedModule(name, promise);
+      return promise;
+    }),
+  );
+}
+
+type CompleteAction = {
+  type: 'complete';
+  key: string;
+  error: null | Error;
+};
+
+type BeginAction = {
+  type: 'begin';
+  keys: string[];
+};
+
+function pluginContextReducer(
+  state: PluginContextType,
+  action: BeginAction | CompleteAction,
+): PluginContextType {
+  switch (action.type) {
+    case 'begin': {
+      const plugins = { ...state.plugins };
+      for (const key of action.keys) {
+        plugins[key] = { key, error: null, loading: true };
+      }
+      return {
+        ...state,
+        loading: true,
+        plugins,
+      };
+    }
+    case 'complete': {
+      return {
+        ...state,
+        loading: Object.values(state.plugins).some(
+          plugin => plugin.loading && plugin.key !== action.key,
+        ),
+        plugins: {
+          ...state.plugins,
+          [action.key]: {
+            key: action.key,
+            loading: false,
+            error: action.error,
+          },
+        },
+      };
+    }
+    default:
+      return state;
+  }
+}
+
+export type Props = React.PropsWithChildren<{}>;
+
+export default function DynamicPluginProvider({ children }: Props) {
+  const [pluginState, dispatch] = useReducer(pluginContextReducer, {
+    // use the dummy plugin context, and override the methods
+    ...dummyPluginContext,
+    // eslint-disable-next-line @typescript-eslint/no-use-before-define
+    fetchAll,
+    loading: isFeatureEnabled(FeatureFlag.DYNAMIC_PLUGINS),
+    // TODO: Write fetchByKeys
+  });
+
+  async function fetchAll() {
+    try {
+      await defineSharedModules({
+        react: import('react'),
+        lodash: import('lodash'),
+        'react-dom': import('react-dom'),
+        '@superset-ui/chart': import('@superset-ui/chart'),
+        '@superset-ui/chart-controls': import('@superset-ui/chart-controls'),
+        '@superset-ui/connection': import('@superset-ui/connection'),
+        '@superset-ui/color': import('@superset-ui/color'),
+        '@superset-ui/core': import('@superset-ui/core'),
+        '@superset-ui/dimension': import('@superset-ui/dimension'),
+        '@superset-ui/query': import('@superset-ui/query'),
+        '@superset-ui/style': import('@superset-ui/style'),
+        '@superset-ui/translation': import('@superset-ui/translation'),
+        '@superset-ui/validator': import('@superset-ui/validator'),
+      });

Review comment:
       Should `defineSharedModules` be called outside of `fetchAll` or in a separate `setup` function? It would also be nice to make `DynamicProviderProvider` load only specific plugins on demand instead of all together.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (7624937) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92fdf54aa34ed2edd5c85b5b47053bf4ce559517?el=desc) (92fdf54) will **decrease** coverage by `3.31%`.
   > The diff coverage is `70.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   66.71%   63.39%   -3.32%     
   ==========================================
     Files         967      484     -483     
     Lines       47543    29708   -17835     
     Branches     4650        0    -4650     
   ==========================================
   - Hits        31716    18832   -12884     
   + Misses      15706    10876    -4830     
   + Partials      121        0     -121     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.39% <70.45%> (-0.65%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.51% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.11% <100.00%> (-0.40%)` | :arrow_down: |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `80.73% <100.00%> (-6.87%)` | :arrow_down: |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | ... and [503 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [92fdf54...7624937](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (4f23ee6) into [master](https://codecov.io/gh/apache/incubator-superset/commit/865beae3d8644bb5e9df156e5fea80c3ec0202a2?el=desc) (865beae) will **decrease** coverage by `3.05%`.
   > The diff coverage is `36.27%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   65.82%   62.76%   -3.06%     
   ==========================================
     Files         988      992       +4     
     Lines       48702    48812     +110     
     Branches     4907     4922      +15     
   ==========================================
   - Hits        32056    30636    -1420     
   - Misses      16501    17979    +1478     
   - Partials      145      197      +52     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `61.38% <27.98%> (-0.60%)` | :arrow_down: |
   | python | `63.64% <75.00%> (-0.56%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/addSlice/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FwcC50c3g=) | `0.00% <0.00%> (ø)` | |
   | [superset-frontend/src/chart/chartReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci5qcw==) | `24.24% <0.00%> (-20.21%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <ø> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <ø> (-100.00%)` | :arrow_down: |
   | [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `8.57% <ø> (-40.73%)` | :arrow_down: |
   | [...src/explore/components/controls/VizTypeControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC5qc3g=) | `72.72% <0.00%> (-19.59%)` | :arrow_down: |
   | [...et-frontend/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZXhwbG9yZVJlZHVjZXIuanM=) | `31.57% <0.00%> (-2.97%)` | :arrow_down: |
   | [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | `0.00% <0.00%> (-26.83%)` | :arrow_down: |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.54% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | ... and [180 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [865beae...4f23ee6](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] amitNielsen commented on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
amitNielsen commented on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-683288270


   @suddjian I've fix the pre-commit issues for re configuring 3rd party and then re running sort 
   for some reason I can't pull request to your repo as last time 🤔 
   
   here is my branch with the fix : https://github.com/amitnielsen/incubator-superset/tree/dynamic-plugin-import


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] suddjian edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
suddjian edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-684058017


   A cypress test sounds like a good idea to me.
   
   I have the example plugin working locally, maybe I can help there?
   
   I think dynamic plugins in the long run will have a different set of requirements than static plugins. I'm thinking about adding some kind of `manifest` json file to specify the plugin name, key, thumbnail, version, and main module. That would allow the backend to inspect plugin info without loading the plugin in a js environment. We could build these things into the yeoman generator, but I think for now this should be considered a very experimental feature and subject to change.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] suddjian commented on a change in pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#discussion_r546193371



##########
File path: superset-frontend/src/explore/components/ExploreViewContainer.jsx
##########
@@ -122,138 +127,110 @@ const Styles = styled.div`
   }
 `;
 
-class ExploreViewContainer extends React.Component {

Review comment:
       Converted this to a function component out of frustration with changing it. Didn't have the stamina to go all the way and convert it to typescript.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] dpgaspar commented on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
dpgaspar commented on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-750363663


   https://stackoverflow.com/questions/8746207/1071-specified-key-was-too-long-max-key-length-is-1000-bytes
   
   Indicates that it could be related to the charset or a non InnoDB engine. Maybe?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] suddjian commented on a change in pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#discussion_r546193171



##########
File path: superset/errors.py
##########
@@ -15,7 +15,7 @@
 # specific language governing permissions and limitations
 # under the License.
 # pylint: disable=too-few-public-methods,invalid-name
-from dataclasses import dataclass
+from dataclasses import dataclass  # pylint: disable=wrong-import-order

Review comment:
       don't know why but every linter decided to lose its shit here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10288: feat: Dynamically imported viz plugins

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
   > Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (080675f) into [master](https://codecov.io/gh/apache/incubator-superset/commit/865beae3d8644bb5e9df156e5fea80c3ec0202a2?el=desc) (865beae) will **decrease** coverage by `2.53%`.
   > The diff coverage is `75.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10288/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10288      +/-   ##
   ==========================================
   - Coverage   65.82%   63.29%   -2.54%     
   ==========================================
     Files         988      484     -504     
     Lines       48702    29744   -18958     
     Branches     4907        0    -4907     
   ==========================================
   - Hits        32056    18825   -13231     
   + Misses      16501    10919    -5582     
   + Partials      145        0     -145     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.29% <75.00%> (-0.92%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.54% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
   | [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.23% <100.00%> (-0.28%)` | :arrow_down: |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.71% <100.00%> (ø)` | |
   | ... and [529 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [865beae...080675f](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org