You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Dan Tran <da...@gmail.com> on 2016/12/25 20:34:57 UTC

Re: maven-wagon git commit: [WAGON-471] Clean up dependency mess (reported by dependency:analyze)

is it necessary to introduce

<dependency>
     <groupId>org.slf4j</groupId>
     <artifactId>slf4j-simple</artifactId>
 </dependency>

as compile scope?

Thanks

-Dan

On Sun, Dec 25, 2016 at 12:10 PM, <mi...@apache.org> wrote:

> Repository: maven-wagon
> Updated Branches:
>   refs/heads/master 4da2accfd -> b451e418e
>
>
> [WAGON-471] Clean up dependency mess (reported by dependency:analyze)
>
> Followup fix for SLF4J Simple in test scope for file, scm and
> http-lightweight.
>
>
> Project: http://git-wip-us.apache.org/repos/asf/maven-wagon/repo
> Commit: http://git-wip-us.apache.org/repos/asf/maven-wagon/commit/b451e418
> Tree: http://git-wip-us.apache.org/repos/asf/maven-wagon/tree/b451e418
> Diff: http://git-wip-us.apache.org/repos/asf/maven-wagon/diff/b451e418
>
> Branch: refs/heads/master
> Commit: b451e418ed5235f231f5288fd21054f450669aa9
> Parents: 4da2acc
> Author: Michael Osipov <mi...@apache.org>
> Authored: Sun Dec 25 21:09:43 2016 +0100
> Committer: Michael Osipov <mi...@apache.org>
> Committed: Sun Dec 25 21:09:43 2016 +0100
>
> ----------------------------------------------------------------------
>  wagon-providers/wagon-file/pom.xml             | 4 ++++
>  wagon-providers/wagon-http-lightweight/pom.xml | 4 ++++
>  wagon-providers/wagon-scm/pom.xml              | 4 ++++
>  3 files changed, 12 insertions(+)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/maven-wagon/blob/
> b451e418/wagon-providers/wagon-file/pom.xml
> ----------------------------------------------------------------------
> diff --git a/wagon-providers/wagon-file/pom.xml
> b/wagon-providers/wagon-file/pom.xml
> index 4e3cb52..a96af63 100644
> --- a/wagon-providers/wagon-file/pom.xml
> +++ b/wagon-providers/wagon-file/pom.xml
> @@ -38,5 +38,9 @@ under the License.
>        <groupId>org.codehaus.plexus</groupId>
>        <artifactId>plexus-utils</artifactId>
>      </dependency>
> +    <dependency>
> +      <groupId>org.slf4j</groupId>
> +      <artifactId>slf4j-simple</artifactId>
> +    </dependency>
>    </dependencies>
>  </project>
>
> http://git-wip-us.apache.org/repos/asf/maven-wagon/blob/
> b451e418/wagon-providers/wagon-http-lightweight/pom.xml
> ----------------------------------------------------------------------
> diff --git a/wagon-providers/wagon-http-lightweight/pom.xml
> b/wagon-providers/wagon-http-lightweight/pom.xml
> index 9a0e8c8..f723004 100644
> --- a/wagon-providers/wagon-http-lightweight/pom.xml
> +++ b/wagon-providers/wagon-http-lightweight/pom.xml
> @@ -64,5 +64,9 @@ under the License.
>        <artifactId>jetty</artifactId>
>        <scope>test</scope>
>      </dependency>
> +    <dependency>
> +      <groupId>org.slf4j</groupId>
> +      <artifactId>slf4j-simple</artifactId>
> +    </dependency>
>    </dependencies>
>  </project>
>
> http://git-wip-us.apache.org/repos/asf/maven-wagon/blob/
> b451e418/wagon-providers/wagon-scm/pom.xml
> ----------------------------------------------------------------------
> diff --git a/wagon-providers/wagon-scm/pom.xml
> b/wagon-providers/wagon-scm/pom.xml
> index 55c14e6..881040a 100644
> --- a/wagon-providers/wagon-scm/pom.xml
> +++ b/wagon-providers/wagon-scm/pom.xml
> @@ -65,6 +65,10 @@ under the License.
>        <version>${mavenScmVersion}</version>
>        <scope>test</scope>
>      </dependency>
> +    <dependency>
> +      <groupId>org.slf4j</groupId>
> +      <artifactId>slf4j-simple</artifactId>
> +    </dependency>
>    </dependencies>
>
>    <build>
>
>

Re: maven-wagon git commit: [WAGON-471] Clean up dependency mess (reported by dependency:analyze)

Posted by Michael Osipov <mi...@apache.org>.
Am 2016-12-25 um 21:34 schrieb Dan Tran:
> is it necessary to introduce
>
> <dependency>
>      <groupId>org.slf4j</groupId>
>      <artifactId>slf4j-simple</artifactId>
>  </dependency>
>
> as compile scope?

It is not in compile scope. Please have a look into dependencyManagement 
in parent. The default scope for this dependency is test:
https://git-wip-us.apache.org/repos/asf?p=maven-wagon.git;a=blob;f=pom.xml;h=e127da4bec14c4312511e7d74b935551da5e5fa6;hb=HEAD#l291

> On Sun, Dec 25, 2016 at 12:10 PM, <mi...@apache.org> wrote:
>
>> Repository: maven-wagon
>> Updated Branches:
>>   refs/heads/master 4da2accfd -> b451e418e
>>
>>
>> [WAGON-471] Clean up dependency mess (reported by dependency:analyze)
>>
>> Followup fix for SLF4J Simple in test scope for file, scm and
>> http-lightweight.
>>
>>
>> Project: http://git-wip-us.apache.org/repos/asf/maven-wagon/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/maven-wagon/commit/b451e418
>> Tree: http://git-wip-us.apache.org/repos/asf/maven-wagon/tree/b451e418
>> Diff: http://git-wip-us.apache.org/repos/asf/maven-wagon/diff/b451e418
>>
>> Branch: refs/heads/master
>> Commit: b451e418ed5235f231f5288fd21054f450669aa9
>> Parents: 4da2acc
>> Author: Michael Osipov <mi...@apache.org>
>> Authored: Sun Dec 25 21:09:43 2016 +0100
>> Committer: Michael Osipov <mi...@apache.org>
>> Committed: Sun Dec 25 21:09:43 2016 +0100
>>
>> ----------------------------------------------------------------------
>>  wagon-providers/wagon-file/pom.xml             | 4 ++++
>>  wagon-providers/wagon-http-lightweight/pom.xml | 4 ++++
>>  wagon-providers/wagon-scm/pom.xml              | 4 ++++
>>  3 files changed, 12 insertions(+)
>> ----------------------------------------------------------------------
>>
>>
>> http://git-wip-us.apache.org/repos/asf/maven-wagon/blob/
>> b451e418/wagon-providers/wagon-file/pom.xml
>> ----------------------------------------------------------------------
>> diff --git a/wagon-providers/wagon-file/pom.xml
>> b/wagon-providers/wagon-file/pom.xml
>> index 4e3cb52..a96af63 100644
>> --- a/wagon-providers/wagon-file/pom.xml
>> +++ b/wagon-providers/wagon-file/pom.xml
>> @@ -38,5 +38,9 @@ under the License.
>>        <groupId>org.codehaus.plexus</groupId>
>>        <artifactId>plexus-utils</artifactId>
>>      </dependency>
>> +    <dependency>
>> +      <groupId>org.slf4j</groupId>
>> +      <artifactId>slf4j-simple</artifactId>
>> +    </dependency>
>>    </dependencies>
>>  </project>
>>
>> http://git-wip-us.apache.org/repos/asf/maven-wagon/blob/
>> b451e418/wagon-providers/wagon-http-lightweight/pom.xml
>> ----------------------------------------------------------------------
>> diff --git a/wagon-providers/wagon-http-lightweight/pom.xml
>> b/wagon-providers/wagon-http-lightweight/pom.xml
>> index 9a0e8c8..f723004 100644
>> --- a/wagon-providers/wagon-http-lightweight/pom.xml
>> +++ b/wagon-providers/wagon-http-lightweight/pom.xml
>> @@ -64,5 +64,9 @@ under the License.
>>        <artifactId>jetty</artifactId>
>>        <scope>test</scope>
>>      </dependency>
>> +    <dependency>
>> +      <groupId>org.slf4j</groupId>
>> +      <artifactId>slf4j-simple</artifactId>
>> +    </dependency>
>>    </dependencies>
>>  </project>
>>
>> http://git-wip-us.apache.org/repos/asf/maven-wagon/blob/
>> b451e418/wagon-providers/wagon-scm/pom.xml
>> ----------------------------------------------------------------------
>> diff --git a/wagon-providers/wagon-scm/pom.xml
>> b/wagon-providers/wagon-scm/pom.xml
>> index 55c14e6..881040a 100644
>> --- a/wagon-providers/wagon-scm/pom.xml
>> +++ b/wagon-providers/wagon-scm/pom.xml
>> @@ -65,6 +65,10 @@ under the License.
>>        <version>${mavenScmVersion}</version>
>>        <scope>test</scope>
>>      </dependency>
>> +    <dependency>
>> +      <groupId>org.slf4j</groupId>
>> +      <artifactId>slf4j-simple</artifactId>
>> +    </dependency>
>>    </dependencies>
>>
>>    <build>
>>
>>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org