You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/07/30 19:11:21 UTC
[GitHub] [superset] lyndsiWilliams opened a new pull request #15984: feat: Add report format options to Charts report modal II
lyndsiWilliams opened a new pull request #15984:
URL: https://github.com/apache/superset/pull/15984
### SUMMARY
Report format options added to Charts report modal.
### SCREENSHOT
<img width="489" alt="betoComponent" src="https://user-images.githubusercontent.com/55605634/127610341-ea03ec10-b060-4df9-b83b-cf5f23af7c95.png">
### TESTING INSTRUCTIONS
- Click "Charts" in the upper navigation bar
- Navigate to any Chart
- Click the Calendar icon button
- Located at the top of the chart between the timer and the "Copy chart URL to clipboard" button
- Observe the "Message Content" section of the email report modal
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #15984: feat: Add report format options to Charts report modal II
Posted by GitBox <gi...@apache.org>.
eschutho commented on pull request #15984:
URL: https://github.com/apache/superset/pull/15984#issuecomment-890111689
@lyndsiWilliams I cherry picked this into the branch and pushed it up manually. I rebased from master and I think it made more issues for you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho closed pull request #15984: feat: Add report format options to Charts report modal II
Posted by GitBox <gi...@apache.org>.
eschutho closed pull request #15984:
URL: https://github.com/apache/superset/pull/15984
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org