You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/11/22 07:11:41 UTC

[GitHub] [dubbo] BurningCN opened a new pull request #9304: Add unit test for common-module

BurningCN opened a new pull request #9304:
URL: https://github.com/apache/dubbo/pull/9304


   ## What is the purpose of the change
   
   Add unit test for common-module
   
   - CompositeConfigurationTest  
   - PropertiesConfigurationTest 
   - AdaptiveExtensionInjectorTest 
   - FrameworkStatusReportServiceTest 
   - ConfigConfigurationAdapterTest
   - Add some cases to the existing Test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9304: Add unit test for common-module

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9304:
URL: https://github.com/apache/dubbo/pull/9304#issuecomment-975209480


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9304?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9304](https://codecov.io/gh/apache/dubbo/pull/9304?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1aef7ef) into [3.0](https://codecov.io/gh/apache/dubbo/commit/3cceefa23434e1a8f337290617cb5594241b3f16?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3cceefa) will **increase** coverage by `0.12%`.
   > The diff coverage is `60.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9304/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9304?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9304      +/-   ##
   ============================================
   + Coverage     65.31%   65.44%   +0.12%     
   + Complexity      343      342       -1     
   ============================================
     Files          1207     1201       -6     
     Lines         51948    51724     -224     
     Branches       7724     7723       -1     
   ============================================
   - Hits          33932    33850      -82     
   + Misses        14392    14254     -138     
   + Partials       3624     3620       -4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9304?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...dubbo/common/beans/ScopeBeanExtensionInjector.java](https://codecov.io/gh/apache/dubbo/pull/9304/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vYmVhbnMvU2NvcGVCZWFuRXh0ZW5zaW9uSW5qZWN0b3IuamF2YQ==) | `100.00% <ø> (ø)` | |
   | [...va/org/apache/dubbo/common/config/Environment.java](https://codecov.io/gh/apache/dubbo/pull/9304/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL0Vudmlyb25tZW50LmphdmE=) | `86.77% <0.00%> (+11.57%)` | :arrow_up: |
   | [.../common/extension/inject/SpiExtensionInjector.java](https://codecov.io/gh/apache/dubbo/pull/9304/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL2luamVjdC9TcGlFeHRlbnNpb25JbmplY3Rvci5qYXZh) | `100.00% <ø> (ø)` | |
   | [...ava/org/apache/dubbo/common/utils/ConfigUtils.java](https://codecov.io/gh/apache/dubbo/pull/9304/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvQ29uZmlnVXRpbHMuamF2YQ==) | `78.06% <25.00%> (+9.03%)` | :arrow_up: |
   | [...he/dubbo/common/config/CompositeConfiguration.java](https://codecov.io/gh/apache/dubbo/pull/9304/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL0NvbXBvc2l0ZUNvbmZpZ3VyYXRpb24uamF2YQ==) | `67.85% <50.00%> (+21.42%)` | :arrow_up: |
   | [.../common/config/OrderedPropertiesConfiguration.java](https://codecov.io/gh/apache/dubbo/pull/9304/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL09yZGVyZWRQcm9wZXJ0aWVzQ29uZmlndXJhdGlvbi5qYXZh) | `80.76% <100.00%> (+2.99%)` | :arrow_up: |
   | [.../status/reporter/FrameworkStatusReportService.java](https://codecov.io/gh/apache/dubbo/pull/9304/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc3RhdHVzL3JlcG9ydGVyL0ZyYW1ld29ya1N0YXR1c1JlcG9ydFNlcnZpY2UuamF2YQ==) | `92.85% <100.00%> (+62.85%)` | :arrow_up: |
   | [...ache/dubbo/rpc/cluster/CacheableRouterFactory.java](https://codecov.io/gh/apache/dubbo/pull/9304/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvQ2FjaGVhYmxlUm91dGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...pache/dubbo/rpc/cluster/router/AbstractRouter.java](https://codecov.io/gh/apache/dubbo/pull/9304/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL0Fic3RyYWN0Um91dGVyLmphdmE=) | `0.00% <0.00%> (-89.48%)` | :arrow_down: |
   | [...main/java/org/apache/dubbo/rpc/cluster/Router.java](https://codecov.io/gh/apache/dubbo/pull/9304/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvUm91dGVyLmphdmE=) | `14.28% <0.00%> (-28.58%)` | :arrow_down: |
   | ... and [65 more](https://codecov.io/gh/apache/dubbo/pull/9304/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9304?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9304?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3cceefa...1aef7ef](https://codecov.io/gh/apache/dubbo/pull/9304?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] AlbumenJ merged pull request #9304: Add unit test for common-module

Posted by GitBox <gi...@apache.org>.
AlbumenJ merged pull request #9304:
URL: https://github.com/apache/dubbo/pull/9304


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9304: Add unit test for common-module

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9304:
URL: https://github.com/apache/dubbo/pull/9304#issuecomment-975209480


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9304?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9304](https://codecov.io/gh/apache/dubbo/pull/9304?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1aef7ef) into [3.0](https://codecov.io/gh/apache/dubbo/commit/3cceefa23434e1a8f337290617cb5594241b3f16?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3cceefa) will **increase** coverage by `0.10%`.
   > The diff coverage is `60.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9304/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9304?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9304      +/-   ##
   ============================================
   + Coverage     65.31%   65.42%   +0.10%     
   + Complexity      343      342       -1     
   ============================================
     Files          1207     1201       -6     
     Lines         51948    51724     -224     
     Branches       7724     7723       -1     
   ============================================
   - Hits          33932    33842      -90     
   + Misses        14392    14262     -130     
   + Partials       3624     3620       -4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9304?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...dubbo/common/beans/ScopeBeanExtensionInjector.java](https://codecov.io/gh/apache/dubbo/pull/9304/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vYmVhbnMvU2NvcGVCZWFuRXh0ZW5zaW9uSW5qZWN0b3IuamF2YQ==) | `100.00% <ø> (ø)` | |
   | [...va/org/apache/dubbo/common/config/Environment.java](https://codecov.io/gh/apache/dubbo/pull/9304/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL0Vudmlyb25tZW50LmphdmE=) | `86.77% <0.00%> (+11.57%)` | :arrow_up: |
   | [.../common/extension/inject/SpiExtensionInjector.java](https://codecov.io/gh/apache/dubbo/pull/9304/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL2luamVjdC9TcGlFeHRlbnNpb25JbmplY3Rvci5qYXZh) | `100.00% <ø> (ø)` | |
   | [...ava/org/apache/dubbo/common/utils/ConfigUtils.java](https://codecov.io/gh/apache/dubbo/pull/9304/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvQ29uZmlnVXRpbHMuamF2YQ==) | `78.06% <25.00%> (+9.03%)` | :arrow_up: |
   | [...he/dubbo/common/config/CompositeConfiguration.java](https://codecov.io/gh/apache/dubbo/pull/9304/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL0NvbXBvc2l0ZUNvbmZpZ3VyYXRpb24uamF2YQ==) | `67.85% <50.00%> (+21.42%)` | :arrow_up: |
   | [.../common/config/OrderedPropertiesConfiguration.java](https://codecov.io/gh/apache/dubbo/pull/9304/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL09yZGVyZWRQcm9wZXJ0aWVzQ29uZmlndXJhdGlvbi5qYXZh) | `80.76% <100.00%> (+2.99%)` | :arrow_up: |
   | [.../status/reporter/FrameworkStatusReportService.java](https://codecov.io/gh/apache/dubbo/pull/9304/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc3RhdHVzL3JlcG9ydGVyL0ZyYW1ld29ya1N0YXR1c1JlcG9ydFNlcnZpY2UuamF2YQ==) | `92.85% <100.00%> (+62.85%)` | :arrow_up: |
   | [...ache/dubbo/rpc/cluster/CacheableRouterFactory.java](https://codecov.io/gh/apache/dubbo/pull/9304/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvQ2FjaGVhYmxlUm91dGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...pache/dubbo/rpc/cluster/router/AbstractRouter.java](https://codecov.io/gh/apache/dubbo/pull/9304/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL0Fic3RyYWN0Um91dGVyLmphdmE=) | `0.00% <0.00%> (-89.48%)` | :arrow_down: |
   | [...main/java/org/apache/dubbo/rpc/cluster/Router.java](https://codecov.io/gh/apache/dubbo/pull/9304/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvUm91dGVyLmphdmE=) | `14.28% <0.00%> (-28.58%)` | :arrow_down: |
   | ... and [66 more](https://codecov.io/gh/apache/dubbo/pull/9304/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9304?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9304?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3cceefa...1aef7ef](https://codecov.io/gh/apache/dubbo/pull/9304?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9304: Add unit test for common-module

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9304:
URL: https://github.com/apache/dubbo/pull/9304#issuecomment-975209480


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9304?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9304](https://codecov.io/gh/apache/dubbo/pull/9304?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1aef7ef) into [3.0](https://codecov.io/gh/apache/dubbo/commit/3cceefa23434e1a8f337290617cb5594241b3f16?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3cceefa) will **increase** coverage by `0.05%`.
   > The diff coverage is `60.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9304/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9304?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9304      +/-   ##
   ============================================
   + Coverage     65.31%   65.37%   +0.05%     
   + Complexity      343      342       -1     
   ============================================
     Files          1207     1201       -6     
     Lines         51948    51724     -224     
     Branches       7724     7723       -1     
   ============================================
   - Hits          33932    33815     -117     
   + Misses        14392    14284     -108     
   - Partials       3624     3625       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9304?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...dubbo/common/beans/ScopeBeanExtensionInjector.java](https://codecov.io/gh/apache/dubbo/pull/9304/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vYmVhbnMvU2NvcGVCZWFuRXh0ZW5zaW9uSW5qZWN0b3IuamF2YQ==) | `100.00% <ø> (ø)` | |
   | [...va/org/apache/dubbo/common/config/Environment.java](https://codecov.io/gh/apache/dubbo/pull/9304/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL0Vudmlyb25tZW50LmphdmE=) | `86.77% <0.00%> (+11.57%)` | :arrow_up: |
   | [.../common/extension/inject/SpiExtensionInjector.java](https://codecov.io/gh/apache/dubbo/pull/9304/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL2luamVjdC9TcGlFeHRlbnNpb25JbmplY3Rvci5qYXZh) | `100.00% <ø> (ø)` | |
   | [...ava/org/apache/dubbo/common/utils/ConfigUtils.java](https://codecov.io/gh/apache/dubbo/pull/9304/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvQ29uZmlnVXRpbHMuamF2YQ==) | `78.06% <25.00%> (+9.03%)` | :arrow_up: |
   | [...he/dubbo/common/config/CompositeConfiguration.java](https://codecov.io/gh/apache/dubbo/pull/9304/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL0NvbXBvc2l0ZUNvbmZpZ3VyYXRpb24uamF2YQ==) | `67.85% <50.00%> (+21.42%)` | :arrow_up: |
   | [.../common/config/OrderedPropertiesConfiguration.java](https://codecov.io/gh/apache/dubbo/pull/9304/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL09yZGVyZWRQcm9wZXJ0aWVzQ29uZmlndXJhdGlvbi5qYXZh) | `80.76% <100.00%> (+2.99%)` | :arrow_up: |
   | [.../status/reporter/FrameworkStatusReportService.java](https://codecov.io/gh/apache/dubbo/pull/9304/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc3RhdHVzL3JlcG9ydGVyL0ZyYW1ld29ya1N0YXR1c1JlcG9ydFNlcnZpY2UuamF2YQ==) | `92.85% <100.00%> (+62.85%)` | :arrow_up: |
   | [...ache/dubbo/rpc/cluster/CacheableRouterFactory.java](https://codecov.io/gh/apache/dubbo/pull/9304/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvQ2FjaGVhYmxlUm91dGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...pache/dubbo/rpc/cluster/router/AbstractRouter.java](https://codecov.io/gh/apache/dubbo/pull/9304/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL0Fic3RyYWN0Um91dGVyLmphdmE=) | `0.00% <0.00%> (-89.48%)` | :arrow_down: |
   | [...main/java/org/apache/dubbo/rpc/cluster/Router.java](https://codecov.io/gh/apache/dubbo/pull/9304/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvUm91dGVyLmphdmE=) | `14.28% <0.00%> (-28.58%)` | :arrow_down: |
   | ... and [68 more](https://codecov.io/gh/apache/dubbo/pull/9304/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9304?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9304?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3cceefa...1aef7ef](https://codecov.io/gh/apache/dubbo/pull/9304?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter commented on pull request #9304: Add unit test for common-module

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #9304:
URL: https://github.com/apache/dubbo/pull/9304#issuecomment-975209480


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9304?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9304](https://codecov.io/gh/apache/dubbo/pull/9304?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1aef7ef) into [3.0](https://codecov.io/gh/apache/dubbo/commit/3cceefa23434e1a8f337290617cb5594241b3f16?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3cceefa) will **decrease** coverage by `0.00%`.
   > The diff coverage is `60.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9304/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9304?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9304      +/-   ##
   ============================================
   - Coverage     65.31%   65.31%   -0.01%     
   + Complexity      343      342       -1     
   ============================================
     Files          1207     1201       -6     
     Lines         51948    51724     -224     
     Branches       7724     7677      -47     
   ============================================
   - Hits          33932    33781     -151     
   + Misses        14392    14313      -79     
   - Partials       3624     3630       +6     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9304?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...dubbo/common/beans/ScopeBeanExtensionInjector.java](https://codecov.io/gh/apache/dubbo/pull/9304/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vYmVhbnMvU2NvcGVCZWFuRXh0ZW5zaW9uSW5qZWN0b3IuamF2YQ==) | `100.00% <ø> (ø)` | |
   | [...va/org/apache/dubbo/common/config/Environment.java](https://codecov.io/gh/apache/dubbo/pull/9304/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL0Vudmlyb25tZW50LmphdmE=) | `86.77% <0.00%> (+11.57%)` | :arrow_up: |
   | [.../common/extension/inject/SpiExtensionInjector.java](https://codecov.io/gh/apache/dubbo/pull/9304/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL2luamVjdC9TcGlFeHRlbnNpb25JbmplY3Rvci5qYXZh) | `100.00% <ø> (ø)` | |
   | [...ava/org/apache/dubbo/common/utils/ConfigUtils.java](https://codecov.io/gh/apache/dubbo/pull/9304/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvQ29uZmlnVXRpbHMuamF2YQ==) | `78.06% <25.00%> (+9.03%)` | :arrow_up: |
   | [...he/dubbo/common/config/CompositeConfiguration.java](https://codecov.io/gh/apache/dubbo/pull/9304/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL0NvbXBvc2l0ZUNvbmZpZ3VyYXRpb24uamF2YQ==) | `67.85% <50.00%> (+21.42%)` | :arrow_up: |
   | [.../common/config/OrderedPropertiesConfiguration.java](https://codecov.io/gh/apache/dubbo/pull/9304/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL09yZGVyZWRQcm9wZXJ0aWVzQ29uZmlndXJhdGlvbi5qYXZh) | `80.76% <100.00%> (+2.99%)` | :arrow_up: |
   | [.../status/reporter/FrameworkStatusReportService.java](https://codecov.io/gh/apache/dubbo/pull/9304/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc3RhdHVzL3JlcG9ydGVyL0ZyYW1ld29ya1N0YXR1c1JlcG9ydFNlcnZpY2UuamF2YQ==) | `92.85% <100.00%> (+62.85%)` | :arrow_up: |
   | [...ache/dubbo/rpc/cluster/CacheableRouterFactory.java](https://codecov.io/gh/apache/dubbo/pull/9304/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvQ2FjaGVhYmxlUm91dGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...pache/dubbo/rpc/cluster/router/AbstractRouter.java](https://codecov.io/gh/apache/dubbo/pull/9304/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL0Fic3RyYWN0Um91dGVyLmphdmE=) | `0.00% <0.00%> (-89.48%)` | :arrow_down: |
   | [...main/java/org/apache/dubbo/rpc/cluster/Router.java](https://codecov.io/gh/apache/dubbo/pull/9304/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvUm91dGVyLmphdmE=) | `14.28% <0.00%> (-28.58%)` | :arrow_down: |
   | ... and [80 more](https://codecov.io/gh/apache/dubbo/pull/9304/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9304?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9304?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3cceefa...1aef7ef](https://codecov.io/gh/apache/dubbo/pull/9304?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org