You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/07/13 13:00:55 UTC
[GitHub] [hbase] BukrosSzabolcs opened a new pull request #2057: HBASE-24720: Meta replicas not cleaned when disabled
BukrosSzabolcs opened a new pull request #2057:
URL: https://github.com/apache/hbase/pull/2057
- make sure to always clean up excess meta replicas not just when their number get decreased
- make sure NotServingRegionException is handled properly even when wrapped
- add test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2057: HBASE-24720: Meta replicas not cleaned when disabled
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2057:
URL: https://github.com/apache/hbase/pull/2057#issuecomment-657709173
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 36s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 47s | master passed |
| +1 :green_heart: | checkstyle | 1m 29s | master passed |
| +1 :green_heart: | spotbugs | 2m 13s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 32s | the patch passed |
| -0 :warning: | checkstyle | 1m 34s | hbase-server: The patch generated 1 new + 14 unchanged - 0 fixed = 15 total (was 14) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 12m 51s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. |
| +1 :green_heart: | spotbugs | 2m 15s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 14s | The patch does not generate ASF License warnings. |
| | | 35m 42s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2057/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2057 |
| JIRA Issue | HBASE-24720 |
| Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle |
| uname | Linux 807eff31f949 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 3bd54217a0 |
| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2057/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt |
| Max. process+thread count | 94 (vs. ulimit of 12500) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2057/1/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2057: HBASE-24720: Meta replicas not cleaned when disabled
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2057:
URL: https://github.com/apache/hbase/pull/2057#issuecomment-657769131
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 31s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 6s | master passed |
| +1 :green_heart: | compile | 0m 58s | master passed |
| +1 :green_heart: | shadedjars | 6m 39s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 40s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 43s | the patch passed |
| +1 :green_heart: | compile | 0m 57s | the patch passed |
| +1 :green_heart: | javac | 0m 57s | the patch passed |
| +1 :green_heart: | shadedjars | 5m 40s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 36s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 140m 29s | hbase-server in the patch passed. |
| | | 166m 8s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2057/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2057 |
| JIRA Issue | HBASE-24720 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 78771276e014 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 3bd54217a0 |
| Default Java | 1.8.0_232 |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2057/1/testReport/ |
| Max. process+thread count | 4783 (vs. ulimit of 12500) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2057/1/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] BukrosSzabolcs commented on a change in pull request #2057: HBASE-24720: Meta replicas not cleaned when disabled
Posted by GitBox <gi...@apache.org>.
BukrosSzabolcs commented on a change in pull request #2057:
URL: https://github.com/apache/hbase/pull/2057#discussion_r454322908
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMetaWithReplicasBasic.java
##########
@@ -80,6 +83,27 @@ public void testZookeeperNodesForReplicas() throws Exception {
}
}
+ @Test
+ public void testReplicaCleanup() throws Exception {
+ ZKWatcher zkw = TEST_UTIL.getZooKeeperWatcher();
+ List<String> metaReplicaZnodes = zkw.getMetaReplicaNodes();
+ assertEquals(metaReplicaZnodes.size(), 3);
Review comment:
Switched
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMetaWithReplicasBasic.java
##########
@@ -80,6 +83,27 @@ public void testZookeeperNodesForReplicas() throws Exception {
}
}
+ @Test
+ public void testReplicaCleanup() throws Exception {
+ ZKWatcher zkw = TEST_UTIL.getZooKeeperWatcher();
+ List<String> metaReplicaZnodes = zkw.getMetaReplicaNodes();
+ assertEquals(metaReplicaZnodes.size(), 3);
+
+ final HMaster master = TEST_UTIL.getMiniHBaseCluster().getMaster();
+ master.stop("Restarting");
+ TEST_UTIL.waitFor(30000, () -> master.isStopped());
+ TEST_UTIL.getMiniHBaseCluster().getConfiguration().setInt(HConstants.META_REPLICAS_NUM, 1);
+
+ JVMClusterUtil.MasterThread newMasterThread = TEST_UTIL.getMiniHBaseCluster().startMaster();
+ final HMaster newMaster = newMasterThread.getMaster();
+
+ //wait until new master finished meta replica assignment logic
+ TEST_UTIL.waitFor(30000, () -> newMaster.getMasterQuotaManager() != null);
+ zkw = TEST_UTIL.getZooKeeperWatcher();
+ metaReplicaZnodes = zkw.getMetaReplicaNodes();
+ assertEquals(metaReplicaZnodes.size(), 1);
Review comment:
Switched
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] BukrosSzabolcs commented on a change in pull request #2057: HBASE-24720: Meta replicas not cleaned when disabled
Posted by GitBox <gi...@apache.org>.
BukrosSzabolcs commented on a change in pull request #2057:
URL: https://github.com/apache/hbase/pull/2057#discussion_r454231152
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
##########
@@ -715,7 +716,10 @@ public static void closeRegionSilentlyAndWait(AsyncClusterConnection connection,
return;
}
} catch (IOException ioe) {
- if (ioe instanceof NotServingRegionException) {
+ if (ioe instanceof NotServingRegionException ||
+ (ioe instanceof RemoteWithExtrasException &&
+ ((RemoteWithExtrasException)ioe).unwrapRemoteException()
+ instanceof NotServingRegionException)) {
Review comment:
Yes, it is. The excess meta replicas are not assigned so when we try to close them a NotServingRegionException is thrown. Unfortunately it gets wrapped in a RemoteWithExtrasException which was not handled so the logic kept trying to close the region not realizing it was not necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on pull request #2057: HBASE-24720: Meta replicas not cleaned when disabled
Posted by GitBox <gi...@apache.org>.
virajjasani commented on pull request #2057:
URL: https://github.com/apache/hbase/pull/2057#issuecomment-658299090
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2057: HBASE-24720: Meta replicas not cleaned when disabled
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2057:
URL: https://github.com/apache/hbase/pull/2057#issuecomment-657807946
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 48s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 0s | master passed |
| +1 :green_heart: | compile | 1m 37s | master passed |
| +1 :green_heart: | shadedjars | 7m 35s | branch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 54s | hbase-server in master failed. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 25s | the patch passed |
| +1 :green_heart: | compile | 1m 31s | the patch passed |
| +1 :green_heart: | javac | 1m 31s | the patch passed |
| +1 :green_heart: | shadedjars | 7m 44s | patch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 46s | hbase-server in the patch failed. |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 215m 30s | hbase-server in the patch passed. |
| | | 250m 44s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2057/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2057 |
| JIRA Issue | HBASE-24720 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 593306761aed 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 3bd54217a0 |
| Default Java | 2020-01-14 |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2057/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2057/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2057/1/testReport/ |
| Max. process+thread count | 3191 (vs. ulimit of 12500) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2057/1/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #2057: HBASE-24720: Meta replicas not cleaned when disabled
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #2057:
URL: https://github.com/apache/hbase/pull/2057#discussion_r454508634
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
##########
@@ -715,7 +716,10 @@ public static void closeRegionSilentlyAndWait(AsyncClusterConnection connection,
return;
}
} catch (IOException ioe) {
- if (ioe instanceof NotServingRegionException) {
+ if (ioe instanceof NotServingRegionException ||
+ (ioe instanceof RemoteWithExtrasException &&
+ ((RemoteWithExtrasException)ioe).unwrapRemoteException()
+ instanceof NotServingRegionException)) {
Review comment:
Sounds good, I thought it was specific to unit test and only in the case of unit test (based on config), this is happening but yeah if this is generic, we are good.
Thanks @BukrosSzabolcs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] petersomogyi commented on a change in pull request #2057: HBASE-24720: Meta replicas not cleaned when disabled
Posted by GitBox <gi...@apache.org>.
petersomogyi commented on a change in pull request #2057:
URL: https://github.com/apache/hbase/pull/2057#discussion_r453814767
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMetaWithReplicasBasic.java
##########
@@ -80,6 +83,27 @@ public void testZookeeperNodesForReplicas() throws Exception {
}
}
+ @Test
+ public void testReplicaCleanup() throws Exception {
+ ZKWatcher zkw = TEST_UTIL.getZooKeeperWatcher();
+ List<String> metaReplicaZnodes = zkw.getMetaReplicaNodes();
+ assertEquals(metaReplicaZnodes.size(), 3);
+
+ final HMaster master = TEST_UTIL.getMiniHBaseCluster().getMaster();
+ master.stop("Restarting");
+ TEST_UTIL.waitFor(30000, () -> master.isStopped());
+ TEST_UTIL.getMiniHBaseCluster().getConfiguration().setInt(HConstants.META_REPLICAS_NUM, 1);
+
+ JVMClusterUtil.MasterThread newMasterThread = TEST_UTIL.getMiniHBaseCluster().startMaster();
+ final HMaster newMaster = newMasterThread.getMaster();
+
+ //wait until new master finished meta replica assignment logic
+ TEST_UTIL.waitFor(30000, () -> newMaster.getMasterQuotaManager() != null);
+ zkw = TEST_UTIL.getZooKeeperWatcher();
+ metaReplicaZnodes = zkw.getMetaReplicaNodes();
+ assertEquals(metaReplicaZnodes.size(), 1);
Review comment:
The parameter order for assertEquals should be switched.
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMetaWithReplicasBasic.java
##########
@@ -80,6 +83,27 @@ public void testZookeeperNodesForReplicas() throws Exception {
}
}
+ @Test
+ public void testReplicaCleanup() throws Exception {
+ ZKWatcher zkw = TEST_UTIL.getZooKeeperWatcher();
+ List<String> metaReplicaZnodes = zkw.getMetaReplicaNodes();
+ assertEquals(metaReplicaZnodes.size(), 3);
Review comment:
The parameter order for assertEquals should be switched.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #2057: HBASE-24720: Meta replicas not cleaned when disabled
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #2057:
URL: https://github.com/apache/hbase/pull/2057#discussion_r453745766
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
##########
@@ -715,7 +716,10 @@ public static void closeRegionSilentlyAndWait(AsyncClusterConnection connection,
return;
}
} catch (IOException ioe) {
- if (ioe instanceof NotServingRegionException) {
+ if (ioe instanceof NotServingRegionException ||
+ (ioe instanceof RemoteWithExtrasException &&
+ ((RemoteWithExtrasException)ioe).unwrapRemoteException()
+ instanceof NotServingRegionException)) {
Review comment:
This change is related to this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2057: HBASE-24720: Meta replicas not cleaned when disabled
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2057:
URL: https://github.com/apache/hbase/pull/2057#issuecomment-658236172
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 30s | Docker mode activated. |
| -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 26s | master passed |
| +1 :green_heart: | compile | 1m 9s | master passed |
| +1 :green_heart: | shadedjars | 6m 21s | branch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 44s | hbase-server in master failed. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 20s | the patch passed |
| +1 :green_heart: | compile | 1m 8s | the patch passed |
| +1 :green_heart: | javac | 1m 8s | the patch passed |
| +1 :green_heart: | shadedjars | 6m 17s | patch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 41s | hbase-server in the patch failed. |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 136m 32s | hbase-server in the patch passed. |
| | | 164m 5s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2057/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2057 |
| JIRA Issue | HBASE-24720 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux b24fad1251c7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / d132c4b53d |
| Default Java | 2020-01-14 |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2057/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2057/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2057/2/testReport/ |
| Max. process+thread count | 3865 (vs. ulimit of 12500) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2057/2/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2057: HBASE-24720: Meta replicas not cleaned when disabled
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2057:
URL: https://github.com/apache/hbase/pull/2057#issuecomment-658275113
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 16s | Docker mode activated. |
| -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 51s | master passed |
| +1 :green_heart: | compile | 0m 56s | master passed |
| +1 :green_heart: | shadedjars | 6m 6s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 40s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 20s | the patch passed |
| +1 :green_heart: | compile | 1m 3s | the patch passed |
| +1 :green_heart: | javac | 1m 3s | the patch passed |
| +1 :green_heart: | shadedjars | 6m 6s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 36s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 206m 38s | hbase-server in the patch passed. |
| | | 233m 29s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2057/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2057 |
| JIRA Issue | HBASE-24720 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux eb937692edc7 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / d132c4b53d |
| Default Java | 1.8.0_232 |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2057/2/testReport/ |
| Max. process+thread count | 3597 (vs. ulimit of 12500) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2057/2/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] petersomogyi merged pull request #2057: HBASE-24720: Meta replicas not cleaned when disabled
Posted by GitBox <gi...@apache.org>.
petersomogyi merged pull request #2057:
URL: https://github.com/apache/hbase/pull/2057
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2057: HBASE-24720: Meta replicas not cleaned when disabled
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2057:
URL: https://github.com/apache/hbase/pull/2057#issuecomment-658163868
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 31s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 41s | master passed |
| +1 :green_heart: | checkstyle | 1m 8s | master passed |
| +1 :green_heart: | spotbugs | 2m 2s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 23s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 3s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 11m 15s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. |
| +1 :green_heart: | spotbugs | 2m 4s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. |
| | | 32m 35s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2057/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2057 |
| JIRA Issue | HBASE-24720 |
| Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle |
| uname | Linux 16123aa9e015 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / d132c4b53d |
| Max. process+thread count | 94 (vs. ulimit of 12500) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2057/2/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org