You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2023/01/09 09:24:06 UTC

[GitHub] [hudi] Zouxxyy opened a new pull request, #7629: [HUDI-5519] Fix LogFileComparator with suffix for CDC

Zouxxyy opened a new pull request, #7629:
URL: https://github.com/apache/hudi/pull/7629

   ### Change Logs
   
   LogFileComparator does not compare cdc suffix, for example, for the following logs, they will be considered equal:
   
   ```text
   .file1_2.log.1_1-1-1
   .file1_2.log.1_1-1-1.cdc
   ```
   
   One problem it will bring is: because `new TreeSet<>(HoodieLogFile.getReverseLogFileComparator())` is used when constructing FG, when the two logs are exactly the same except for suffix, only one of them will exist in logFiles.
   
   ### Impact
   
   Fix LogFileComparator
   
   ### Risk level (write none, low medium or high below)
   
   low
   
   ### Documentation Update
   
   None
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #7629: [HUDI-5519] Fix LogFileComparator with suffix for CDC

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7629:
URL: https://github.com/apache/hudi/pull/7629#issuecomment-1375380808

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7b1d92a17c8754b28cf7a926b68c9aa74eb9f032",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14189",
       "triggerID" : "7b1d92a17c8754b28cf7a926b68c9aa74eb9f032",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7b1d92a17c8754b28cf7a926b68c9aa74eb9f032 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14189) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] YannByron commented on pull request #7629: [HUDI-5519] Fix LogFileComparator with suffix for CDC

Posted by GitBox <gi...@apache.org>.
YannByron commented on PR #7629:
URL: https://github.com/apache/hudi/pull/7629#issuecomment-1376623371

   Looks good.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #7629: [HUDI-5519] Fix LogFileComparator with suffix for CDC

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7629:
URL: https://github.com/apache/hudi/pull/7629#issuecomment-1376247285

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7b1d92a17c8754b28cf7a926b68c9aa74eb9f032",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14189",
       "triggerID" : "7b1d92a17c8754b28cf7a926b68c9aa74eb9f032",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6cc0a5200e2115a2a74e558564c24df4b4eaec69",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14196",
       "triggerID" : "6cc0a5200e2115a2a74e558564c24df4b4eaec69",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6cc0a5200e2115a2a74e558564c24df4b4eaec69 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14196) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #7629: [HUDI-5519] Fix LogFileComparator with suffix for CDC

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7629:
URL: https://github.com/apache/hudi/pull/7629#issuecomment-1375370677

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7b1d92a17c8754b28cf7a926b68c9aa74eb9f032",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "7b1d92a17c8754b28cf7a926b68c9aa74eb9f032",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7b1d92a17c8754b28cf7a926b68c9aa74eb9f032 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] YannByron merged pull request #7629: [HUDI-5519] Fix LogFileComparator with suffix for CDC

Posted by GitBox <gi...@apache.org>.
YannByron merged PR #7629:
URL: https://github.com/apache/hudi/pull/7629


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #7629: [HUDI-5519] Fix LogFileComparator with suffix for CDC

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7629:
URL: https://github.com/apache/hudi/pull/7629#issuecomment-1375859437

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7b1d92a17c8754b28cf7a926b68c9aa74eb9f032",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14189",
       "triggerID" : "7b1d92a17c8754b28cf7a926b68c9aa74eb9f032",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6cc0a5200e2115a2a74e558564c24df4b4eaec69",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14196",
       "triggerID" : "6cc0a5200e2115a2a74e558564c24df4b4eaec69",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7b1d92a17c8754b28cf7a926b68c9aa74eb9f032 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14189) 
   * 6cc0a5200e2115a2a74e558564c24df4b4eaec69 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14196) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #7629: [HUDI-5519] Fix LogFileComparator with suffix for CDC

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7629:
URL: https://github.com/apache/hudi/pull/7629#issuecomment-1375847176

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7b1d92a17c8754b28cf7a926b68c9aa74eb9f032",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14189",
       "triggerID" : "7b1d92a17c8754b28cf7a926b68c9aa74eb9f032",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6cc0a5200e2115a2a74e558564c24df4b4eaec69",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6cc0a5200e2115a2a74e558564c24df4b4eaec69",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7b1d92a17c8754b28cf7a926b68c9aa74eb9f032 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14189) 
   * 6cc0a5200e2115a2a74e558564c24df4b4eaec69 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org