You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by GitBox <gi...@apache.org> on 2022/11/04 00:06:10 UTC
[GitHub] [cxf] cunningt opened a new pull request, #1021: Reconcile CXF bom with current artifacts
cunningt opened a new pull request, #1021:
URL: https://github.com/apache/cxf/pull/1021
Noticed there were some missing BOM entries for some of the CXF artifacts, and could not find cxf-services-sts-war.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] cunningt commented on a diff in pull request #1021: Reconcile CXF bom with current artifacts
Posted by GitBox <gi...@apache.org>.
cunningt commented on code in PR #1021:
URL: https://github.com/apache/cxf/pull/1021#discussion_r1019649439
##########
bom/pom.xml:
##########
@@ -156,12 +161,12 @@
</dependency>
<dependency>
<groupId>org.apache.cxf</groupId>
- <artifactId>cxf-rt-management</artifactId>
+ <artifactId>cxf-rt-javascript-tests</artifactId>
Review Comment:
Removed cxf-rt-javascript-tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] cunningt commented on a diff in pull request #1021: Reconcile CXF bom with current artifacts
Posted by GitBox <gi...@apache.org>.
cunningt commented on code in PR #1021:
URL: https://github.com/apache/cxf/pull/1021#discussion_r1019648710
##########
bom/pom.xml:
##########
@@ -449,6 +504,11 @@
<artifactId>cxf-tools-wsdlto-frontend-jaxws</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
Review Comment:
Removed cxf-tools-wsdlto-test
##########
bom/pom.xml:
##########
@@ -459,6 +519,11 @@
<artifactId>cxf-codegen-plugin</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
Review Comment:
Removed maven-plugins
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] reta commented on a diff in pull request #1021: Reconcile CXF bom with current artifacts
Posted by GitBox <gi...@apache.org>.
reta commented on code in PR #1021:
URL: https://github.com/apache/cxf/pull/1021#discussion_r1013513425
##########
bom/pom.xml:
##########
@@ -264,6 +284,26 @@
<artifactId>cxf-rt-rs-service-description</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.cxf</groupId>
+ <artifactId>cxf-rt-rs-service-description-openapi-v3</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
Review Comment:
The `cxf-rt-rs-service-description-common-openapi` should probably not be there as well, it is more or less internal to CXF implementation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] cunningt commented on a diff in pull request #1021: Reconcile CXF bom with current artifacts
Posted by GitBox <gi...@apache.org>.
cunningt commented on code in PR #1021:
URL: https://github.com/apache/cxf/pull/1021#discussion_r1019649620
##########
bom/pom.xml:
##########
@@ -264,6 +284,26 @@
<artifactId>cxf-rt-rs-service-description</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.cxf</groupId>
+ <artifactId>cxf-rt-rs-service-description-openapi-v3</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
Review Comment:
Removed cxf-rt-rs-service-description-common-openapi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] reta commented on a diff in pull request #1021: Reconcile CXF bom with current artifacts
Posted by GitBox <gi...@apache.org>.
reta commented on code in PR #1021:
URL: https://github.com/apache/cxf/pull/1021#discussion_r1013513840
##########
bom/pom.xml:
##########
@@ -384,6 +429,11 @@
<artifactId>cxf-rt-security</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
Review Comment:
This is one is certainly should not be there, this is internal OSGi bundle and should not be consumed by applications or services directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] reta commented on a diff in pull request #1021: Reconcile CXF bom with current artifacts
Posted by GitBox <gi...@apache.org>.
reta commented on code in PR #1021:
URL: https://github.com/apache/cxf/pull/1021#discussion_r1013512857
##########
bom/pom.xml:
##########
@@ -156,12 +161,12 @@
</dependency>
<dependency>
<groupId>org.apache.cxf</groupId>
- <artifactId>cxf-rt-management</artifactId>
+ <artifactId>cxf-rt-javascript-tests</artifactId>
Review Comment:
The tests artifacts (like `cxf-rt-javascript-tests`) should very likely not be there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] reta commented on a diff in pull request #1021: Reconcile CXF bom with current artifacts
Posted by GitBox <gi...@apache.org>.
reta commented on code in PR #1021:
URL: https://github.com/apache/cxf/pull/1021#discussion_r1013513916
##########
bom/pom.xml:
##########
@@ -449,6 +504,11 @@
<artifactId>cxf-tools-wsdlto-frontend-jaxws</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
Review Comment:
Also, test one, please remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] reta merged pull request #1021: Reconcile CXF bom with current artifacts
Posted by GitBox <gi...@apache.org>.
reta merged PR #1021:
URL: https://github.com/apache/cxf/pull/1021
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] reta commented on a diff in pull request #1021: Reconcile CXF bom with current artifacts
Posted by GitBox <gi...@apache.org>.
reta commented on code in PR #1021:
URL: https://github.com/apache/cxf/pull/1021#discussion_r1019734776
##########
bom/pom.xml:
##########
@@ -264,6 +279,16 @@
<artifactId>cxf-rt-rs-service-description</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
Review Comment:
Apologies, I missed this one, the `cxf-rt-rs-service-description-swagger` is gone in `main` (the 1.x does not support Jakarta), could you please remove it? (I will bring it back on backports).
[1] https://github.com/apache/cxf/pull/1000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] reta commented on a diff in pull request #1021: Reconcile CXF bom with current artifacts
Posted by GitBox <gi...@apache.org>.
reta commented on code in PR #1021:
URL: https://github.com/apache/cxf/pull/1021#discussion_r1013514151
##########
bom/pom.xml:
##########
@@ -459,6 +519,11 @@
<artifactId>cxf-codegen-plugin</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
Review Comment:
AFAIK plugins are not imported as part of BOMs (please correct me if I am wrong), should not be there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] reta commented on pull request #1021: Reconcile CXF bom with current artifacts
Posted by GitBox <gi...@apache.org>.
reta commented on PR #1021:
URL: https://github.com/apache/cxf/pull/1021#issuecomment-1302831725
@cunningt thanks a lot for taking a lead on this one (always wanted to do that), a few minor comments, but looks good otherwise
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] cunningt commented on a diff in pull request #1021: Reconcile CXF bom with current artifacts
Posted by GitBox <gi...@apache.org>.
cunningt commented on code in PR #1021:
URL: https://github.com/apache/cxf/pull/1021#discussion_r1019648983
##########
bom/pom.xml:
##########
@@ -566,6 +626,11 @@
<artifactId>cxf-services-xkms-features</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
Review Comment:
cxf-services-xkms-itests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] cunningt commented on a diff in pull request #1021: Reconcile CXF bom with current artifacts
Posted by GitBox <gi...@apache.org>.
cunningt commented on code in PR #1021:
URL: https://github.com/apache/cxf/pull/1021#discussion_r1019742177
##########
bom/pom.xml:
##########
@@ -264,6 +279,16 @@
<artifactId>cxf-rt-rs-service-description</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
Review Comment:
No worries, removed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] cunningt commented on a diff in pull request #1021: Reconcile CXF bom with current artifacts
Posted by GitBox <gi...@apache.org>.
cunningt commented on code in PR #1021:
URL: https://github.com/apache/cxf/pull/1021#discussion_r1019648515
##########
bom/pom.xml:
##########
@@ -384,6 +429,11 @@
<artifactId>cxf-rt-security</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
Review Comment:
Removed cxf-servlet-compatible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] cunningt commented on pull request #1021: Reconcile CXF bom with current artifacts
Posted by GitBox <gi...@apache.org>.
cunningt commented on PR #1021:
URL: https://github.com/apache/cxf/pull/1021#issuecomment-1310959595
Removed the test artifacts / internal artifacts and removed the maven plugins.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] reta commented on a diff in pull request #1021: Reconcile CXF bom with current artifacts
Posted by GitBox <gi...@apache.org>.
reta commented on code in PR #1021:
URL: https://github.com/apache/cxf/pull/1021#discussion_r1013514269
##########
bom/pom.xml:
##########
@@ -566,6 +626,11 @@
<artifactId>cxf-services-xkms-features</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
Review Comment:
Also test one, please remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org