You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/10/12 21:59:24 UTC

[GitHub] [beam] tvalentyn commented on a change in pull request #15675: [BEAM-12313] - Initial changes to support Java 17 SDK Harness docker image

tvalentyn commented on a change in pull request #15675:
URL: https://github.com/apache/beam/pull/15675#discussion_r724407354



##########
File path: .test-infra/jenkins/job_LoadTests_CoGBK_Dataflow_V2_Java17.groovy
##########
@@ -0,0 +1,260 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one

Review comment:
       is it possible to be able to extract common configurations of this and other tests, and parameterize them by java version so that we don't have duplicate all of the configuration bits for each version?
   
   We should try to minimize the number of places we have to edit when adding and removing a new version.
   
   Something we tried to do for Python: 
   
   https://github.com/apache/beam/blob/master/.test-infra/jenkins/PythonTestProperties.groovy
   https://github.com/apache/beam/blob/master/sdks/python/test-suites/gradle.properties




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org