You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/30 01:52:17 UTC

[GitHub] [pulsar] addisonj opened a new pull request #12245: Fix Pulsar Proxy to re-use authentication instance

addisonj opened a new pull request #12245:
URL: https://github.com/apache/pulsar/pull/12245


   Currently, the Pulsar Proxy creates a new PulsarClientImpl with a new
   instance of the client authentication plugin.
   
   For certain client auth implementations, this can cause issues. For
   example, if a client plugin needs to generate a token and then cache and
   re-use it (which is very common with typical Pulsar client usage) this
   pattern breaks, because the client auth plugin is tied to the
   lifecycle of the connection and not the more "singleton" usage of the
   Pulsar client.
   
   Arguably, we should instead figure out how to re-use the entire Pulsar
   client, but that likely has more complexity, instead this "quick fix"
   will get one of the most obvious cases solved.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] addisonj commented on pull request #12245: Fix Pulsar Proxy to re-use authentication instance

Posted by GitBox <gi...@apache.org>.
addisonj commented on pull request #12245:
URL: https://github.com/apache/pulsar/pull/12245#issuecomment-937478570






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli merged pull request #12245: Fix Pulsar Proxy to re-use authentication instance

Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #12245:
URL: https://github.com/apache/pulsar/pull/12245


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on pull request #12245: Fix Pulsar Proxy to re-use authentication instance

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #12245:
URL: https://github.com/apache/pulsar/pull/12245#issuecomment-930933998


   Thanks for your contribution. For this PR, do we need to update docs?
   
   (The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli merged pull request #12245: Fix Pulsar Proxy to re-use authentication instance

Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #12245:
URL: https://github.com/apache/pulsar/pull/12245


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] addisonj commented on pull request #12245: Fix Pulsar Proxy to re-use authentication instance

Posted by GitBox <gi...@apache.org>.
addisonj commented on pull request #12245:
URL: https://github.com/apache/pulsar/pull/12245#issuecomment-937478570


   Test has been added (via re-using existing test which wasn't very logical)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] addisonj commented on pull request #12245: Fix Pulsar Proxy to re-use authentication instance

Posted by GitBox <gi...@apache.org>.
addisonj commented on pull request #12245:
URL: https://github.com/apache/pulsar/pull/12245#issuecomment-937868330


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org