You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/07/26 22:37:15 UTC
[GitHub] [maven-surefire] mpkorstanje opened a new pull request #385: SUREFIRE-1849 Invoke runListener.testSet{Starting,Completed}
mpkorstanje opened a new pull request #385:
URL: https://github.com/apache/maven-surefire/pull/385
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #385: SUREFIRE-1849 Invoke runListener.testSet{Starting,Completed}
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #385:
URL: https://github.com/apache/maven-surefire/pull/385#issuecomment-891391910
@mpkorstanje
You think that this change may be harmful for some engines?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] mpkorstanje commented on pull request #385: SUREFIRE-1849 Invoke runListener.testSet{Starting,Completed}
Posted by GitBox <gi...@apache.org>.
mpkorstanje commented on pull request #385:
URL: https://github.com/apache/maven-surefire/pull/385#issuecomment-889948705
I started this as a draft (I thought) as a supplement to my comments on SUREFIRE-1849. This fix works but functionally results in effects that are wanted for some test engines, but not for others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] mpkorstanje commented on pull request #385: SUREFIRE-1849 Invoke runListener.testSet{Starting,Completed}
Posted by GitBox <gi...@apache.org>.
mpkorstanje commented on pull request #385:
URL: https://github.com/apache/maven-surefire/pull/385#issuecomment-891604694
With this change it will always report the stop and start of the root node. So for Junit Jupiter an extra empty XML file will be written.
For Cucumber however the root node is needed to make sure all tests have a set to be reported in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #385: SUREFIRE-1849 Invoke runListener.testSet{Starting,Completed}
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #385:
URL: https://github.com/apache/maven-surefire/pull/385#issuecomment-889856667
@mpkorstanje
I turned this draft to PR.
Please see the unit tests in the [CI](https://github.com/apache/maven-surefire/pull/385/checks?check_run_id=3166476646) if you have access to the CI logs. Not sure how much this is a relevant code proposal if the unit tests fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] mpkorstanje edited a comment on pull request #385: SUREFIRE-1849 Invoke runListener.testSet{Starting,Completed}
Posted by GitBox <gi...@apache.org>.
mpkorstanje edited a comment on pull request #385:
URL: https://github.com/apache/maven-surefire/pull/385#issuecomment-899399521
Looks like JUnit 5.8 will be released soon. We'll most likely have a proper way to fix this problem (on the Cucumber side of things).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #385: SUREFIRE-1849 Invoke runListener.testSet{Starting,Completed}
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #385:
URL: https://github.com/apache/maven-surefire/pull/385#issuecomment-899656433
@mpkorstanje
ok, if you think, we should reopen this ticket, let me know and we will continue on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #385: SUREFIRE-1849 Invoke runListener.testSet{Starting,Completed}
Posted by GitBox <gi...@apache.org>.
Tibor17 edited a comment on pull request #385:
URL: https://github.com/apache/maven-surefire/pull/385#issuecomment-899656433
@mpkorstanje
ok, if you think, we should reopen this ticket, let me know anytime and we will continue on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] mpkorstanje closed pull request #385: SUREFIRE-1849 Invoke runListener.testSet{Starting,Completed}
Posted by GitBox <gi...@apache.org>.
mpkorstanje closed pull request #385:
URL: https://github.com/apache/maven-surefire/pull/385
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] mpkorstanje commented on pull request #385: SUREFIRE-1849 Invoke runListener.testSet{Starting,Completed}
Posted by GitBox <gi...@apache.org>.
mpkorstanje commented on pull request #385:
URL: https://github.com/apache/maven-surefire/pull/385#issuecomment-899399521
Looks like JUnit 5.8 will be released soon. We'll most likely have a proper way to fix this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org