You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/03/16 21:52:59 UTC
[GitHub] cjolivier01 commented on a change in pull request #10135: [MXNET-100] Fix buggy type inference in Correlation
cjolivier01 commented on a change in pull request #10135: [MXNET-100] Fix buggy type inference in Correlation
URL: https://github.com/apache/incubator-mxnet/pull/10135#discussion_r175222966
##########
File path: src/operator/correlation-inl.h
##########
@@ -232,10 +232,10 @@ void Init(const std::vector<std::pair<std::string, std::string> >& kwargs) overr
std::vector<int> *out_type,
std::vector<int> *aux_type) const override {
int dtype = (*in_type)[0];
- type_assign(&(*in_type)[1], dtype);
- type_assign(&(*out_type)[0], dtype);
- type_assign(&(*out_type)[1], dtype);
- type_assign(&(*out_type)[2], dtype);
+ type_assign(&dtype, (*in_type)[1]);
Review comment:
is it just trying to set all of the inputs to the first non -1 output type?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services